carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 21:00:13 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Check explicit params exist. (#4875)

Browse Source 
If there are no explicit params, then `last_param_node_id` should be
`implicit_params_loc_id`. But there is no use case currently, so for now
we assume explicit params exist and assert if not, so this can be found
and updated then.
This commit is contained in:
Alina Sbirlea
2025-01-31 19:53:43 +00:00
committed by GitHub
parent b0b1554904
commit e4e6332ad4
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/name_component.cpp
+3 -3
View File
@@ -36,9 +36,9 @@ auto PopNameComponent(Context& context, SemIR::InstId return_slot_pattern_id)
context.node_stack()
.PopForSoloNodeId<Parse::NodeKind::ImplicitParamListStart>();
// Only use the end of implicit params if there weren't explicit params.
if (last_param_node_id.has_value()) {
last_param_node_id = params_loc_id;
}
CARBON_CHECK(last_param_node_id.has_value(),
"Implicit parameters currently only occur before explicit "
"parameters, update and test when this changes");
} else {
implicit_param_patterns_id = SemIR::InstBlockId::None;
}