From e4e6332ad4a4264f796457d378a9fbe0672fbeb8 Mon Sep 17 00:00:00 2001 From: Alina Sbirlea Date: Fri, 31 Jan 2025 11:53:43 -0800 Subject: [PATCH] Check explicit params exist. (#4875) If there are no explicit params, then `last_param_node_id` should be `implicit_params_loc_id`. But there is no use case currently, so for now we assume explicit params exist and assert if not, so this can be found and updated then. --- toolchain/check/name_component.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/toolchain/check/name_component.cpp b/toolchain/check/name_component.cpp index 9da2369e97ac..43593e906bd3 100644 --- a/toolchain/check/name_component.cpp +++ b/toolchain/check/name_component.cpp @@ -36,9 +36,9 @@ auto PopNameComponent(Context& context, SemIR::InstId return_slot_pattern_id) context.node_stack() .PopForSoloNodeId(); // Only use the end of implicit params if there weren't explicit params. - if (last_param_node_id.has_value()) { - last_param_node_id = params_loc_id; - } + CARBON_CHECK(last_param_node_id.has_value(), + "Implicit parameters currently only occur before explicit " + "parameters, update and test when this changes"); } else { implicit_param_patterns_id = SemIR::InstBlockId::None; }