starred/shelfmark
1
0
Fork 0
mirror of https://github.com/calibrain/shelfmark.git synced 2026-09-24 20:40:27 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

fix(search): include default language in search query filters (#704)

Browse Source 
## Bug description

When a default language was configured, it was **not passed as a search
filter**.
This occurred regardless of configuration via UI or environment
variables.

## Fix

Updated filter logic so that the default language is always applied when
no explicit filter is provided:

```python
for value in filters.lang if filters.lang else config.BOOK_LANGUAGE or []:
    if value and value != "all":
        filters_query += f"&lang={quote(value)}"
```

This ensures:
- the default language is used when available
- empty or invalid values are ignored
- "all" does not apply a language filter

## Testing
- default language via UI → search filters correctly
- default language via environment variable → search filters correctly
- "all" value → no language filter applied
This commit is contained in:
Giovanni Scieri
2026-03-05 16:25:19 +00:00
committed by GitHub
parent ba92ad90bc
commit 447ed1a924
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
shelfmark/release_sources/direct_download.py
+2 -2
View File
@@ -164,8 +164,8 @@ def search_books(query: str, filters: SearchFilters) -> List[BookInfo]:
filters_query = ""
for value in filters.lang if filters.lang is not None else config.BOOK_LANGUAGE:
if value != "all":
for value in filters.lang if filters.lang else config.BOOK_LANGUAGE or []:
if value and value != "all":
filters_query += f"&lang={quote(value)}"
if filters.sort and filters.sort != "relevance":