starred/nginx-proxy-manager
1
0 Fork 0
mirror of https://github.com/NginxProxyManager/nginx-proxy-manager.git synced 2026-11-15 15:08:04 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

Skip propagation seconds option for Route 53 DNS challenge

Browse Source 
certbot deprecated --dns-route53-propagation-seconds in 2.5.0 and
removed it in 3.0.0, so requesting a Route 53 certificate with a
propagation value fails with "unrecognized arguments". The plugin
waits for the record through the AWS GetChange API instead.

Fixes #4702
Fixes #5414

Co-authored-by: Pascaru <23747773+pascaruchan@users.noreply.github.com>
This commit is contained in:
Junker der ProvinzandPascaru committed 2026-10-24 19:17:37 +02:00
1 parent 1aca775cb9
commit 9780e22792
1 file changed
+2 -1
Download Patch File Download Diff File Expand all files Collapse all files
backend/internal/certificate.js
+2 -1
View File
@@ -862,7 +862,8 @@ const internalCertificate = {
if (hasConfigArg) {
args.push(`--${dnsPlugin.full_plugin_name}-credentials`, credentialsLocation);
}
if (certificate.meta.propagation_seconds !== undefined) {
// The route53 plugin waits for the change through the AWS API and has no propagation option
if (certificate.meta.propagation_seconds !== undefined && certificate.meta.dns_provider !== "route53") {
args.push(
`--${dnsPlugin.full_plugin_name}-propagation-seconds`,
certificate.meta.propagation_seconds.toString(),