starred/nginx-proxy-manager
1
0
Fork 0
mirror of https://github.com/NginxProxyManager/nginx-proxy-manager.git synced 2026-10-05 21:31:09 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Merge pull request #5891 from Amitind/fix/5128-hide-certificate-key

Browse Source 
fix: omit certificate_key from certificate API responses
This commit is contained in:
jc21
2026-09-26 19:30:31 +10:00
committed by GitHub
parent de65105744 a54b73f153
commit 5dcaf28d7c
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/internal/certificate.js
+1 -1
View File
@@ -25,7 +25,7 @@ const certbotLogsDir = "/data/logs";
const certbotWorkDir = "/tmp/letsencrypt-lib";
const omissions = () => {
return ["is_deleted", "owner.is_deleted", "meta.dns_provider_credentials"];
return ["is_deleted", "owner.is_deleted", "meta.dns_provider_credentials", "meta.certificate_key"];
};
const internalCertificate = {
test/cypress/e2e/api/Certificates.cy.js
+3
View File
@@ -69,6 +69,9 @@ describe('Certificates endpoints', () => {
}).then((data) => {
cy.validateSwaggerSchema('get', 200, '/nginx/certificates', data);
expect(data.length).to.be.greaterThan(0);
const cert = data.find((c) => c.id === certID);
expect(cert.meta).to.have.property('certificate');
expect(cert.meta).to.not.have.property('certificate_key');
// Delete cert
cy.task('backendApiDelete', {