Before this patch, there was no proper sorting and the sources.
As @XhmikosR mentioned in StevenBlack/hosts#1166, without this patch,
the output is totally different in Windows. But let's be honest, if it
is like that under Windows, chances are that the same behavior happens
across different OSes or machines around the globe.
Another reason behind this patch is that - desperate the fact that we
certainly trust @StevenBlack - the integrity of the generated files
could not be guarenteed because of the sorting which may be completely
different from an OS to another and a machine to another.
For those reasons, this patch introduces a unification of the sorting of
all sources.
The idea behind this patch is to have @StevenBlack's ad-hoc hosts
file always on top (1st) and the rest of the sources sorted
alphabetically based on the name of the folder inside the `data`
or `extensions` directory.
This will ensure that we get the same result everywhere.
Concretely speaking, I just added the function (`sort_sources`) which
sorts a given list of sources files. And later on, call the new function
everywhere it was necessary. Tests of the newly introduced function
are also included.
Contributors:
* @ScriptTiger
* @XhmikosR
Notes:
* This patch fix (completely ?) ScriptTiger/hosts#1
* This patch fix https://github.com/StevenBlack/hosts/issues/1166#issuecomment-590511086
Hi @StevenBlack
I hope you're going well.
I propose a small change about the link to report an issue about AdAway's default hosts. I link it to the site GitHub project, not the application.
Moreover, @jawz101 has taken over the `hosts` file management. There is [more frequent updates](https://github.com/AdAway/adaway.github.io/commits/master) than ever so you might also want to change the _occasionnaly_ frequence label.
I take the opportunity of this PR to announce your hosts will be integrated as default source for the AdAway application! 🎉
I think some of the users already added it to their configuration but it will be enabled by default for all new users.
I hope it is fine to you. Don't hesitate to tell me if not.
Regards
Steven Black
funilrys
XhmikosR
Anthony Molinaro
PerfectSlayer
Bruce BUJON