starred/Byparr
1
0
Fork 0
mirror of https://github.com/ThePhaseless/Byparr.git synced 2026-09-28 14:20:09 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

test: assert what the challenge tests claim to assert

Browse Source 
Three tests checked solution.status against HTTPStatus.OK, which the
endpoint now hardcodes, so the check could never fail. Drop it everywhere
except the test that exists to pin that behaviour.

That left the self-clearing case asserting only that nothing raised, which
the click test already covers. Give it a measurable widget and assert we
never press it: a challenge that clears on its own is the one case where
touching the checkbox would be wrong, and nothing tested it. Verified by
moving the click ahead of the exit check, which the assertion now catches.

Drop the fake page.evaluate return as well, since /v1 stopped calling it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
ThePhaseless
2026-08-18 04:00:17 +02:00
co-authored by Claude Opus 5
parent 78b3f314c3
commit 11d7e59263
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/main_test.py
+9 -7
View File
@@ -157,7 +157,6 @@ def fake_dep(
request=MagicMock(headers={"user-agent": user_agent} if user_agent else {}),
)
page.title.return_value = "Login"
page.evaluate.return_value = "UnitTestBrowser/1.0"
page.content.return_value = "<html><title>Login</title></html>"
remaining = list(marker_counts or [])
@@ -200,7 +199,6 @@ async def test_networkidle_timeout_after_domcontentloaded_returns_content():
)
assert response.status == "ok"
assert response.solution.status == HTTPStatus.OK
assert response.solution.response == "<html><title>Login</title></html>"
@@ -264,23 +262,27 @@ async def test_checkbox_is_clicked_while_the_challenge_is_up():
LinkRequest(url="https://example.test/login", max_timeout=5), dep
)
assert response.solution.status == HTTPStatus.OK
assert response.status == "ok"
dep.page.mouse.move.assert_awaited_once_with(125.0, 230.0)
dep.page.mouse.down.assert_awaited_once()
dep.page.mouse.up.assert_awaited_once()
@pytest.mark.asyncio
async def test_challenge_that_clears_is_reported_as_success():
"""A challenge is over when its markup goes, not when the solver says so."""
dep = fake_dep(challenged=True, marker_counts=[1, 0])
async def test_challenge_that_clears_on_its_own_is_never_clicked():
"""A challenge is over when its markup goes, and until then we keep our hands off."""
dep = fake_dep(
challenged=True,
marker_counts=[1, 0],
widget_box={"x": 100.0, "y": 200.0, "width": 300.0, "height": 60.0},
)
response = await read_item(
LinkRequest(url="https://example.test/login", max_timeout=5), dep
)
assert response.status == "ok"
assert response.solution.status == HTTPStatus.OK
dep.page.mouse.down.assert_not_awaited()
@pytest.mark.asyncio