carbon-language/carbon-lang
1
0 Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-11-15 14:58:09 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
d0badecd2a504327f974b6282490463d82201aa5
carbon-lang/toolchain/check/testdata/function/declaration/fail_modifiers.carbon
T
Chandler Carruth d0badecd2a Switch tests to use the rendered form of diagnostics (#8070) 
Historically, we disabled the rendered form in tests outside of
`toolchain/diagnostics`. The idea was to keep tests shorter and avoid
very long chains of autoupdate before stabilizing due to all the line
numbers and other artifacts in the rendered form.

This PR adds `--diagnostic-line-numbers=[all|first]` and defaults to
`first` in tests. This keeps the rendered form so that we can easily
code review that form and the visual cues it does or doesn't provide.
But it removes all but the first location's line numbers to provide
significantly more stability in tests.

By default, tests get the full unicode line-drawing form of diagnostics
so we can ensure all of the artifacts there make sense with the specific
case being diagnosed, but we do retain some focused ASCII-rendering
tests to ensure that fallback remains usable.

There are some issues here that will be fixed in subsequent PRs.
Notably, we try to keep the frame together in the check lines, and so
force some parts to use the first location. This largely works, but
fails in some edge cases, causing the entire frame to be located
incorrectly. There is a TODO about this that we need to fix, and it only
occurs 6 times across the test suite, so it didn't seem worth
front-loading a fix for here.

Assisted-by: Claude Code
2026-11-05 07:19:59 +00:00

184 lines
11 KiB
Plaintext
Raw Blame History

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
// TODO: Add ranges and switch to "--dump-sem-ir-ranges=only".
// EXTRA-ARGS: --dump-sem-ir-ranges=if-present
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/function/declaration/fail_modifiers.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/function/declaration/fail_modifiers.carbon
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+15]]:9
// CHECK:STDERR: -> │ default protected fn WrongOrder();
// CHECK:STDERR: · ───┬─── ━━━━┳━━━━
// CHECK:STDERR: · │ ┗━━┫ error: `protected` must appear before `default`
// CHECK:STDERR: · │ ┃ [ModifierMustAppearBefore]
// CHECK:STDERR: · ╰─────────────┤ `default` previously appeared here [ModifierPrevious]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+7]]:1
// CHECK:STDERR: -> │ default protected fn WrongOrder();
// CHECK:STDERR: · ━━━┳━━━
// CHECK:STDERR: · ┗━━┫ error: `default` not allowed; requires interface scope
// CHECK:STDERR: · ┃ [ModifierRequiresInterface]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
default protected fn WrongOrder();
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+14]]:9
// CHECK:STDERR: -> │ virtual virtual fn DuplicateVirtual() {}
// CHECK:STDERR: · ───┬─── ━━━┳━━━
// CHECK:STDERR: · │ ┗━━┫ error: `virtual` repeated on declaration [ModifierRepeated]
// CHECK:STDERR: · ╰────────────┤ `virtual` previously appeared here [ModifierPrevious]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+7]]:1
// CHECK:STDERR: -> │ virtual virtual fn DuplicateVirtual() {}
// CHECK:STDERR: · ━━━┳━━━
// CHECK:STDERR: · ┗━━┫ error: `virtual` not allowed; requires class scope
// CHECK:STDERR: · ┃ [ModifierRequiresClass]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
virtual virtual fn DuplicateVirtual() {}
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+8]]:9
// CHECK:STDERR: -> │ private protected fn TwoAccess();
// CHECK:STDERR: · ───┬─── ━━━━┳━━━━
// CHECK:STDERR: · │ ┗━━┫ error: `protected` not allowed on declaration with `private`
// CHECK:STDERR: · │ ┃ [ModifierNotAllowedWith]
// CHECK:STDERR: · ╰─────────────┤ `private` previously appeared here [ModifierPrevious]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
private protected fn TwoAccess();
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+15]]:10
// CHECK:STDERR: -> │ abstract virtual fn ModifiersConflict() {}
// CHECK:STDERR: · ────┬─── ━━━┳━━━
// CHECK:STDERR: · │ ┗━━┫ error: `virtual` not allowed on declaration with `abstract`
// CHECK:STDERR: · │ ┃ [ModifierNotAllowedWith]
// CHECK:STDERR: · ╰────────────┤ `abstract` previously appeared here [ModifierPrevious]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+7]]:1
// CHECK:STDERR: -> │ abstract virtual fn ModifiersConflict() {}
// CHECK:STDERR: · ━━━━┳━━━
// CHECK:STDERR: · ┗━━┫ error: `abstract` not allowed; requires class scope
// CHECK:STDERR: · ┃ [ModifierRequiresClass]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
abstract virtual fn ModifiersConflict() {}
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+7]]:1
// CHECK:STDERR: -> │ base fn InvalidModifier();
// CHECK:STDERR: · ━━┳━
// CHECK:STDERR: · ┗━━┫ error: `base` not allowed on `fn` declaration
// CHECK:STDERR: · ┃ [ModifierNotAllowedOnDeclaration]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
base fn InvalidModifier();
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+23]]:9
// CHECK:STDERR: -> │ default final virtual fn ModifiersConflict2() {}
// CHECK:STDERR: · ───┬─── ━━┳━━
// CHECK:STDERR: · │ ┗━━┫ error: `final` not allowed on declaration with `default`
// CHECK:STDERR: · │ ┃ [ModifierNotAllowedWith]
// CHECK:STDERR: · ╰───────────┤ `default` previously appeared here [ModifierPrevious]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+15]]:15
// CHECK:STDERR: -> │ default final virtual fn ModifiersConflict2() {}
// CHECK:STDERR: · ───┬─── ━━━┳━━━
// CHECK:STDERR: · │ ┗━━┫ error: `virtual` not allowed on declaration with `default`
// CHECK:STDERR: · │ ┃ [ModifierNotAllowedWith]
// CHECK:STDERR: · ╰──────────────────┤ `default` previously appeared here [ModifierPrevious]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+7]]:1
// CHECK:STDERR: -> │ default final virtual fn ModifiersConflict2() {}
// CHECK:STDERR: · ━━━┳━━━
// CHECK:STDERR: · ┗━━┫ error: `default` not allowed; requires interface scope
// CHECK:STDERR: · ┃ [ModifierRequiresInterface]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
default final virtual fn ModifiersConflict2() {}
// CHECK:STDERR: ╭─┤ fail_modifiers.carbon:[[@LINE+8]]:8
// CHECK:STDERR: -> │ extern private fn ExternOrderAndConflict() {}
// CHECK:STDERR: · ───┬── ━━━┳━━━
// CHECK:STDERR: · │ ┗━━┫ error: `private` must appear before `extern`
// CHECK:STDERR: · │ ┃ [ModifierMustAppearBefore]
// CHECK:STDERR: · ╰───────────┤ `extern` previously appeared here [ModifierPrevious]
// CHECK:STDERR: ╰────
// CHECK:STDERR:
extern private fn ExternOrderAndConflict() {}
// CHECK:STDOUT: --- fail_modifiers.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
// CHECK:STDOUT: %WrongOrder.type: type = fn_type @WrongOrder [concrete]
// CHECK:STDOUT: %WrongOrder: %WrongOrder.type = struct_value () [concrete]
// CHECK:STDOUT: %DuplicateVirtual.type: type = fn_type @DuplicateVirtual [concrete]
// CHECK:STDOUT: %DuplicateVirtual: %DuplicateVirtual.type = struct_value () [concrete]
// CHECK:STDOUT: %TwoAccess.type: type = fn_type @TwoAccess [concrete]
// CHECK:STDOUT: %TwoAccess: %TwoAccess.type = struct_value () [concrete]
// CHECK:STDOUT: %ModifiersConflict.type: type = fn_type @ModifiersConflict [concrete]
// CHECK:STDOUT: %ModifiersConflict: %ModifiersConflict.type = struct_value () [concrete]
// CHECK:STDOUT: %InvalidModifier.type: type = fn_type @InvalidModifier [concrete]
// CHECK:STDOUT: %InvalidModifier: %InvalidModifier.type = struct_value () [concrete]
// CHECK:STDOUT: %ModifiersConflict2.type: type = fn_type @ModifiersConflict2 [concrete]
// CHECK:STDOUT: %ModifiersConflict2: %ModifiersConflict2.type = struct_value () [concrete]
// CHECK:STDOUT: %ExternOrderAndConflict.type: type = fn_type @ExternOrderAndConflict [concrete]
// CHECK:STDOUT: %ExternOrderAndConflict: %ExternOrderAndConflict.type = struct_value () [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace [concrete] {
// CHECK:STDOUT: .WrongOrder = %WrongOrder.decl
// CHECK:STDOUT: .DuplicateVirtual = %DuplicateVirtual.decl
// CHECK:STDOUT: .TwoAccess [private] = %TwoAccess.decl
// CHECK:STDOUT: .ModifiersConflict = %ModifiersConflict.decl
// CHECK:STDOUT: .InvalidModifier = %InvalidModifier.decl
// CHECK:STDOUT: .ModifiersConflict2 = %ModifiersConflict2.decl
// CHECK:STDOUT: .ExternOrderAndConflict = %ExternOrderAndConflict.decl
// CHECK:STDOUT: }
// CHECK:STDOUT: %WrongOrder.decl: %WrongOrder.type = fn_decl @WrongOrder [concrete = constants.%WrongOrder] {} {}
// CHECK:STDOUT: %DuplicateVirtual.decl: %DuplicateVirtual.type = fn_decl @DuplicateVirtual [concrete = constants.%DuplicateVirtual] {} {}
// CHECK:STDOUT: %TwoAccess.decl: %TwoAccess.type = fn_decl @TwoAccess [concrete = constants.%TwoAccess] {} {}
// CHECK:STDOUT: %ModifiersConflict.decl: %ModifiersConflict.type = fn_decl @ModifiersConflict [concrete = constants.%ModifiersConflict] {} {}
// CHECK:STDOUT: %InvalidModifier.decl: %InvalidModifier.type = fn_decl @InvalidModifier [concrete = constants.%InvalidModifier] {} {}
// CHECK:STDOUT: %ModifiersConflict2.decl: %ModifiersConflict2.type = fn_decl @ModifiersConflict2 [concrete = constants.%ModifiersConflict2] {} {}
// CHECK:STDOUT: %ExternOrderAndConflict.decl: %ExternOrderAndConflict.type = fn_decl @ExternOrderAndConflict [concrete = constants.%ExternOrderAndConflict] {} {}
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @WrongOrder();
// CHECK:STDOUT:
// CHECK:STDOUT: fn @DuplicateVirtual() {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: return
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @TwoAccess();
// CHECK:STDOUT:
// CHECK:STDOUT: fn @ModifiersConflict() {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: return
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @InvalidModifier();
// CHECK:STDOUT:
// CHECK:STDOUT: fn @ModifiersConflict2() {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: return
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: extern fn @ExternOrderAndConflict() {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: return
// CHECK:STDOUT: }
// CHECK:STDOUT:
Reference in new issue View Git Blame Copy Permalink