mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-29 14:04:57 +01:00
Chandler Carruth
d010d52f37
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
53 lines
1.7 KiB
C++
53 lines
1.7 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_SEM_IR_CPP_OVERLOAD_SET_H_
|
|
#define CARBON_TOOLCHAIN_SEM_IR_CPP_OVERLOAD_SET_H_
|
|
|
|
#include "clang/AST/Decl.h"
|
|
#include "clang/AST/UnresolvedSet.h"
|
|
#include "clang/Sema/Overload.h"
|
|
#include "common/ostream.h"
|
|
#include "toolchain/base/value_store.h"
|
|
#include "toolchain/sem_ir/ids.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
// An overloaded C++ function.
|
|
struct CppOverloadSet : public Printable<CppOverloadSet> {
|
|
// The function's name.
|
|
NameId name_id;
|
|
|
|
// The parent scope.
|
|
NameScopeId parent_scope_id;
|
|
|
|
// The naming class in the name lookup that found this overload set.
|
|
clang::CXXRecordDecl* naming_class;
|
|
|
|
// List of all named decls found at name lookup.
|
|
// TODO: Find a good small size for the UnresolvedSet<size> or rework how we
|
|
// store the candidates.
|
|
clang::UnresolvedSet<4> candidate_functions;
|
|
|
|
/// Information about operator rewrites to consider when adding operator
|
|
/// functions to a candidate set.
|
|
clang::OverloadCandidateSet::OperatorRewriteInfo operator_rewrite_info;
|
|
|
|
auto Print(llvm::raw_ostream& out) const -> void {
|
|
out << "name: " << name_id << ", parent_scope: " << parent_scope_id;
|
|
}
|
|
};
|
|
|
|
using CppOverloadSetStore =
|
|
ValueStore<CppOverloadSetId, CppOverloadSet, Tag<CheckIRId>>;
|
|
|
|
} // namespace Carbon::SemIR
|
|
|
|
namespace Carbon {
|
|
extern template class ValueStore<SemIR::CppOverloadSetId, SemIR::CppOverloadSet,
|
|
Tag<SemIR::CheckIRId>>;
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_TOOLCHAIN_SEM_IR_CPP_OVERLOAD_SET_H_
|