mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-29 08:24:58 +01:00
Chandler Carruth
d010d52f37
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
74 lines
2.9 KiB
C++
74 lines
2.9 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/sem_ir/constant.h"
|
|
|
|
#include "toolchain/base/value_store_impl.h"
|
|
#include "toolchain/sem_ir/file.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
auto ConstantStore::GetOrAdd(Inst inst, ConstantDependence dependence)
|
|
-> ConstantId {
|
|
auto result = map_.Insert(inst, [&] {
|
|
auto inst_id = sem_ir_->insts().AddInNoBlock(LocIdAndInst::NoLoc(inst));
|
|
ConstantId const_id = ConstantId::None;
|
|
if (dependence == ConstantDependence::None) {
|
|
const_id = ConstantId::ForConcreteConstant(inst_id);
|
|
} else {
|
|
// The instruction in the constants store is an abstract symbolic
|
|
// constant, not associated with any particular generic.
|
|
SymbolicConstant symbolic_constant = {.inst_id = inst_id,
|
|
.generic_id = GenericId::None,
|
|
.index = GenericInstIndex::None,
|
|
.dependence = dependence};
|
|
const_id =
|
|
sem_ir_->constant_values().AddSymbolicConstant(symbolic_constant);
|
|
}
|
|
sem_ir_->constant_values().Set(inst_id, const_id);
|
|
constants_.push_back(inst_id);
|
|
return const_id;
|
|
});
|
|
CARBON_CHECK(result.value() != ConstantId::None);
|
|
CARBON_CHECK(
|
|
result.value().is_symbolic() == (dependence != ConstantDependence::None),
|
|
"Constant {0} registered as both symbolic and concrete constant.", inst);
|
|
return result.value();
|
|
}
|
|
|
|
auto GetInstWithConstantValue(const File& file, ConstantId const_id) -> InstId {
|
|
if (!const_id.has_value() || !const_id.is_constant()) {
|
|
return InstId::None;
|
|
}
|
|
|
|
// For concrete constants, the corresponding instruction has the desired
|
|
// constant value.
|
|
if (!const_id.is_symbolic()) {
|
|
return file.constant_values().GetInstId(const_id);
|
|
}
|
|
|
|
// For unattached symbolic constants, the corresponding instruction has the
|
|
// desired constant value.
|
|
const auto& symbolic_const =
|
|
file.constant_values().GetSymbolicConstant(const_id);
|
|
if (!symbolic_const.generic_id.has_value()) {
|
|
return file.constant_values().GetInstId(const_id);
|
|
}
|
|
|
|
// For attached symbolic constants, pick the corresponding instruction out of
|
|
// the eval block for the generic.
|
|
const auto& generic = file.generics().Get(symbolic_const.generic_id);
|
|
auto block = generic.GetEvalBlock(symbolic_const.index.region());
|
|
return file.inst_blocks().Get(block)[symbolic_const.index.index()];
|
|
}
|
|
|
|
} // namespace Carbon::SemIR
|
|
|
|
namespace Carbon {
|
|
template class ValueStore<SemIR::InstId, SemIR::ConstantId,
|
|
Tag<SemIR::CheckIRId>>;
|
|
template class ValueStore<SemIR::ConstantId::SymbolicId,
|
|
SemIR::SymbolicConstant, Tag<SemIR::CheckIRId>>;
|
|
} // namespace Carbon
|