Files
carbon-lang/toolchain/check/handle_export.cpp
T
Chandler CarruthandJon Ross-Perkins 8992d22ab3 Port the toolchain to use the new Carbon hashtable (#4097)
This works to leverage the capabilities of the hashtable as much as
possible, for example using the key context in the value stores.
However, there may still be opportunities to refactor more deeply and
use the functionality even better. Hopefully this is at least
a reasonable start and gets us a clean baseline.

On an Arm M1, this is a 15% improvement on my large lexing stress test,
but ends up a wash on my x86-64 server. This is a smaller benefit than
I expected, and it's because we're using a set-of-IDs and looking up
values with a key context for things like identifiers. This pattern has
a surprising tradeoff. The new hashtable uses significantly less memory,
a 10% peak RSS reduction just from the hashtable change. But indirecting
through the vector of values makes growing the hashtable dramatically
less cache-friendly: it causes growth to randomly access every key when
rehashing. On x86, everything gained by the faster hashtable is lost in
even slower growth. And even on Arm, this eats into the benefits.

But I have a plan to tweak how identifiers specifically work to avoid
most of the growth, and so I suspect this is the right tradeoff on the
whole. It gives us significant working set size reduction and we can
likely avoid the regressed operation (growth with rehash) in most cases
by clever reserving and if necessary by adding a hash caching layer to
the table infrastructure.

---------

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
2024-07-03 01:10:44 +00:00

90 lines
3.3 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/check/context.h"
#include "toolchain/check/decl_name_stack.h"
#include "toolchain/check/handle.h"
#include "toolchain/check/modifiers.h"
#include "toolchain/check/name_component.h"
#include "toolchain/parse/typed_nodes.h"
#include "toolchain/sem_ir/ids.h"
#include "toolchain/sem_ir/typed_insts.h"
namespace Carbon::Check {
auto HandleExportIntroducer(Context& context,
Parse::ExportIntroducerId /*node_id*/) -> bool {
context.decl_introducer_state_stack().Push<Lex::TokenKind::Export>();
// TODO: Probably need to update DeclNameStack to restrict to only namespaces.
context.decl_name_stack().PushScopeAndStartName();
return true;
}
auto HandleExportDecl(Context& context, Parse::ExportDeclId node_id) -> bool {
auto name_context = context.decl_name_stack().FinishName(
PopNameComponentWithoutParams(context, Lex::TokenKind::Export));
context.decl_name_stack().PopScope();
auto introducer =
context.decl_introducer_state_stack().Pop<Lex::TokenKind::Export>();
LimitModifiersOnDecl(context, introducer, KeywordModifierSet::None);
if (name_context.state == DeclNameStack::NameContext::State::Error) {
// Should already be diagnosed.
return true;
}
auto inst_id = name_context.prev_inst_id();
if (!inst_id.is_valid()) {
context.DiagnoseNameNotFound(node_id, name_context.name_id_for_new_inst());
return true;
}
auto inst = context.insts().Get(inst_id);
if (inst.Is<SemIR::ExportDecl>()) {
CARBON_DIAGNOSTIC(ExportRedundant, Warning,
"`export` matches previous `export`.");
CARBON_DIAGNOSTIC(ExportPrevious, Note, "Previous `export` here.");
context.emitter()
.Build(node_id, ExportRedundant)
// Use the location of the export itself, not the exported instruction.
.Note(context.insts().GetLocId(inst_id), ExportPrevious)
.Emit();
return true;
}
auto import_ref = context.insts().TryGetAs<SemIR::ImportRefLoaded>(inst_id);
if (!import_ref) {
CARBON_DIAGNOSTIC(ExportNotImportedEntity, Error,
"Only imported entities are valid for `export`.");
CARBON_DIAGNOSTIC(ExportNotImportedEntitySource, Note,
"Name is declared here.");
context.emitter()
.Build(node_id, ExportNotImportedEntity)
.Note(inst_id, ExportNotImportedEntitySource)
.Emit();
return true;
}
auto export_id = context.AddInst<SemIR::ExportDecl>(
node_id, {.type_id = import_ref->type_id,
.bind_name_id = import_ref->bind_name_id,
.value_id = inst_id});
context.AddExport(export_id);
// Replace the ImportRef in name lookup, both for the above duplicate
// diagnostic and so that cross-package imports can find it easily.
auto bind_name = context.bind_names().Get(import_ref->bind_name_id);
auto& parent_scope = context.name_scopes().Get(bind_name.parent_scope_id);
auto lookup = parent_scope.name_map.Lookup(bind_name.name_id);
auto& scope_inst_id = parent_scope.names[lookup.value()].inst_id;
CARBON_CHECK(scope_inst_id == inst_id);
scope_inst_id = export_id;
return true;
}
} // namespace Carbon::Check