mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 02:48:12 +00:00
A lot of this is more boring "remove unused header", plus some other minor cleanups. I think the most significant changes were: - yaml_test_helpers.cpp is doing a switch on an unsigned int, comparing to enum values. - [bugprone-switch-missing-default-case](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/switch-missing-default-case.html) is unhappy with EnumBase, but correctly identified yaml_test_helpers.cpp, so I'm opting to address it rather than disabling it even though it needs NOLINT in several locations as a result, in addition to what I think are some low-value `default` cases. I'd be fine going the other way with this too and disabling it globally (I could see it being noisier in the explorer). - MarkInitializerFor swaps the argument names between the .h and .cpp. I think the .cpp had the order as intended. - There's a new-ish [performance-enum-size](https://clang.llvm.org/extra/clang-tidy/checks/performance/enum-size.html) which I'm basically treating as "add int8_t to enums". My main motivation here is to just clean up as many of these as I can so that I stop seeing them in vscode.
43 lines
1.3 KiB
C++
43 lines
1.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/semantics/semantics_node.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
static auto PrintArgs(llvm::raw_ostream& /*out*/,
|
|
const Node::NoArgs /*no_args*/) -> void {}
|
|
|
|
template <typename T>
|
|
static auto PrintArgs(llvm::raw_ostream& out, T arg) -> void {
|
|
out << ", arg0: " << arg;
|
|
}
|
|
|
|
template <typename T0, typename T1>
|
|
static auto PrintArgs(llvm::raw_ostream& out, std::pair<T0, T1> args) -> void {
|
|
PrintArgs(out, args.first);
|
|
out << ", arg1: " << args.second;
|
|
}
|
|
|
|
auto operator<<(llvm::raw_ostream& out, const Node& node)
|
|
-> llvm::raw_ostream& {
|
|
out << "{kind: " << node.kind_;
|
|
// clang warns on unhandled enum values; clang-tidy is incorrect here.
|
|
// NOLINTNEXTLINE(bugprone-switch-missing-default-case)
|
|
switch (node.kind_) {
|
|
#define CARBON_SEMANTICS_NODE_KIND(Name) \
|
|
case NodeKind::Name: \
|
|
PrintArgs(out, node.GetAs##Name()); \
|
|
break;
|
|
#include "toolchain/semantics/semantics_node_kind.def"
|
|
}
|
|
if (node.type_id_.is_valid()) {
|
|
out << ", type: " << node.type_id_;
|
|
}
|
|
out << "}";
|
|
return out;
|
|
}
|
|
|
|
} // namespace Carbon::SemIR
|