carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
b2ab53e49c7f3f5a49af2f715ad874e9ff8f58ae
carbon-lang/toolchain/check
T
History
Dana Jansens 114d892ac1 Clarify and fix diagnostic for missing Self in a require declaration (#6616) 
If `Self` is not in the self type, then it must be an argument to every
interface required by the declaration. Specifically, this means the
interfaces in the identified facet type, and does not matter if `Self`
appears in the arguments of named constraints.

Fix the diagnostic to stop saying "constraint" incorrectly. And improve
clarity by including in the diagnostic which interface it found without
`Self` as an argument, since it may be found in some other named
constraint, rather than directly in the facet type as written.
2026-01-21 16:36:02 +00:00
..
cpp
Allow NRVO in InventClangArgs. (#6624)
2026-01-17 04:27:59 +00:00
fuzzer_corpus
Change array syntax from [T; N] to array(T, N) (#4981)
2025-02-20 22:42:47 +00:00
testdata
Clarify and fix diagnostic for missing Self in a require declaration (#6616)
2026-01-21 16:36:02 +00:00
action.cpp
Clean up singleton TypeId use (#6300)
2025-10-30 22:50:59 +00:00
action.h
Even more usage of TypeInstId (#5296)
2025-04-11 21:47:43 +00:00
BUILD
Perform Clang IRGen during check (#6569)
2026-01-14 00:54:37 +00:00
call.cpp
Remove some uses of ReturnTypeInfo (#6577)
2026-01-13 17:23:27 +00:00
call.h
Model ref tags as insts instead of annotations (#6541)
2026-01-05 22:24:47 +00:00
check_fuzzer.cpp
Switch Driver back to parameters for construction (#4849)
2025-01-27 23:48:44 +00:00
check_unit.cpp
Use lines instead of statements for readability-function-size clang-tidy (#6594)
2026-01-14 19:32:03 +00:00
check_unit.h
Use lines instead of statements for readability-function-size clang-tidy (#6594)
2026-01-14 19:32:03 +00:00
check.cpp
Perform Clang IRGen during check (#6569)
2026-01-14 00:54:37 +00:00
check.h
Perform Clang IRGen during check (#6569)
2026-01-14 00:54:37 +00:00
class.cpp
Mark Check::Context::insts() as const and use it in more use cases (#6093)
2025-09-18 13:04:18 +00:00
class.h
Vtable support for generics (#5793)
2025-07-11 22:29:10 +00:00
context.cpp
Make IdTag typesafe (#6574)
2026-01-13 22:44:38 +00:00
context.h
Expose C++ reference returns as Carbon reference returns (#6618)
2026-01-16 18:08:42 +00:00
control_flow.cpp
Add well-known identifier caching (#6486)
2025-12-11 21:41:47 +00:00
control_flow.h
Handle destruction for return statements (#5785)
2025-07-10 16:32:39 +00:00
convert.cpp
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
convert.h
Give ReturnExpr a target only when initialization is in-place (#6570)
2026-01-13 01:20:15 +00:00
core_identifier.cpp
Add well-known identifier caching (#6486)
2025-12-11 21:41:47 +00:00
core_identifier.def
Add well-known identifier caching (#6486)
2025-12-11 21:41:47 +00:00
core_identifier.h
Add well-known identifier caching (#6486)
2025-12-11 21:41:47 +00:00
custom_witness.cpp
Add Call param patterns to Function (#6586)
2026-01-13 19:30:15 +00:00
custom_witness.h
Change Destroy to use a CustomWitness instead of a blanket impl (#6512)
2025-12-19 18:36:06 +00:00
decl_introducer_state.h
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
decl_name_stack.cpp
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
decl_name_stack.h
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
deduce.cpp
Finish renaming BindName and related insts. (#6281)
2025-10-28 17:17:38 +00:00
deduce.h
Fearlessly hold references into ValueStore again (#5589)
2025-06-03 18:07:23 +00:00
deferred_definition_worklist.cpp
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
deferred_definition_worklist.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
diagnostic_emitter.cpp
Check required implementations when an enclosing interface is implemented (#6522)
2026-01-07 17:05:41 +00:00
diagnostic_emitter.h
Expand use of CheckIRId stores (#5820)
2025-07-21 20:02:27 +00:00
diagnostic_helpers.h
Use explicit(false) for implicit construction (#6039)
2025-09-10 13:47:59 +00:00
dump.cpp
Add lldb dumping for RequireImplsId and RequireImplsBlockId (#6524)
2025-12-19 18:48:20 +00:00
eval_inst.cpp
Fix lowering of imported global variables. (#6567)
2026-01-11 19:22:43 +00:00
eval_inst.h
Use inline constexpr where appropriate. (#6374)
2025-11-14 13:50:56 +00:00
eval.cpp
Allow conversion between T* and Cpp.void*. (#6575)
2026-01-12 16:32:15 +00:00
eval.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
facet_type.cpp
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
facet_type.h
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
full_pattern_stack.h
Allocate CallParamIndexes eagerly (#6540)
2026-01-05 19:38:52 +00:00
function.cpp
Remove some uses of ReturnTypeInfo (#6577)
2026-01-13 17:23:27 +00:00
function.h
Remove some uses of ReturnTypeInfo (#6577)
2026-01-13 17:23:27 +00:00
generic_region_stack.cpp
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
generic_region_stack.h
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
generic.cpp
Add Inst::IsOneOf to check if an inst is one of a few kinds (#6523)
2026-01-07 21:41:05 +00:00
generic.h
Initial support for empty named constraints (#6245)
2025-10-22 18:26:32 +00:00
global_init.cpp
Add Call param patterns to Function (#6586)
2026-01-13 19:30:15 +00:00
global_init.h
Split global init out from InstBlockStack. (#4101)
2024-07-03 17:49:47 +00:00
handle_alias.cpp
Finish renaming BindName and related insts. (#6281)
2025-10-28 17:17:38 +00:00
handle_array.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_binding_pattern.cpp
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
handle_call_expr.cpp
Parse ref as operator (#6539)
2025-12-30 19:18:34 +00:00
handle_choice.cpp
Use the value representation of T as that of MaybeUnformed(T) where possible (#6334)
2025-11-07 16:25:27 +00:00
handle_class.cpp
Switch class to use a blanket impl for Destroy (#6125)
2025-09-29 16:05:06 +00:00
handle_codeblock.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_export.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_expr_statement.cpp
Convert discarded calls in thunks. (#5452)
2025-05-09 16:35:28 +00:00
handle_file.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_function.cpp
[parse] Implement initial parsing support for Lambda expressions (#6583)
2026-01-14 16:58:15 +00:00
handle_if_expr.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_if_statement.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_impl.cpp
Avoid cyclic lookup of an impl inside its own definition (#6629)
2026-01-20 19:28:46 +00:00
handle_import_and_package.cpp
Formalize Cpp as a PackageNameId (#6306)
2025-11-05 17:21:41 +00:00
handle_index.cpp
Add well-known identifier caching (#6486)
2025-12-11 21:41:47 +00:00
handle_interface.cpp
Add require decls to Interface and NamedConstraint (#6321)
2025-11-11 16:36:15 +00:00
handle_lambda.cpp
[parse] Implement initial parsing support for Lambda expressions (#6583)
2026-01-14 16:58:15 +00:00
handle_let_and_var.cpp
Allocate CallParamIndexes eagerly (#6540)
2026-01-05 19:38:52 +00:00
handle_literal.cpp
Add interop support for naming and "calling" C++ templates. (#6474)
2025-12-15 17:45:01 +00:00
handle_loop_statement.cpp
Add well-known identifier caching (#6486)
2025-12-11 21:41:47 +00:00
handle_match.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_modifier.cpp
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
handle_name.cpp
Change the package namespace to use the package name (#6495)
2025-12-16 01:33:53 +00:00
handle_named_constraint.cpp
Add require decls to Interface and NamedConstraint (#6321)
2025-11-11 16:36:15 +00:00
handle_namespace.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_noop.cpp
Abort checking when encountering an invalid parse node (#4700)
2024-12-18 00:19:12 +00:00
handle_operator.cpp
Model ref tags as insts instead of annotations (#6541)
2026-01-05 22:24:47 +00:00
handle_paren_expr.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_pattern_list.cpp
Decouple associated constants from let (#5973)
2025-09-02 23:15:26 +00:00
handle_require.cpp
Clarify and fix diagnostic for missing Self in a require declaration (#6616)
2026-01-21 16:36:02 +00:00
handle_return_statement.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_struct.cpp
Switch zip to zip_equal where possible (#6389)
2025-11-18 00:28:06 +00:00
handle_tuple_literal.cpp
Remove all remaining uses of TypeIds as instruction operands. (#5280)
2025-04-10 20:53:42 +00:00
handle_where.cpp
Use the new IsFacetTypeOrError function (#6438)
2025-12-02 22:33:55 +00:00
handle.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
impl_lookup.cpp
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
impl_lookup.h
Cache final impl lookup results. (#6452)
2025-12-02 22:51:25 +00:00
impl_validation.cpp
Check the orphan rule for impls (#6488)
2025-12-11 19:44:39 +00:00
impl_validation.h
Add diagnostics for invalid impl declarations (#5420)
2025-05-22 18:58:47 +00:00
impl.cpp
Look through extend require in an interface or named constraint in name lookup (#6630)
2026-01-20 22:26:10 +00:00
impl.h
Avoid cyclic lookup of an impl inside its own definition (#6629)
2026-01-20 19:28:46 +00:00
import_ref.cpp
Look through extend require in an interface or named constraint in name lookup (#6630)
2026-01-20 22:26:10 +00:00
import_ref.h
When performing an impl lookup, only import impls for related interfaces. (#6040)
2025-09-10 21:40:27 +00:00
import.cpp
Refactor addition of imported locations and placeholders (#6354)
2025-11-13 18:34:13 +00:00
import.h
Refactor addition of imported locations and placeholders (#6354)
2025-11-13 18:34:13 +00:00
inst_block_stack.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
inst_block_stack.h
Add require decls to Interface and NamedConstraint (#6321)
2025-11-11 16:36:15 +00:00
inst.cpp
Refactor addition of imported locations and placeholders (#6354)
2025-11-13 18:34:13 +00:00
inst.h
Refactor addition of imported locations and placeholders (#6354)
2025-11-13 18:34:13 +00:00
interface.cpp
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
interface.h
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
keyword_modifier_set.cpp
Some more edits to EnumBase and EnumMaskBase (#6054)
2025-09-12 22:59:37 +00:00
keyword_modifier_set.h
Use inline constexpr where appropriate. (#6374)
2025-11-14 13:50:56 +00:00
lexical_lookup.h
Set an explicit size for lexical lookup's vector (#5786)
2025-07-09 22:42:27 +00:00
literal.cpp
Add interop support for naming and "calling" C++ templates. (#6474)
2025-12-15 17:45:01 +00:00
literal.h
Add interop support for naming and "calling" C++ templates. (#6474)
2025-12-15 17:45:01 +00:00
member_access.cpp
Member access into a facet is not a "lookup in type of base" (#6631)
2026-01-20 18:43:16 +00:00
member_access.h
Implement support for mixed-access overload sets. (#6137)
2025-09-26 23:18:16 +00:00
merge.cpp
Remove support for addr (#6375)
2025-11-18 19:48:58 +00:00
merge.h
Initial support for empty named constraints (#6245)
2025-10-22 18:26:32 +00:00
modifiers.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
modifiers.h
Refactor modifier formatting to remove string passing. (#4418)
2024-10-17 22:47:40 +00:00
name_component.cpp
Add Call param patterns to Function (#6586)
2026-01-13 19:30:15 +00:00
name_component.h
Add Call param patterns to Function (#6586)
2026-01-13 19:30:15 +00:00
name_lookup.cpp
Look through extend require in an interface or named constraint in name lookup (#6630)
2026-01-20 22:26:10 +00:00
name_lookup.h
Member access into a facet is not a "lookup in type of base" (#6631)
2026-01-20 18:43:16 +00:00
name_ref.cpp
Fix lowering of thunks in generic impls (#5631)
2025-06-10 20:54:58 +00:00
name_ref.h
Fix lowering of thunks in generic impls (#5631)
2025-06-10 20:54:58 +00:00
name_scope.cpp
Diagnose explicit Self in extend in the parse node handler (Refactor Impl construction 1/7) (#6465)
2025-12-09 20:38:50 +00:00
name_scope.h
Diagnose explicit Self in extend in the parse node handler (Refactor Impl construction 1/7) (#6465)
2025-12-09 20:38:50 +00:00
node_id_traversal.cpp
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
node_id_traversal.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
node_stack.cpp
Use lines instead of statements for readability-function-size clang-tidy (#6594)
2026-01-14 19:32:03 +00:00
node_stack.h
[parse] Implement initial parsing support for Lambda expressions (#6583)
2026-01-14 16:58:15 +00:00
operator.cpp
Model ref tags as insts instead of annotations (#6541)
2026-01-05 22:24:47 +00:00
operator.h
Add well-known identifier caching (#6486)
2025-12-11 21:41:47 +00:00
param_and_arg_refs_stack.h
Consolidate post-check logic (#5003)
2025-02-25 02:07:43 +00:00
pattern_match.cpp
Add Call param patterns to Function (#6586)
2026-01-13 19:30:15 +00:00
pattern_match.h
Add Call param patterns to Function (#6586)
2026-01-13 19:30:15 +00:00
pattern.cpp
Replace GetCurrentReturnSlot with GetReturnedVarParam (#6571)
2026-01-10 01:56:32 +00:00
pattern.h
Import C++ ref parameters as ref parameters (#6360)
2025-11-13 17:04:58 +00:00
pending_block.h
Don't treat dependent types as having a copy value representation. (#6055)
2025-09-15 23:59:00 +00:00
pointer_dereference.cpp
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
pointer_dereference.h
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
region_stack.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
require_impls.cpp
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
require_impls.h
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
return.cpp
Remove some uses of ReturnTypeInfo (#6577)
2026-01-13 17:23:27 +00:00
return.h
Replace GetCurrentReturnSlot with GetReturnedVarParam (#6571)
2026-01-10 01:56:32 +00:00
scope_index.h
Use inline constexpr where appropriate. (#6374)
2025-11-14 13:50:56 +00:00
scope_stack.cpp
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
scope_stack.h
Drop fn destroy support (#6136)
2025-09-25 21:56:48 +00:00
subst.cpp
Change Destroy to use a CustomWitness instead of a blanket impl (#6512)
2025-12-19 18:36:06 +00:00
subst.h
Finish renaming BindName and related insts. (#6281)
2025-10-28 17:17:38 +00:00
thunk.cpp
Add Call param patterns to Function (#6586)
2026-01-13 19:30:15 +00:00
thunk.h
Implement support for copying C++ classes. (#6434)
2025-12-02 02:52:23 +00:00
type_completion.cpp
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
type_completion.h
Make identifying a facet type an operation on a (self+facet type) pair (#6592)
2026-01-14 17:34:56 +00:00
type_structure.cpp
Return SymbolicBindingType separately in TypeIterator (#6193)
2025-10-10 12:37:37 +00:00
type_structure.h
Prevent accidental copies of TypeStructure (#6519)
2025-12-18 17:26:28 +00:00
type.cpp
Add interop support for naming and "calling" C++ templates. (#6474)
2025-12-15 17:45:01 +00:00
type.h
Add interop support for naming and "calling" C++ templates. (#6474)
2025-12-15 17:45:01 +00:00