carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 20:20:10 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Allow NRVO in InventClangArgs. (#6624)

Browse Source 
Attempt to avoid an unnecessary `SmallVector` copy.
This commit is contained in:
Richard Smith
2026-01-17 04:27:59 +00:00
committed by GitHub
parent 773b7136ef
commit cc204ead96
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/cpp/type_mapping.cpp
+6 -4
View File
@@ -385,14 +385,16 @@ auto InventClangArg(Context& context, SemIR::InstId arg_id) -> clang::Expr* {
auto InventClangArgs(Context& context, llvm::ArrayRef<SemIR::InstId> arg_ids)
-> std::optional<llvm::SmallVector<clang::Expr*>> {
llvm::SmallVector<clang::Expr*> arg_exprs;
arg_exprs.reserve(arg_ids.size());
std::optional<llvm::SmallVector<clang::Expr*>> arg_exprs;
arg_exprs.emplace();
arg_exprs->reserve(arg_ids.size());
for (SemIR::InstId arg_id : arg_ids) {
auto* arg_expr = InventClangArg(context, arg_id);
if (!arg_expr) {
return std::nullopt;
arg_exprs = std::nullopt;
return arg_exprs;
}
arg_exprs.push_back(arg_expr);
arg_exprs->push_back(arg_expr);
}
return arg_exprs;
}