Boaz Brickner a0ef7e7112 C++ Interop: Add test coverage for access control of static/instance data/function members (#6199) ...

This demonstrates two issues:
1. It seems like we wrongly treat private static data members the same
way we treat protected and allow access to them from within derived
classes member functions.
2. Calling instance member functions of a base C++ class using a derived
class as self (no implicit upcast) is not yet supported. This isn't
related to access control, but prevents us from testing some access
control use cases.

Part of #5859.

2025-10-14 17:56:24 +00:00

..

cpp

C++ Interop: Support reference types in fields and globals (#6187)

2025-10-10 23:15:31 +00:00

fuzzer_corpus

Change array syntax from [T; N] to array(T, N) (#4981)

2025-02-20 22:42:47 +00:00

testdata

C++ Interop: Add test coverage for access control of static/instance data/function members (#6199)

2025-10-14 17:56:24 +00:00

action.cpp

Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)

2025-04-15 22:40:29 +00:00

action.h

Even more usage of TypeInstId (#5296)

2025-04-11 21:47:43 +00:00

BUILD

Switch class to use a blanket impl for Destroy (#6125)

2025-09-29 16:05:06 +00:00

call.cpp

Add PerformCallToCppFunction() which calls simplified version of PerformCppOverloadResolution() before calling PerformCallToFunction() (#6122)

2025-09-29 14:26:23 +00:00

call.h

Add PerformCallToCppFunction() which calls simplified version of PerformCppOverloadResolution() before calling PerformCallToFunction() (#6122)

2025-09-29 14:26:23 +00:00

check_fuzzer.cpp

Switch Driver back to parameters for construction (#4849)

2025-01-27 23:48:44 +00:00

check_unit.cpp

Make the GetCanonicalFacetOrTypeValue operation more crisp (#6157)

2025-10-03 15:21:07 +00:00

check_unit.h

Switch class to use a blanket impl for Destroy (#6125)

2025-09-29 16:05:06 +00:00

check.cpp

Switch class to use a blanket impl for Destroy (#6125)

2025-09-29 16:05:06 +00:00

check.h

Switch class to use a blanket impl for Destroy (#6125)

2025-09-29 16:05:06 +00:00

class.cpp

Mark Check::Context::insts() as const and use it in more use cases (#6093)

2025-09-18 13:04:18 +00:00

class.h

Vtable support for generics (#5793)

2025-07-11 22:29:10 +00:00

context.cpp

Check for use of InstIds from the wrong SemIR::File (#5997)

2025-10-02 23:07:36 +00:00

context.h

Make the GetCanonicalFacetOrTypeValue operation more crisp (#6157)

2025-10-03 15:21:07 +00:00

control_flow.cpp

Tag destruction as desugaring (#5790)

2025-07-10 21:21:19 +00:00

control_flow.h

Handle destruction for return statements (#5785)

2025-07-10 16:32:39 +00:00

convert.cpp

Make FacetAccessType evaluate to SymbolicBindingType for type-of a BindSymbolicName (#6115)

2025-10-06 18:56:43 +00:00

convert.h

Add support for unsafe as operator to the toolchain. (#5993)

2025-08-28 23:00:53 +00:00

decl_introducer_state.h

Allow extend final impl as for impl declarations (#5345)

2025-04-23 15:20:18 +00:00

decl_name_stack.cpp

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

decl_name_stack.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

deduce.cpp

Avoid adding extraneous local instructions while importing witness table entries (#6180)

2025-10-09 16:07:30 +00:00

deduce.h

Fearlessly hold references into ValueStore again (#5589)

2025-06-03 18:07:23 +00:00

deferred_definition_worklist.cpp

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

deferred_definition_worklist.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

diagnostic_emitter.cpp

Switch to representing FloatLiteralType as a RealId. (#5944)

2025-08-12 22:08:07 +00:00

diagnostic_emitter.h

Expand use of CheckIRId stores (#5820)

2025-07-21 20:02:27 +00:00

diagnostic_helpers.h

Use explicit(false) for implicit construction (#6039)

2025-09-10 13:47:59 +00:00

dump.cpp

Move LocId dumping to semir/ (#5656)

2025-06-12 20:37:27 +00:00

eval_inst.cpp

Make FacetAccessType evaluate to SymbolicBindingType for type-of a BindSymbolicName (#6115)

2025-10-06 18:56:43 +00:00

eval_inst.h

Support for lowering references to imported vars. (#5513)

2025-05-29 19:48:16 +00:00

eval.cpp

Handle a specific providing ImplWitnessAccess for a symbolic binding used as a type (#6201)

2025-10-14 15:29:46 +00:00

eval.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

facet_type.cpp

Add builtin functions for destroy, with special requirements in facet types (#6035)

2025-09-15 17:03:43 +00:00

facet_type.h

Add the .Self name for the type expression of a compile time binding (#5937)

2025-08-12 16:27:07 +00:00

full_pattern_stack.h

Clean up handling of Call params (#5061)

2025-03-04 21:01:59 +00:00

function.cpp

Make use of new ArrayRef::consume_* functions. (#5975)

2025-08-21 21:41:53 +00:00

function.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

generic_region_stack.cpp

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

generic_region_stack.h

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

generic.cpp

Some more edits to EnumBase and EnumMaskBase (#6054)

2025-09-12 22:59:37 +00:00

generic.h

Add an EnumMaskBase type (#6053)

2025-09-12 18:04:10 +00:00

global_init.cpp

[Refactor] Move call_params_id from EntityBase to FunctionFields. (#5146)

2025-03-18 23:49:24 +00:00

global_init.h

Split global init out from InstBlockStack. (#4101)

2024-07-03 17:49:47 +00:00

handle_alias.cpp

Stop pushing a fake generic for the duration of check. (#5326)

2025-04-17 21:58:37 +00:00

handle_array.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_binding_pattern.cpp

Give the BindSymbolicName for .Self in a binding pattern a FacetType type (#6036)

2025-09-10 17:57:08 +00:00

handle_call_expr.cpp

Include the call arguments in the location of a call. (#4602)

2024-12-02 18:51:44 +00:00

handle_choice.cpp

Fearlessly hold references into ValueStore again (#5589)

2025-06-03 18:07:23 +00:00

handle_class.cpp

Switch class to use a blanket impl for Destroy (#6125)

2025-09-29 16:05:06 +00:00

handle_codeblock.cpp

Detect control flow in entities nested inside functions (#5336)

2025-04-23 19:03:53 +00:00

handle_export.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_expr_statement.cpp

Convert discarded calls in thunks. (#5452)

2025-05-09 16:35:28 +00:00

handle_file.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_function.cpp

Drop fn destroy support (#6136)

2025-09-25 21:56:48 +00:00

handle_if_expr.cpp

Detect control flow in entities nested inside functions (#5336)

2025-04-23 19:03:53 +00:00

handle_if_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_impl.cpp

Factor out an impl declaration helper function (#5851)

2025-07-25 18:34:07 +00:00

handle_import_and_package.cpp

Support import Cpp inline "some code";. (#5904)

2025-08-05 23:03:32 +00:00

handle_index.cpp

Change IndexWith to use a standard binary operator setup (#6127)

2025-09-29 18:17:48 +00:00

handle_interface.cpp

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

handle_let_and_var.cpp

Decouple associated constants from let (#5973)

2025-09-02 23:15:26 +00:00

handle_literal.cpp

Add support for char keyword per #5903. (#6078)

2025-09-16 20:45:01 +00:00

handle_loop_statement.cpp

Check and lowering support for for loops. (#5698)

2025-06-25 23:45:14 +00:00

handle_match.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_modifier.cpp

Allow extend final impl as for impl declarations (#5345)

2025-04-23 15:20:18 +00:00

handle_name.cpp

Drop fn destroy support (#6136)

2025-09-25 21:56:48 +00:00

handle_named_constraint.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_namespace.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_noop.cpp

Abort checking when encountering an invalid parse node (#4700)

2024-12-18 00:19:12 +00:00

handle_operator.cpp

Add support for unsafe as operator to the toolchain. (#5993)

2025-08-28 23:00:53 +00:00

handle_paren_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_pattern_list.cpp

Decouple associated constants from let (#5973)

2025-09-02 23:15:26 +00:00

handle_return_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_struct.cpp

Detect control flow in entities nested inside functions (#5336)

2025-04-23 19:03:53 +00:00

handle_tuple_literal.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

handle_where.cpp

Add the .Self name for the type expression of a compile time binding (#5937)

2025-08-12 16:27:07 +00:00

handle.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

impl_lookup.cpp

Move the FacetAccessType special case out of name lookup, and generalize it (#6163)

2025-10-06 19:06:26 +00:00

impl_lookup.h

Make the GetCanonicalFacetOrTypeValue operation more crisp (#6157)

2025-10-03 15:21:07 +00:00

impl_validation.cpp

Switch handling of errors in impls to not build a type structure (#5881)

2025-07-30 20:24:38 +00:00

impl_validation.h

Add diagnostics for invalid impl declarations (#5420)

2025-05-22 18:58:47 +00:00

impl.cpp

Avoid adding extraneous local instructions while importing witness table entries (#6180)

2025-10-09 16:07:30 +00:00

impl.h

Factor out an impl declaration helper function (#5851)

2025-07-25 18:34:07 +00:00

import_ref.cpp

Avoid adding extraneous local instructions while importing witness table entries (#6180)

2025-10-09 16:07:30 +00:00

import_ref.h

When performing an impl lookup, only import impls for related interfaces. (#6040)

2025-09-10 21:40:27 +00:00

import.cpp

Initial support for interop with class/struct/union fields. (#5849)

2025-07-25 21:09:24 +00:00

import.h

Initial support for interop with class/struct/union fields. (#5849)

2025-07-25 21:09:24 +00:00

inst_block_stack.cpp

Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)

2025-03-21 23:09:37 +00:00

inst_block_stack.h

Split SemIR's formatter class into a more typical h+cpp (#5372)

2025-04-29 18:00:07 +00:00

inst.cpp

Add an EnumMaskBase type (#6053)

2025-09-12 18:04:10 +00:00

inst.h

Fix a small implicit/desugared reference (#5791)

2025-07-10 18:27:28 +00:00

interface.cpp

Handle some more errors in interfaces without crashing. (#6155)

2025-10-03 14:31:45 +00:00

interface.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

keyword_modifier_set.cpp

Some more edits to EnumBase and EnumMaskBase (#6054)

2025-09-12 22:59:37 +00:00

keyword_modifier_set.h

Replace impl fn with override fn (#6008)

2025-09-12 23:27:02 +00:00

lexical_lookup.h

Set an explicit size for lexical lookup's vector (#5786)

2025-07-09 22:42:27 +00:00

literal.cpp

C++ Interop: Add support for char (#5988)

2025-08-29 01:11:24 +00:00

literal.h

C++ Interop: Add support for char (#5988)

2025-08-29 01:11:24 +00:00

member_access.cpp

Allow instance binding on tuple-valued expressions. (#6203)

2025-10-11 04:54:13 +00:00

member_access.h

Implement support for mixed-access overload sets. (#6137)

2025-09-26 23:18:16 +00:00

merge.cpp

Support importing var parameters (#5400)

2025-05-19 22:50:16 +00:00

merge.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

modifiers.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

modifiers.h

Refactor modifier formatting to remove string passing. (#4418)

2024-10-17 22:47:40 +00:00

name_component.cpp

Fix parse support for 'fn F[];' (#5135)

2025-03-18 00:31:17 +00:00

name_component.h

Id::Invalid -> Id::None (#4834)

2025-01-22 23:15:00 +00:00

name_lookup.cpp

Make FacetAccessType evaluate to SymbolicBindingType for type-of a BindSymbolicName (#6115)

2025-10-06 18:56:43 +00:00

name_lookup.h

Implement support for mixed-access overload sets. (#6137)

2025-09-26 23:18:16 +00:00

name_ref.cpp

Fix lowering of thunks in generic impls (#5631)

2025-06-10 20:54:58 +00:00

name_ref.h

Fix lowering of thunks in generic impls (#5631)

2025-06-10 20:54:58 +00:00

node_id_traversal.cpp

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

node_id_traversal.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

node_stack.cpp

Avoid redundantly specifying Id::Kind. (#4911)

2025-02-07 22:35:18 +00:00

node_stack.h

Drop fn destroy support (#6136)

2025-09-25 21:56:48 +00:00

operator.cpp

Change IndexWith to use a standard binary operator setup (#6127)

2025-09-29 18:17:48 +00:00

operator.h

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

param_and_arg_refs_stack.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

pattern_match.cpp

Fix double-destruction of temporaries. (#6010)

2025-09-04 19:19:59 +00:00

pattern_match.h

Invalid comment cleanup (#4836)

2025-01-23 02:21:48 +00:00

pattern.cpp

Generate Destroy impls for classes (#5873)

2025-08-04 19:39:22 +00:00

pattern.h

Generate Destroy impls for classes (#5873)

2025-08-04 19:39:22 +00:00

pending_block.h

Don't treat dependent types as having a copy value representation. (#6055)

2025-09-15 23:59:00 +00:00

pointer_dereference.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

pointer_dereference.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

region_stack.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

return.cpp

Remove special case for returning value expressions by copy (#6052)

2025-09-12 00:13:33 +00:00

return.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

scope_index.h

Move None to IdBase (#5030)

2025-03-01 08:00:17 +00:00

scope_stack.cpp

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

scope_stack.h

Drop fn destroy support (#6136)

2025-09-25 21:56:48 +00:00

subst.cpp

Make FacetAccessType evaluate to SymbolicBindingType for type-of a BindSymbolicName (#6115)

2025-10-06 18:56:43 +00:00

subst.h

Make FacetAccessType evaluate to SymbolicBindingType for type-of a BindSymbolicName (#6115)

2025-10-06 18:56:43 +00:00

thunk.cpp

CalleeFunction -> Callee name adjustments (#6117)

2025-09-23 17:51:31 +00:00

thunk.h

When making a direct call to a thunk, inline the call in SemIR. (#5642)

2025-06-11 21:34:01 +00:00

type_completion.cpp

Move C++ interop related check code files to a cpp dir (#6065)

2025-09-17 09:31:36 +00:00

type_completion.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

type_structure.cpp

Return SymbolicBindingType separately in TypeIterator (#6193)

2025-10-10 12:37:37 +00:00

type_structure.h

Update Documentation to use new expression terminology (#5890)

2025-09-30 20:15:55 +00:00

type.cpp

Support member access into the type of (facet as type) expressions as being into the facet's type (#6190)

2025-10-09 22:06:02 +00:00

type.h

Support member access into the type of (facet as type) expressions as being into the facet's type (#6190)

2025-10-09 22:06:02 +00:00