mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-25 19:00:09 +01:00
Jon Meow
fd89bcb4aa
Sorry about the big change, this is hard to split. ParenContents is used by both, templated, and expects the same pointer type. While I could duplicate ParenContents with some ExpressionParenContents or PatternParenContents, that seems a little kludgy versus a single large change handling both. The worst of it is that Expression is already pretty sweeping, Pattern is really just incrementally adding. That said, I believe this includes a couple fixes I found with incorrect use of dyn_cast in typecheck.cpp (checked nullptr at the wrong step in 2 code locations). There's also a missing `*` in member.cpp this caught. I adjust passing of expressions for Return due to nullness (I felt adding another constructor was the best solution). I add a `.Release()` to BisonWrap due to things like `$3.first` needing some way to work through BIsonWrap. I felt this was better than `operator->`, but feel free to comment if you prefer the other path (`.Release()` conveniently lets me do pair unwrapping, so it felt a better solution). I do add a TODO to think about better Ptr-to-Ptr cast<> support too, though, as that doesn't work cleanly with LLVM's infra. But so far it seems to only come up in one spot, so I'm not prioritizing it.
155 lines
5.5 KiB
C++
155 lines
5.5 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "executable_semantics/ast/expression.h"
|
|
|
|
#include <string>
|
|
|
|
#include "executable_semantics/ast/paren_contents.h"
|
|
#include "executable_semantics/common/arena.h"
|
|
#include "gmock/gmock.h"
|
|
#include "gtest/gtest.h"
|
|
#include "llvm/Support/Casting.h"
|
|
|
|
namespace Carbon {
|
|
namespace {
|
|
|
|
using llvm::cast;
|
|
using testing::ElementsAre;
|
|
using testing::IsEmpty;
|
|
|
|
// Matches a FieldInitializer named `name` whose `expression` is an
|
|
// `IntLiteral`
|
|
MATCHER_P(IntFieldNamed, name, "") {
|
|
return arg.name == std::string(name) &&
|
|
arg.expression->Tag() == Expression::Kind::IntLiteral;
|
|
}
|
|
|
|
static auto FakeSourceLoc(int line_num) -> SourceLocation {
|
|
return SourceLocation("<test>", line_num);
|
|
}
|
|
|
|
TEST(ExpressionTest, EmptyAsExpression) {
|
|
ParenContents<Expression> contents = {.elements = {},
|
|
.has_trailing_comma = false};
|
|
Ptr<const Expression> expression =
|
|
ExpressionFromParenContents(FakeSourceLoc(1), contents);
|
|
EXPECT_EQ(expression->SourceLoc(), FakeSourceLoc(1));
|
|
ASSERT_EQ(expression->Tag(), Expression::Kind::TupleLiteral);
|
|
EXPECT_THAT(cast<TupleLiteral>(*expression).Fields(), IsEmpty());
|
|
}
|
|
|
|
TEST(ExpressionTest, EmptyAsTuple) {
|
|
ParenContents<Expression> contents = {.elements = {},
|
|
.has_trailing_comma = false};
|
|
Ptr<const Expression> tuple =
|
|
TupleExpressionFromParenContents(FakeSourceLoc(1), contents);
|
|
EXPECT_EQ(tuple->SourceLoc(), FakeSourceLoc(1));
|
|
ASSERT_EQ(tuple->Tag(), Expression::Kind::TupleLiteral);
|
|
EXPECT_THAT(cast<TupleLiteral>(*tuple).Fields(), IsEmpty());
|
|
}
|
|
|
|
TEST(ExpressionTest, UnaryNoCommaAsExpression) {
|
|
// Equivalent to a code fragment like
|
|
// ```
|
|
// (
|
|
// 42
|
|
// )
|
|
// ```
|
|
ParenContents<Expression> contents = {
|
|
.elements = {{.name = std::nullopt,
|
|
.term =
|
|
global_arena->New<IntLiteral>(FakeSourceLoc(2), 42)}},
|
|
.has_trailing_comma = false};
|
|
|
|
Ptr<const Expression> expression =
|
|
ExpressionFromParenContents(FakeSourceLoc(1), contents);
|
|
EXPECT_EQ(expression->SourceLoc(), FakeSourceLoc(2));
|
|
ASSERT_EQ(expression->Tag(), Expression::Kind::IntLiteral);
|
|
}
|
|
|
|
TEST(ExpressionTest, UnaryNoCommaAsTuple) {
|
|
ParenContents<Expression> contents = {
|
|
.elements = {{.name = std::nullopt,
|
|
.term =
|
|
global_arena->New<IntLiteral>(FakeSourceLoc(2), 42)}},
|
|
.has_trailing_comma = false};
|
|
|
|
Ptr<const Expression> tuple =
|
|
TupleExpressionFromParenContents(FakeSourceLoc(1), contents);
|
|
EXPECT_EQ(tuple->SourceLoc(), FakeSourceLoc(1));
|
|
ASSERT_EQ(tuple->Tag(), Expression::Kind::TupleLiteral);
|
|
EXPECT_THAT(cast<TupleLiteral>(*tuple).Fields(),
|
|
ElementsAre(IntFieldNamed("0")));
|
|
}
|
|
|
|
TEST(ExpressionTest, UnaryWithCommaAsExpression) {
|
|
ParenContents<Expression> contents = {
|
|
.elements = {{.name = std::nullopt,
|
|
.term =
|
|
global_arena->New<IntLiteral>(FakeSourceLoc(2), 42)}},
|
|
.has_trailing_comma = true};
|
|
|
|
Ptr<const Expression> expression =
|
|
ExpressionFromParenContents(FakeSourceLoc(1), contents);
|
|
EXPECT_EQ(expression->SourceLoc(), FakeSourceLoc(1));
|
|
ASSERT_EQ(expression->Tag(), Expression::Kind::TupleLiteral);
|
|
EXPECT_THAT(cast<TupleLiteral>(*expression).Fields(),
|
|
ElementsAre(IntFieldNamed("0")));
|
|
}
|
|
|
|
TEST(ExpressionTest, UnaryWithCommaAsTuple) {
|
|
ParenContents<Expression> contents = {
|
|
.elements = {{.name = std::nullopt,
|
|
.term =
|
|
global_arena->New<IntLiteral>(FakeSourceLoc(2), 42)}},
|
|
.has_trailing_comma = true};
|
|
|
|
Ptr<const Expression> tuple =
|
|
TupleExpressionFromParenContents(FakeSourceLoc(1), contents);
|
|
EXPECT_EQ(tuple->SourceLoc(), FakeSourceLoc(1));
|
|
ASSERT_EQ(tuple->Tag(), Expression::Kind::TupleLiteral);
|
|
EXPECT_THAT(cast<TupleLiteral>(*tuple).Fields(),
|
|
ElementsAre(IntFieldNamed("0")));
|
|
}
|
|
|
|
TEST(ExpressionTest, BinaryAsExpression) {
|
|
ParenContents<Expression> contents = {
|
|
.elements = {{.name = std::nullopt,
|
|
.term =
|
|
global_arena->New<IntLiteral>(FakeSourceLoc(2), 42)},
|
|
{.name = std::nullopt,
|
|
.term =
|
|
global_arena->New<IntLiteral>(FakeSourceLoc(3), 42)}},
|
|
.has_trailing_comma = true};
|
|
|
|
Ptr<const Expression> expression =
|
|
ExpressionFromParenContents(FakeSourceLoc(1), contents);
|
|
EXPECT_EQ(expression->SourceLoc(), FakeSourceLoc(1));
|
|
ASSERT_EQ(expression->Tag(), Expression::Kind::TupleLiteral);
|
|
EXPECT_THAT(cast<TupleLiteral>(*expression).Fields(),
|
|
ElementsAre(IntFieldNamed("0"), IntFieldNamed("1")));
|
|
}
|
|
|
|
TEST(ExpressionTest, BinaryAsTuple) {
|
|
ParenContents<Expression> contents = {
|
|
.elements = {{.name = std::nullopt,
|
|
.term =
|
|
global_arena->New<IntLiteral>(FakeSourceLoc(2), 42)},
|
|
{.name = std::nullopt,
|
|
.term =
|
|
global_arena->New<IntLiteral>(FakeSourceLoc(3), 42)}},
|
|
.has_trailing_comma = true};
|
|
|
|
Ptr<const Expression> tuple =
|
|
TupleExpressionFromParenContents(FakeSourceLoc(1), contents);
|
|
EXPECT_EQ(tuple->SourceLoc(), FakeSourceLoc(1));
|
|
ASSERT_EQ(tuple->Tag(), Expression::Kind::TupleLiteral);
|
|
EXPECT_THAT(cast<TupleLiteral>(*tuple).Fields(),
|
|
ElementsAre(IntFieldNamed("0"), IntFieldNamed("1")));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon
|