mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Avoid crashing on the fact that block scopes have no related InstId. So we can't push the InstId of the current scope in the ImplIntroducer node, as it can be None. Instead we have to find the parent InstId when we're building the ImplDecl, because the ImplDecl has a node at the top of the scope stack for the DeclNameStack. Impls are allowed in sequential (non-declarative) scopes (functions, blocks), but [redeclarations are not allowed](https://github.com/carbon-language/carbon-lang/blob/db24042fe56d22275aa801696e2f8f5c4171e35b/proposals/p3763.md?plain=1#L279). We now diagnose these redecls as invalid.
386 lines
15 KiB
C++
386 lines
15 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/scope_stack.h"
|
|
|
|
#include <utility>
|
|
|
|
#include "common/check.h"
|
|
#include "common/find.h"
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/check/unused.h"
|
|
#include "toolchain/sem_ir/ids.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
ScopeStack::ScopeStack(Context& context)
|
|
: context_(&context),
|
|
lexical_lookup_(context.sem_ir().identifiers()),
|
|
full_pattern_stack_(&lexical_lookup_) {}
|
|
|
|
auto ScopeStack::sem_ir() const -> const SemIR::File& {
|
|
return context_->sem_ir();
|
|
}
|
|
|
|
auto ScopeStack::VerifyOnFinish() const -> void {
|
|
CARBON_CHECK(return_scope_stack_.empty(), "{0}", return_scope_stack_.size());
|
|
CARBON_CHECK(break_continue_stack_.empty(), "{0}",
|
|
break_continue_stack_.size());
|
|
CARBON_CHECK(scope_stack_.empty(), "{0}", scope_stack_.size());
|
|
CARBON_CHECK(destroy_id_stack_.empty(), "{0}",
|
|
destroy_id_stack_.all_values_size());
|
|
CARBON_CHECK(non_lexical_scope_stack_.empty(), "{0}",
|
|
non_lexical_scope_stack_.size());
|
|
CARBON_CHECK(compile_time_binding_stack_.empty(), "{0}",
|
|
compile_time_binding_stack_.all_values_size());
|
|
full_pattern_stack_.VerifyOnFinish();
|
|
}
|
|
|
|
auto ScopeStack::VerifyNextCompileTimeBindIndex(llvm::StringLiteral label,
|
|
const ScopeStackEntry& scope)
|
|
-> void {
|
|
CARBON_CHECK(
|
|
static_cast<int32_t>(compile_time_binding_stack_.all_values_size()) ==
|
|
scope.next_compile_time_bind_index.index,
|
|
"Wrong number of entries in compile-time binding stack after {0}: have "
|
|
"{1}, expected {2}",
|
|
label, compile_time_binding_stack_.all_values_size(),
|
|
scope.next_compile_time_bind_index.index);
|
|
}
|
|
|
|
auto ScopeStack::Push(SemIR::InstId scope_inst_id, SemIR::NameScopeId scope_id,
|
|
SemIR::SpecificId specific_id,
|
|
bool lexical_lookup_has_load_error) -> void {
|
|
// If this scope doesn't have a specific of its own, it lives in the enclosing
|
|
// scope's specific, if any.
|
|
auto enclosing_specific_id = specific_id;
|
|
if (!specific_id.has_value() && !scope_stack_.empty()) {
|
|
enclosing_specific_id = PeekSpecificId();
|
|
}
|
|
|
|
compile_time_binding_stack_.PushArray();
|
|
scope_stack_.push_back(
|
|
{.index = next_scope_index_,
|
|
.scope_inst_id = scope_inst_id,
|
|
.scope_id = scope_id,
|
|
.specific_id = enclosing_specific_id,
|
|
.next_compile_time_bind_index = SemIR::CompileTimeBindIndex(
|
|
compile_time_binding_stack_.all_values_size()),
|
|
.lexical_lookup_has_load_error =
|
|
LexicalLookupHasLoadError() || lexical_lookup_has_load_error});
|
|
if (scope_stack_.back().is_lexical_scope()) {
|
|
// For lexical lookups, unqualified lookup doesn't know how to find the
|
|
// associated specific, so if we start adding lexical scopes associated with
|
|
// specifics, we'll need to somehow track them in lookup.
|
|
CARBON_CHECK(!specific_id.has_value(),
|
|
"Lexical scope should not have an associated specific.");
|
|
} else {
|
|
non_lexical_scope_stack_.push_back({.scope_index = next_scope_index_,
|
|
.name_scope_id = scope_id,
|
|
.specific_id = enclosing_specific_id});
|
|
}
|
|
|
|
// TODO: Handle this case more gracefully.
|
|
CARBON_CHECK(next_scope_index_.index != std::numeric_limits<int32_t>::max(),
|
|
"Ran out of scopes");
|
|
++next_scope_index_.index;
|
|
|
|
VerifyNextCompileTimeBindIndex("Push", scope_stack_.back());
|
|
}
|
|
|
|
auto ScopeStack::PushForDeclName() -> void {
|
|
Push(SemIR::InstId::None, SemIR::NameScopeId::None, SemIR::SpecificId::None,
|
|
/*lexical_lookup_has_load_error=*/false);
|
|
MarkNestingIfInReturnScope();
|
|
}
|
|
|
|
auto ScopeStack::PushForEntity(SemIR::InstId scope_inst_id,
|
|
SemIR::NameScopeId scope_id,
|
|
SemIR::SpecificId specific_id,
|
|
bool lexical_lookup_has_load_error) -> void {
|
|
CARBON_CHECK(scope_inst_id.has_value());
|
|
CARBON_DCHECK(!sem_ir().insts().Is<SemIR::FunctionDecl>(scope_inst_id));
|
|
Push(scope_inst_id, scope_id, specific_id, lexical_lookup_has_load_error);
|
|
MarkNestingIfInReturnScope();
|
|
}
|
|
|
|
auto ScopeStack::PushForSameRegion() -> void {
|
|
Push(SemIR::InstId::None, SemIR::NameScopeId::None, SemIR::SpecificId::None,
|
|
/*lexical_lookup_has_load_error=*/false);
|
|
}
|
|
|
|
auto ScopeStack::PushForFunctionBody(SemIR::InstId scope_inst_id) -> void {
|
|
CARBON_DCHECK(sem_ir().insts().Is<SemIR::FunctionDecl>(scope_inst_id));
|
|
Push(scope_inst_id, SemIR::NameScopeId::None, SemIR::SpecificId::None,
|
|
/*lexical_lookup_has_load_error=*/false);
|
|
|
|
return_scope_stack_.push_back({.decl_id = scope_inst_id});
|
|
destroy_id_stack_.PushArray();
|
|
}
|
|
|
|
auto ScopeStack::Pop(bool check_unused) -> void {
|
|
auto scope = scope_stack_.pop_back_val();
|
|
|
|
// TODO: Multiple diagnostics on same line has non-deterministic order.
|
|
// Add second sort key in diagnostics sorting.
|
|
scope.names.ForEach([&, check_unused](SemIR::NameId name_id) {
|
|
auto& lexical_results = lexical_lookup_.Get(name_id);
|
|
CARBON_CHECK(lexical_results.back().scope_index == scope.index,
|
|
"Inconsistent scope index for name {0}", name_id);
|
|
if (check_unused) {
|
|
CheckUnusedBinding(*context_, name_id, lexical_results.back());
|
|
}
|
|
lexical_results.pop_back();
|
|
});
|
|
|
|
if (!scope.is_lexical_scope()) {
|
|
CARBON_CHECK(non_lexical_scope_stack_.back().scope_index == scope.index);
|
|
non_lexical_scope_stack_.pop_back();
|
|
}
|
|
|
|
if (!return_scope_stack_.empty()) {
|
|
if (scope.has_returned_var) {
|
|
CARBON_CHECK(return_scope_stack_.back().returned_var.has_value());
|
|
return_scope_stack_.back().returned_var = SemIR::InstId::None;
|
|
}
|
|
|
|
if (return_scope_stack_.back().decl_id == scope.scope_inst_id) {
|
|
// Leaving the function scope.
|
|
return_scope_stack_.pop_back();
|
|
destroy_id_stack_.PopArray();
|
|
} else if (return_scope_stack_.back().nested_scope_index == scope.index) {
|
|
// Returned to a function scope from a non-function nested entity scope.
|
|
return_scope_stack_.back().nested_scope_index = ScopeIndex::None;
|
|
}
|
|
} else {
|
|
CARBON_CHECK(!scope.has_returned_var);
|
|
}
|
|
|
|
VerifyNextCompileTimeBindIndex("Pop", scope);
|
|
compile_time_binding_stack_.PopArray();
|
|
}
|
|
|
|
auto ScopeStack::PopTo(ScopeIndex index, bool check_unused) -> void {
|
|
while (PeekIndex() > index) {
|
|
Pop(check_unused);
|
|
}
|
|
CARBON_CHECK(PeekIndex() == index,
|
|
"Scope index {0} does not enclose the current scope {1}", index,
|
|
PeekIndex());
|
|
}
|
|
|
|
auto ScopeStack::MarkUsed(SemIR::NameId name_id, SemIR::LocId loc_id,
|
|
bool is_reachable) -> void {
|
|
auto& lexical_results = lexical_lookup_.Get(name_id);
|
|
if (lexical_results.empty()) {
|
|
return;
|
|
}
|
|
auto& result = lexical_results.back();
|
|
if (result.use_loc_id.has_value()) {
|
|
return;
|
|
}
|
|
|
|
// Determine if we should set use_loc_id.
|
|
if (result.inst_id.has_value() &&
|
|
result.inst_id != SemIR::InstId::InitTombstone) {
|
|
if (auto binding =
|
|
context_->insts().TryGetAs<SemIR::AnyBinding>(result.inst_id)) {
|
|
const auto& entity_name =
|
|
context_->entity_names().Get(binding->entity_name_id);
|
|
if (entity_name.is_unused && !is_reachable) {
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
// For non-bindings (like namespaces), we just mark them as used.
|
|
// If the instruction is not valid (e.g. InitTombstone), we mark it as used
|
|
// to avoid spurious "unused" warnings, assuming the invalid state will be
|
|
// diagnosed elsewhere (e.g. used before init).
|
|
result.use_loc_id = loc_id;
|
|
}
|
|
|
|
auto ScopeStack::LookupInLexicalScopesWithin(SemIR::NameId name_id,
|
|
ScopeIndex scope_index,
|
|
SemIR::LocId use_loc_id,
|
|
bool is_reachable)
|
|
-> SemIR::InstId {
|
|
llvm::ArrayRef<LexicalLookup::Result> lexical_results =
|
|
lexical_lookup_.Get(name_id);
|
|
if (lexical_results.empty()) {
|
|
return SemIR::InstId::None;
|
|
}
|
|
|
|
auto result = lexical_results.back();
|
|
if (result.scope_index < scope_index) {
|
|
return SemIR::InstId::None;
|
|
}
|
|
|
|
if (use_loc_id.has_value()) {
|
|
MarkUsed(name_id, use_loc_id, is_reachable);
|
|
}
|
|
return result.inst_id;
|
|
}
|
|
|
|
auto ScopeStack::LookupInLexicalScopes(SemIR::NameId name_id,
|
|
SemIR::LocId use_loc_id,
|
|
bool is_reachable)
|
|
-> std::pair<SemIR::InstId, llvm::ArrayRef<NonLexicalScope>> {
|
|
// Find the results from lexical scopes. These will be combined with results
|
|
// from non-lexical scopes such as namespaces and classes.
|
|
llvm::ArrayRef<LexicalLookup::Result> lexical_results =
|
|
lexical_lookup_.Get(name_id);
|
|
|
|
// If we have no lexical results, check all non-lexical scopes.
|
|
if (lexical_results.empty()) {
|
|
return {LexicalLookupHasLoadError() ? SemIR::ErrorInst::InstId
|
|
: SemIR::InstId::None,
|
|
non_lexical_scope_stack_};
|
|
}
|
|
|
|
if (use_loc_id.has_value()) {
|
|
MarkUsed(name_id, use_loc_id, is_reachable);
|
|
}
|
|
// Find the first non-lexical scope that is within the scope of the lexical
|
|
// lookup result.
|
|
auto* first_non_lexical_scope = llvm::lower_bound(
|
|
non_lexical_scope_stack_, lexical_results.back().scope_index,
|
|
[](const NonLexicalScope& scope, ScopeIndex index) {
|
|
return scope.scope_index < index;
|
|
});
|
|
return {
|
|
lexical_results.back().inst_id,
|
|
llvm::ArrayRef(first_non_lexical_scope, non_lexical_scope_stack_.end())};
|
|
}
|
|
|
|
auto ScopeStack::LookupOrAddName(SemIR::NameId name_id, SemIR::InstId target_id,
|
|
ScopeIndex scope_index, bool is_decl_reachable)
|
|
-> SemIR::InstId {
|
|
// Find the corresponding scope depth.
|
|
//
|
|
// TODO: Consider passing in the depth rather than performing a scan for it.
|
|
// We only do this scan when declaring an entity such as a class within a
|
|
// function, so it should be relatively rare, but it's still not necesasry to
|
|
// recompute this.
|
|
int scope_depth = scope_stack_.size() - 1;
|
|
if (scope_index.has_value()) {
|
|
scope_depth =
|
|
llvm::lower_bound(scope_stack_, scope_index,
|
|
[](const ScopeStackEntry& entry, ScopeIndex index) {
|
|
return entry.index < index;
|
|
}) -
|
|
scope_stack_.begin();
|
|
CARBON_CHECK(scope_stack_[scope_depth].index == scope_index,
|
|
"Declaring name in scope that has already ended");
|
|
} else {
|
|
scope_index = scope_stack_[scope_depth].index;
|
|
}
|
|
|
|
// If this name has already been declared in this scope or an inner scope,
|
|
// return the existing result.
|
|
auto& lexical_results = lexical_lookup_.Get(name_id);
|
|
if (!lexical_results.empty() &&
|
|
lexical_results.back().scope_index >= scope_index) {
|
|
return lexical_results.back().inst_id;
|
|
}
|
|
|
|
// Add the name into the scope.
|
|
bool inserted = scope_stack_[scope_depth].names.Insert(name_id).is_inserted();
|
|
CARBON_CHECK(inserted, "Name in scope but not in lexical lookups");
|
|
++scope_stack_[scope_depth].num_names;
|
|
|
|
// Add a corresponding lexical lookup result.
|
|
lexical_results.push_back({.inst_id = target_id,
|
|
.scope_index = scope_index,
|
|
.is_decl_reachable = is_decl_reachable,
|
|
.use_loc_id = SemIR::LocId::None});
|
|
return SemIR::InstId::None;
|
|
}
|
|
|
|
auto ScopeStack::SetReturnedVarOrGetExisting(SemIR::InstId inst_id,
|
|
SemIR::NameId name_id)
|
|
-> SemIR::InstId {
|
|
CARBON_CHECK(!return_scope_stack_.empty(), "`returned var` in no function");
|
|
auto& return_scope = return_scope_stack_.back();
|
|
if (return_scope.returned_var.has_value()) {
|
|
return return_scope.returned_var;
|
|
}
|
|
|
|
return_scope.returned_var = inst_id;
|
|
CARBON_CHECK(!scope_stack_.back().has_returned_var,
|
|
"Scope has returned var but none is set");
|
|
if (inst_id.has_value()) {
|
|
scope_stack_.back().has_returned_var = true;
|
|
MarkUsed(name_id, SemIR::LocId(inst_id),
|
|
context_->inst_block_stack().is_current_block_reachable());
|
|
}
|
|
return SemIR::InstId::None;
|
|
}
|
|
|
|
auto ScopeStack::Suspend() -> SuspendedScope {
|
|
CARBON_CHECK(!scope_stack_.empty(), "No scope to suspend");
|
|
SuspendedScope result = {.entry = scope_stack_.pop_back_val(),
|
|
.suspended_items = {}};
|
|
if (!result.entry.is_lexical_scope()) {
|
|
non_lexical_scope_stack_.pop_back();
|
|
}
|
|
auto peek_compile_time_bindings = compile_time_binding_stack_.PeekArray();
|
|
result.suspended_items.reserve(result.entry.num_names +
|
|
peek_compile_time_bindings.size());
|
|
|
|
result.entry.names.ForEach([&](SemIR::NameId name_id) {
|
|
auto suspended = lexical_lookup_.Suspend(name_id);
|
|
CARBON_CHECK(suspended.index !=
|
|
SuspendedScope::ScopeItem::IndexForCompileTimeBinding);
|
|
result.suspended_items.push_back(
|
|
{.index = suspended.index,
|
|
.inst_id = suspended.inst_id,
|
|
.is_decl_reachable = suspended.is_decl_reachable,
|
|
.use_loc_id = suspended.use_loc_id});
|
|
});
|
|
CARBON_CHECK(static_cast<int>(result.suspended_items.size()) ==
|
|
result.entry.num_names);
|
|
|
|
// Move any compile-time bindings into the suspended scope.
|
|
for (auto inst_id : peek_compile_time_bindings) {
|
|
result.suspended_items.push_back(
|
|
{.index = SuspendedScope::ScopeItem::IndexForCompileTimeBinding,
|
|
.inst_id = inst_id,
|
|
.is_decl_reachable = true,
|
|
.use_loc_id = SemIR::LocId::None});
|
|
}
|
|
compile_time_binding_stack_.PopArray();
|
|
|
|
// This would be easy to support if we had a need, but currently we do not.
|
|
CARBON_CHECK(!result.entry.has_returned_var,
|
|
"Should not suspend a scope with a returned var.");
|
|
return result;
|
|
}
|
|
|
|
auto ScopeStack::Restore(SuspendedScope&& scope) -> void {
|
|
compile_time_binding_stack_.PushArray();
|
|
for (auto item : scope.suspended_items) {
|
|
if (item.index == SuspendedScope::ScopeItem::IndexForCompileTimeBinding) {
|
|
compile_time_binding_stack_.AppendToTop(item.inst_id);
|
|
} else {
|
|
lexical_lookup_.Restore({.index = item.index,
|
|
.inst_id = item.inst_id,
|
|
.is_decl_reachable = item.is_decl_reachable,
|
|
.use_loc_id = item.use_loc_id},
|
|
scope.entry.index);
|
|
}
|
|
}
|
|
|
|
VerifyNextCompileTimeBindIndex("Restore", scope.entry);
|
|
|
|
if (!scope.entry.is_lexical_scope()) {
|
|
non_lexical_scope_stack_.push_back(
|
|
{.scope_index = scope.entry.index,
|
|
.name_scope_id = scope.entry.scope_id,
|
|
.specific_id = scope.entry.specific_id});
|
|
}
|
|
scope_stack_.push_back(std::move(scope.entry));
|
|
}
|
|
|
|
} // namespace Carbon::Check
|