mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 13:40:11 +01:00
Implement the toolchain side of proposal #7254, removing the `:!` binding syntax for generic and template parameters in favor of the keywords `generic`, `template`, and `runtime` plus contextual defaults for phase. For valid programs this is semantics-preserving: each binding resolves to the same phase, and produces the same SemIR, as it did under `:!`/`:`. The parser derives a binding's phase from its syntactic context plus any explicit phase keyword; new diagnostics and error recovery for misused keywords are described below. Implementation details for each component: - Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual parse-node budget onto `:`, and add the `generic` and `runtime` keywords. - Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or `CompileTimeEntityParam`) from declaration introducers down through parameter lists to each binding pattern, using a one-token lookahead to distinguish a name-qualifier parameter list from a declaration's own final list. Parameters of a compile-time entity (`class`, `interface`, `constraint`, `choice`, `alias`, `export`, `namespace`) and deduced `[]` parameters default to checked generic; explicit function parameters and local bindings default to runtime. `HandleBindingPattern` resolves the phase from that context plus the keyword: a `generic` keyword needs no node of its own (the phase is carried by the binding's node kind), while a `runtime` keyword is preserved as a `RuntimeBindingName` node so `check` can name it in a diagnostic. A phase keyword that is merely redundant with the contextual default is diagnosed here, without invalidating the parse tree. - Check: a phase keyword that is invalid for its context (for example `runtime` on a checked-generic parameter) is diagnosed here, and recovers by building an error binding that still introduces the name so that later uses of it do not produce cascading errors. The removed `:!` syntax is now rejected as an ordinary parse error. The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is left for a separate change. Assisted-by: Claude Code
184 lines
4.4 KiB
Plaintext
184 lines
4.4 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
library "io_utils";
|
|
|
|
import Core library "io";
|
|
import Core library "range";
|
|
|
|
class EOFType {}
|
|
|
|
class CharOrEOF {
|
|
adapt i32;
|
|
|
|
fn EOF() -> Self;
|
|
}
|
|
|
|
impl CharOrEOF as Core.Copy {
|
|
fn Op(self) -> Self {
|
|
return (self as i32).(Core.Copy.Op)() as Self;
|
|
}
|
|
}
|
|
|
|
fn CharOrEOF.EOF() -> Self {
|
|
// Ordering between `CharOrEOF` and `char` treats EOF as less than all `char`
|
|
// values.
|
|
return (-1 as i32) as CharOrEOF;
|
|
}
|
|
|
|
impl forall [U: Core.ImplicitAs(char)] U as Core.ImplicitAs(CharOrEOF) {
|
|
fn Convert(self: char) -> CharOrEOF {
|
|
return ((self as u8) as i32) as CharOrEOF;
|
|
}
|
|
}
|
|
|
|
impl forall [U: Core.ImplicitAs(CharOrEOF)]
|
|
CharOrEOF as Core.EqWith(U) {
|
|
fn Equal(self, other: CharOrEOF) -> bool {
|
|
return (self as i32) == (other as i32);
|
|
}
|
|
fn NotEqual(self, other: CharOrEOF) -> bool {
|
|
return (self as i32) != (other as i32);
|
|
}
|
|
}
|
|
|
|
impl forall [U: Core.ImplicitAs(CharOrEOF)]
|
|
CharOrEOF as Core.OrderedWith(U) {
|
|
fn Less(self, other: CharOrEOF) -> bool {
|
|
return (self as i32) < (other as i32);
|
|
}
|
|
fn LessOrEquivalent(self, other: CharOrEOF) -> bool {
|
|
return (self as i32) <= (other as i32);
|
|
}
|
|
fn Greater(self, other: CharOrEOF) -> bool {
|
|
return (self as i32) > (other as i32);
|
|
}
|
|
fn GreaterOrEquivalent(self, other: CharOrEOF) -> bool {
|
|
return (self as i32) >= (other as i32);
|
|
}
|
|
}
|
|
|
|
impl forall [U: Core.ImplicitAs(char)]
|
|
CharOrEOF as Core.SubWith(U) where .Result = i32 {
|
|
fn Op(self, other: char) -> i32 {
|
|
return (self as i32) - ((other as u8) as i32);
|
|
}
|
|
}
|
|
|
|
var unread_char: Core.Optional(CharOrEOF)
|
|
= Core.Optional(CharOrEOF).None();
|
|
|
|
fn ReadChar() -> CharOrEOF {
|
|
if (unread_char.HasValue()) {
|
|
var result: CharOrEOF = unread_char.Get();
|
|
unread_char = Core.Optional(CharOrEOF).None();
|
|
return result;
|
|
}
|
|
|
|
var value: i32 = Core.ReadChar();
|
|
if (value == Core.EOF()) {
|
|
return CharOrEOF.EOF();
|
|
} else {
|
|
return value as CharOrEOF;
|
|
}
|
|
}
|
|
|
|
fn UnreadChar(c: CharOrEOF) {
|
|
// TODO: assert(unread_char == 0);
|
|
// TODO: unread_char = c;
|
|
unread_char = Core.Optional(CharOrEOF).Some(c);
|
|
}
|
|
|
|
fn PeekChar() -> CharOrEOF {
|
|
var next: CharOrEOF = ReadChar();
|
|
UnreadChar(next);
|
|
return next;
|
|
}
|
|
|
|
fn ConsumeChar(c: char) -> bool {
|
|
var next: CharOrEOF = ReadChar();
|
|
if (next != c) {
|
|
UnreadChar(next);
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
fn ReadInt[N: Core.IntLiteral](ref p: Core.Int(N)) -> bool {
|
|
var read_any_digits: bool = false;
|
|
let negative: bool = ConsumeChar('-');
|
|
// TODO: `p = 0;` crashes the toolchain, see
|
|
// https://github.com/carbon-language/carbon-lang/issues/6500.
|
|
p = (0 as i32) as Core.Int(N);
|
|
|
|
while (true) {
|
|
var c: CharOrEOF = ReadChar();
|
|
if (c < '0' or c > '9') {
|
|
UnreadChar(c);
|
|
break;
|
|
}
|
|
// TODO: Check for overflow.
|
|
// TODO: p *= 10; crashes the toolchain.
|
|
p *= (10 as i32) as Core.Int(N);
|
|
p += (c - '0') as Core.Int(N);
|
|
read_any_digits = true;
|
|
}
|
|
if (negative) {
|
|
p = -p;
|
|
if (not read_any_digits) {
|
|
UnreadChar('-');
|
|
}
|
|
}
|
|
return read_any_digits;
|
|
}
|
|
|
|
fn PrintIntNoNewline[N: Core.IntLiteral](n_val: Core.Int(N)) {
|
|
// TODO: var pow10: Core.Int(N) = 1; crashes the toolchain.
|
|
var pow10: Core.Int(N) = (1 as i32) as Core.Int(N);
|
|
var n: Core.Int(N) = n_val;
|
|
// TODO: let ten: Core.Int(N) = 10;
|
|
let ten: Core.Int(N) = (10 as i32) as Core.Int(N);
|
|
while (n / ten >= pow10) {
|
|
pow10 = pow10 * ten;
|
|
}
|
|
// TODO: while (pow10 != 0) {
|
|
while (pow10 != ((0 as i32) as Core.Int(N))) {
|
|
let d: Core.Int(N) = n / pow10;
|
|
// TODO: Core.PrintChar('0' + d);
|
|
Core.PrintChar(((d as u8) + (('0' as char) as u8)) as char);
|
|
n = n % pow10;
|
|
pow10 = pow10 / ten;
|
|
}
|
|
}
|
|
|
|
fn PrintInt[N: Core.IntLiteral](n_val: Core.Int(N)) {
|
|
PrintIntNoNewline(n_val);
|
|
Core.PrintChar('\n');
|
|
}
|
|
|
|
fn SkipSpaces() -> bool {
|
|
var skipped_any_spaces: bool = false;
|
|
while (ConsumeChar(' ')) {
|
|
skipped_any_spaces = true;
|
|
}
|
|
return skipped_any_spaces;
|
|
}
|
|
|
|
fn SkipNewline() -> bool {
|
|
// Optional carriage return.
|
|
ConsumeChar('\r');
|
|
// Newline.
|
|
// TODO: Unread the CR if it was present?
|
|
return ConsumeChar('\n');
|
|
}
|
|
|
|
fn SkipNChars(n: i32) -> bool {
|
|
for (_: i32 in Core.Range(n)) {
|
|
if (ReadChar() == CharOrEOF.EOF()) {
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|