mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 19:30:12 +01:00
Chandler Carruthandjosh11b
7871237c15
Implements proposal #7016: `self` moves from the deduced implicit list (`fn F[self: Self]()`) to the front of the explicit list. Its type may be written explicitly (`fn F(self: Self)`) or omitted, in which case it defaults to `Self` (`fn F(self)`, `fn F(ref self)`); `self` in the implicit list is rejected. Throughout checking, `self` is modeled as the first explicit parameter. Because a method is just a function whose first parameter is `self`, it can also be called as an ordinary function with the receiver passed explicitly (`Type.M(obj, ...)`), not only as `obj.M(...)`. A new `SemIR::CallArgParamPatterns` helper chooses the parameters matched against the explicit arguments, excluding a leading `self` only when it is supplied as a method-call receiver; arity checking, conversion, and generic deduction use it. The resulting SemIR and lowering are unchanged: `self` is still `call_param0`, and witnesses, thunks, and vtables are unaffected. An omitted `self` type is parsed as a `SelfBindingPattern` node with no type expression; checking synthesizes the `Self` type so it behaves exactly like `self: Self`. However, the exact spelling used must match between a forward declaration and a definition, following #3763's rules around declaration matching. Generated functions, thunks, and C++ interop import/export build `self` as the first explicit parameter, and the `self`-type override (e.g. Derived->Base for a virtual override) applies to the explicit `self`. Placement is validated by new diagnostics: `SelfInImplicitParamList`, `SelfNotFirstParam`, and `SelfOutsideParamList`. The benchmark source generator and the documentation adopt the `(self)` shorthand; the prelude, the examples, and the test data are migrated in the following commits. Assisted-by: Claude Code with Claude Opus 4.7 --------- Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
233 lines
7.4 KiB
Plaintext
233 lines
7.4 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/eval_musteval.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/eval_musteval.carbon
|
|
|
|
// --- interface.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Runtime {
|
|
fn F(self) -> type;
|
|
}
|
|
|
|
interface Eval {
|
|
eval fn F(self) -> type;
|
|
}
|
|
|
|
interface MustEval {
|
|
musteval fn F(self) -> type;
|
|
}
|
|
|
|
// --- impl_runtime.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class A { adapt {}; }
|
|
|
|
impl A as Runtime {
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as Eval {
|
|
// TODO: Consider rejecting this, as compile-time evaluation would always
|
|
// fail.
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as MustEval {
|
|
// TODO: Consider rejecting this, as compile-time evaluation would always
|
|
// fail.
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
fn Call() {
|
|
({} as A).(Runtime.F)();
|
|
({} as A).(Eval.F)();
|
|
({} as A).(MustEval.F)();
|
|
}
|
|
|
|
// --- fail_impl_runtime_eval.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class A { adapt {}; }
|
|
|
|
impl A as Runtime {
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as Eval {
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as MustEval {
|
|
fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
fn Call() {
|
|
// CHECK:STDERR: fail_impl_runtime_eval.carbon:[[@LINE+4]]:17: error: cannot evaluate type expression [TypeExprEvaluationFailure]
|
|
// CHECK:STDERR: let unused t: ({} as A).(Runtime.F)() = {} as A;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
let unused t: ({} as A).(Runtime.F)() = {} as A;
|
|
// CHECK:STDERR: fail_impl_runtime_eval.carbon:[[@LINE+4]]:17: error: cannot evaluate type expression [TypeExprEvaluationFailure]
|
|
// CHECK:STDERR: let unused u: ({} as A).(Eval.F)() = {} as A;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
let unused u: ({} as A).(Eval.F)() = {} as A;
|
|
// CHECK:STDERR: fail_impl_runtime_eval.carbon:[[@LINE+4]]:17: error: cannot evaluate type expression [TypeExprEvaluationFailure]
|
|
// CHECK:STDERR: let unused v: ({} as A).(MustEval.F)() = {} as A;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
let unused v: ({} as A).(MustEval.F)() = {} as A;
|
|
}
|
|
|
|
// --- impl_eval.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class A { adapt {}; }
|
|
|
|
impl A as Runtime {
|
|
eval fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as Eval {
|
|
eval fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
impl A as MustEval {
|
|
eval fn F(unused self) -> type { return A; }
|
|
}
|
|
|
|
fn Call() {
|
|
// TODO: Should we allow calling this at compile time? This is not allowed if
|
|
// we generate a thunk; see the next split for an example.
|
|
let unused t: ({} as A).(Runtime.F)() = {} as A;
|
|
let unused u: ({} as A).(Eval.F)() = {} as A;
|
|
let unused v: ({} as A).(MustEval.F)() = {} as A;
|
|
}
|
|
|
|
// --- fail_todo_impl_eval_from_runtime_thunk.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class B {}
|
|
|
|
class BView {}
|
|
impl B as Core.ImplicitAs(BView) {
|
|
fn Convert(unused self) -> BView { return {}; }
|
|
}
|
|
|
|
impl B as Runtime {
|
|
eval fn F(unused self: BView) -> type { return B; }
|
|
}
|
|
|
|
fn Call() {
|
|
// TODO: Should we allow calling this at compile time? This is allowed if we
|
|
// don't generate a thunk.
|
|
// CHECK:STDERR: fail_todo_impl_eval_from_runtime_thunk.carbon:[[@LINE+4]]:17: error: cannot evaluate type expression [TypeExprEvaluationFailure]
|
|
// CHECK:STDERR: let unused t: ({} as B).(Runtime.F)() = {} as B;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
let unused t: ({} as B).(Runtime.F)() = {} as B;
|
|
}
|
|
|
|
// --- fail_impl_musteval.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class B { adapt {}; }
|
|
|
|
impl B as Runtime {
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE+11]]:3: error: non-constant call to compile-time-only function [NonConstantCallToCompTimeOnlyFunction]
|
|
// CHECK:STDERR: musteval fn F(unused self) -> type { return B; }
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE+8]]:3: note: compile-time-only function declared here [CompTimeOnlyFunctionHere]
|
|
// CHECK:STDERR: musteval fn F(unused self) -> type { return B; }
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE-11]]:1: in import [InImport]
|
|
// CHECK:STDERR: interface.carbon:5:3: note: while building thunk to match the signature of this function [ThunkSignature]
|
|
// CHECK:STDERR: fn F(self) -> type;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
musteval fn F(unused self) -> type { return B; }
|
|
}
|
|
|
|
impl B as Eval {
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE+11]]:3: error: non-constant call to compile-time-only function [NonConstantCallToCompTimeOnlyFunction]
|
|
// CHECK:STDERR: musteval fn F(unused self) -> type { return B; }
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE+8]]:3: note: compile-time-only function declared here [CompTimeOnlyFunctionHere]
|
|
// CHECK:STDERR: musteval fn F(unused self) -> type { return B; }
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_impl_musteval.carbon:[[@LINE-26]]:1: in import [InImport]
|
|
// CHECK:STDERR: interface.carbon:9:3: note: while building thunk to match the signature of this function [ThunkSignature]
|
|
// CHECK:STDERR: eval fn F(self) -> type;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
musteval fn F(unused self) -> type { return B; }
|
|
}
|
|
|
|
// --- impl_musteval_from_musteval.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class B { adapt {}; }
|
|
|
|
impl B as MustEval {
|
|
musteval fn F(unused self) -> type { return B; }
|
|
}
|
|
|
|
fn Call() {
|
|
let unused t: ({} as B).(MustEval.F)() = {} as B;
|
|
}
|
|
|
|
// --- fail_todo_impl_musteval_from_musteval_thunk.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import library "interface";
|
|
|
|
class B {}
|
|
|
|
class BView {}
|
|
impl B as Core.ImplicitAs(BView) {
|
|
fn Convert(unused self) -> BView { return {}; }
|
|
}
|
|
|
|
impl B as MustEval {
|
|
// CHECK:STDERR: fail_todo_impl_musteval_from_musteval_thunk.carbon:[[@LINE+11]]:3: error: non-constant call to compile-time-only function [NonConstantCallToCompTimeOnlyFunction]
|
|
// CHECK:STDERR: musteval fn F(unused self: BView) -> type { return B; }
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_todo_impl_musteval_from_musteval_thunk.carbon:[[@LINE+8]]:3: note: compile-time-only function declared here [CompTimeOnlyFunctionHere]
|
|
// CHECK:STDERR: musteval fn F(unused self: BView) -> type { return B; }
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR: fail_todo_impl_musteval_from_musteval_thunk.carbon:[[@LINE-16]]:1: in import [InImport]
|
|
// CHECK:STDERR: interface.carbon:13:3: note: while building thunk to match the signature of this function [ThunkSignature]
|
|
// CHECK:STDERR: musteval fn F(self) -> type;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
musteval fn F(unused self: BView) -> type { return B; }
|
|
}
|