Dana Jansens 4416f3525b Canonicalize generated functions for Core witnesses (#7729) ...

Use a single `SemIR::Function` per `Core` interface method, whether it's
generated locally or imported. This prevents generating duplicate
functions, which lead to different types when the witness appears in a
`FacetValue` as part of a specific for a class.

We use a `CanonicalValueStore` of `GeneratedFunction` objects that allow
finding an existing FunctionId for a `Generated` special function before
(re-)generating it. Mangling for `Generated` functions is also moved to
use the values from the `GeneratedFunction`'s canonicalization key, so
that we have a consistent source of truth for the unique ID of a
`Generated` function across all files.

New tests are in
`toolchain/check/testdata/impl/custom_witness/destroy.carbon`.

2026-09-15 16:02:13 +00:00

..

cpp

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

fuzzer_corpus

Change array syntax from [T; N] to array(T, N) (#4981)

2025-02-20 22:42:47 +00:00

testdata

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

action.cpp

Support for lowering templates (#7727)

2026-09-08 18:39:57 +00:00

action.h

NOLINT the cycle through HandleAction and pattern matching (#7767)

2026-09-10 22:33:50 +00:00

BUILD

Create modules for header imports. (#7613)

2026-08-06 13:32:37 +00:00

call.cpp

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

call.h

Don't require ref tags in thunks (#7115)

2026-04-29 18:33:53 +00:00

check_fuzzer.cpp

Switch Driver back to parameters for construction (#4849)

2025-01-27 23:48:44 +00:00

check_unit.cpp

Diagnose missing interface definition in impl files (#7622)

2026-08-11 21:06:17 +00:00

check_unit.h

Create modules for header imports. (#7613)

2026-08-06 13:32:37 +00:00

check.cpp

Create modules for header imports. (#7613)

2026-08-06 13:32:37 +00:00

check.h

Create modules for header imports. (#7613)

2026-08-06 13:32:37 +00:00

class.cpp

Fix SemIR not showing insts used to compute FieldDecl type (#7706)

2026-09-02 20:28:05 +00:00

class.h

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

context.cpp

Avoid symbolic witnesses for .Self in an impl decl (#7564)

2026-07-29 16:25:23 +00:00

context.h

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

control_flow.cpp

Destroy temporaries at the end of expression statements. (#7513)

2026-07-16 15:12:39 +00:00

control_flow.h

Destroy temporaries at the end of expression statements. (#7513)

2026-07-16 15:12:39 +00:00

convert.cpp

Fix crash when initializing class with omitted base class (#7740)

2026-09-10 19:29:24 +00:00

convert.h

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

core_identifier.cpp

Add well-known identifier caching (#6486)

2025-12-11 21:41:47 +00:00

core_identifier.def

Support LP64 platforms such as Darwin where int64_t is long long. (#7596)

2026-08-07 16:10:01 +00:00

core_identifier.h

Add well-known identifier caching (#6486)

2025-12-11 21:41:47 +00:00

custom_witness.cpp

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

custom_witness.h

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

decl_introducer_state.h

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

decl_name_stack.cpp

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

decl_name_stack.h

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

deduce.cpp

Fix top-of-tree Clang build warnings (#7670)

2026-08-24 15:54:21 +00:00

deduce.h

Avoid impl lookup cycles from evaluating lookup instructions inside an impl decl (#7454)

2026-07-09 20:38:56 +00:00

deferred_definition_worklist.cpp

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

deferred_definition_worklist.h

Reimplement derived class thunk in terms of down-casting (#7322)

2026-06-09 21:10:18 +00:00

diagnostic_emitter.cpp

Fix handling of recursive macros. (#7593)

2026-07-31 20:09:03 +00:00

diagnostic_emitter.h

Drop "diagnostic" from some filenames in the "diagnostics" folder (#6686)

2026-02-04 17:24:55 +00:00

diagnostic_helpers.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

dump.cpp

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

eval_inst.cpp

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

eval_inst.h

Remove redundant use of typename (#7751)

2026-09-11 00:22:27 +00:00

eval.cpp

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

eval.h

Initialize specifics in-place. (#7717)

2026-09-03 17:06:22 +00:00

facet_type.cpp

Avoid symbolic witnesses for .Self in an impl decl (#7564)

2026-07-29 16:25:23 +00:00

facet_type.h

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

full_pattern_stack.cpp

Emit VarStorages eagerly (#7468)

2026-07-08 19:33:46 +00:00

full_pattern_stack.h

Reconcile function default values between decl and def (#7665)

2026-09-08 20:41:58 +00:00

function.cpp

Reconcile function default values between decl and def (#7665)

2026-09-08 20:41:58 +00:00

function.h

Support arbitrary parameter forms in MakeGeneratedFunctionDecl (#7654)

2026-08-24 21:15:50 +00:00

generic_region_stack.cpp

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

generic_region_stack.h

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

generic.cpp

Remove incorrect CHECK that would fail for out-of-line template declarations. (#7772)

2026-09-11 16:58:05 +00:00

generic.h

Make template actions refer to values from the specific. (#7663)

2026-08-21 18:34:21 +00:00

global_init.cpp

Transform pattern default values to SemIR (#7649)

2026-09-01 16:12:34 +00:00

global_init.h

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

handle_alias.cpp

Look outside constant values for designators in where constraints (#7367)

2026-07-16 19:00:06 +00:00

handle_array.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_binding_pattern.cpp

Diagnose where in a binding that introduces a .Self that does not refer to the binding (#7517)

2026-07-22 16:45:00 +00:00

handle_call_expr.cpp

Parse ref as operator (#6539)

2025-12-30 19:18:34 +00:00

handle_choice.cpp

Remove ValueBinding and RefBinding (#7427)

2026-06-29 17:41:23 +00:00

handle_class.cpp

Unify MergeRedecl functions (#7632)

2026-08-25 18:43:52 +00:00

handle_codeblock.cpp

Destroy temporaries at the end of expression statements. (#7513)

2026-07-16 15:12:39 +00:00

handle_export.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_expr_statement.cpp

Destroy temporaries at the end of expression statements. (#7513)

2026-07-16 15:12:39 +00:00

handle_file.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_form_literal.cpp

Remove InitForm::index (#6817)

2026-03-06 17:35:48 +00:00

handle_function.cpp

Remove empty lambda parameters in handle_function (#7777)

2026-09-11 18:22:33 +00:00

handle_if_expr.cpp

Destroy locals at the end of blocks, not only on return (#7448)

2026-07-14 00:59:22 +00:00

handle_if_statement.cpp

Destroy temporaries at the end of expression statements. (#7513)

2026-07-16 15:12:39 +00:00

handle_impl.cpp

Transform pattern default values to SemIR (#7649)

2026-09-01 16:12:34 +00:00

handle_import_and_package.cpp

Add support for inline Cpp declarations. (#6994)

2026-03-31 22:27:43 +00:00

handle_index.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

handle_inline_decl.cpp

Fix crash if initializing Clang fails. (#7248)

2026-05-21 21:21:50 +00:00

handle_interface.cpp

Unify MergeRedecl functions (#7632)

2026-08-25 18:43:52 +00:00

handle_lambda.cpp

[parse] Implement initial parsing support for Lambda expressions (#6583)

2026-01-14 16:58:15 +00:00

handle_let_and_var.cpp

Add interface modifiers (#7625)

2026-08-17 20:49:23 +00:00

handle_literal.cpp

Implement Core.CharLiteral operations from #6710 and #7314 (#7316)

2026-06-11 16:45:39 +00:00

handle_loop_statement.cpp

Report an uniterable for range once (#7661)

2026-08-21 04:09:16 +00:00

handle_match_first.cpp

Connect impls to their containing match_first block (#7486)

2026-07-13 19:14:38 +00:00

handle_match.cpp

Refactor match parse nodes. (#6870)

2026-03-10 20:04:28 +00:00

handle_modifier.cpp

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

handle_name.cpp

Implement thunking in terms of constant evaluation (#7332)

2026-06-13 00:22:00 +00:00

handle_named_constraint.cpp

Unify MergeRedecl functions (#7632)

2026-08-25 18:43:52 +00:00

handle_namespace.cpp

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

handle_noop.cpp

Abort checking when encountering an invalid parse node (#4700)

2024-12-18 00:19:12 +00:00

handle_observe.cpp

Implement checking observe declarations (#6709)

2026-07-08 17:07:10 +00:00

handle_operator.cpp

Allow assignment to be called on a template-dependent lhs (#7741)

2026-09-10 15:07:31 +00:00

handle_paren_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_pattern_list.cpp

Reconcile function default values between decl and def (#7665)

2026-09-08 20:41:58 +00:00

handle_positional_param_expr.cpp

Support lexing and parsing positional params (#7651)

2026-09-03 19:06:20 +00:00

handle_require.cpp

Rename FacetTypeInfo to DeclaredFacetType (#7528)

2026-07-20 19:15:09 +00:00

handle_return_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_struct.cpp

Simplify struct literal pop loop. (#7158)

2026-05-02 01:09:50 +00:00

handle_tuple_literal.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

handle_where.cpp

Find the current impl from accesses in a named constraint being implemented (#7592)

2026-07-31 20:17:06 +00:00

handle.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

impl_lookup.cpp

Find the current impl from accesses in a named constraint being implemented (#7592)

2026-07-31 20:17:06 +00:00

impl_lookup.h

Avoid symbolic witnesses for .Self in an impl decl (#7564)

2026-07-29 16:25:23 +00:00

impl_validation.cpp

Anchor the orphan rule on the first owning declaration (#7573)

2026-07-27 14:49:06 +00:00

impl_validation.h

Add diagnostics for invalid impl declarations (#5420)

2025-05-22 18:58:47 +00:00

impl.cpp

Allow witness tables to support aliases and other types of StructValue (#7738)

2026-09-09 19:35:43 +00:00

impl.h

Use GetConstantValueInSpecific to get the impl's specific interface after deduction (#7584)

2026-07-30 19:59:10 +00:00

import_ref.cpp

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

import_ref.h

When performing an impl lookup, only import impls for related interfaces. (#6040)

2025-09-10 21:40:27 +00:00

import.cpp

Remove ValueBinding and RefBinding (#7427)

2026-06-29 17:41:23 +00:00

import.h

Add MakeVerifiedLocIdAndInst for runtime validation (#6942)

2026-03-24 20:56:44 +00:00

inst_block_stack.cpp

Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)

2025-03-21 23:09:37 +00:00

inst_block_stack.h

Add require decls to Interface and NamedConstraint (#6321)

2025-11-11 16:36:15 +00:00

inst.cpp

Support constant InstActions (#7671)

2026-08-24 18:05:15 +00:00

inst.h

Implement thunking in terms of constant evaluation (#7332)

2026-06-13 00:22:00 +00:00

interface.cpp

Unify MergeRedecl functions (#7632)

2026-08-25 18:43:52 +00:00

interface.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

keyword_modifier_set.cpp

Some more edits to EnumBase and EnumMaskBase (#6054)

2025-09-12 22:59:37 +00:00

keyword_modifier_set.h

Connect impls to their containing match_first block (#7486)

2026-07-13 19:14:38 +00:00

lexical_lookup.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

literal.cpp

Remove trailing () from Core.*Literal and Core.Bool. (#7313)

2026-06-05 22:33:30 +00:00

literal.h

Add a type_literal instruction to represent syntactic type literals. (#6781)

2026-02-26 20:10:50 +00:00

member_access.cpp

Add template action for compound member access. (#7657)

2026-08-20 15:45:02 +00:00

member_access.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

merge.cpp

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

merge.h

Unify MergeRedecl functions (#7632)

2026-08-25 18:43:52 +00:00

modifiers.cpp

Add interface modifiers (#7625)

2026-08-17 20:49:23 +00:00

modifiers.h

Add interface modifiers (#7625)

2026-08-17 20:49:23 +00:00

name_component.cpp

Transform pattern default values to SemIR (#7649)

2026-09-01 16:12:34 +00:00

name_component.h

Transform pattern default values to SemIR (#7649)

2026-09-01 16:12:34 +00:00

name_lookup.cpp

Rename FacetTypeInfo to DeclaredFacetType (#7528)

2026-07-20 19:15:09 +00:00

name_lookup.h

Don't re-require complete types for extended scopes (#7194)

2026-05-13 17:16:02 +00:00

name_scope.cpp

Diagnose explicit Self in extend in the parse node handler (Refactor Impl construction 1/7) (#6465)

2025-12-09 20:38:50 +00:00

name_scope.h

Diagnose explicit Self in extend in the parse node handler (Refactor Impl construction 1/7) (#6465)

2025-12-09 20:38:50 +00:00

node_id_traversal.cpp

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

node_id_traversal.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

node_stack.cpp

Use lines instead of statements for readability-function-size clang-tidy (#6594)

2026-01-14 19:32:03 +00:00

node_stack.h

Fix a crash when checking a nested tuple-pattern (#7716)

2026-09-04 01:22:16 +00:00

operator.cpp

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

operator.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

param_and_arg_refs_stack.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

pattern_match.cpp

NOLINT the cycle through HandleAction and pattern matching (#7767)

2026-09-10 22:33:50 +00:00

pattern_match.h

Implement thunking in terms of constant evaluation (#7332)

2026-06-13 00:22:00 +00:00

pattern.cpp

Fix SemIR not showing insts used to compute FieldDecl type (#7706)

2026-09-02 20:28:05 +00:00

pattern.h

Restructure handling of expressions in patterns (#7445)

2026-07-01 19:15:34 +00:00

pending_block.h

Fix crash if an inst in a pending block needs a cleanup. (#7166)

2026-05-04 21:50:13 +00:00

period_self.cpp

Avoid symbolic witnesses for .Self in an impl decl (#7564)

2026-07-29 16:25:23 +00:00

period_self.h

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

pointer_dereference.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

pointer_dereference.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

region_stack.h

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

require_impls_stack.cpp

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

require_impls_stack.h

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

return.cpp

Destroy locals at the end of blocks, not only on return (#7448)

2026-07-14 00:59:22 +00:00

return.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

scope_index.h

Use inline constexpr where appropriate. (#6374)

2025-11-14 13:50:56 +00:00

scope_stack.cpp

Destroy temporaries at the end of expression statements. (#7513)

2026-07-16 15:12:39 +00:00

scope_stack.h

Destroy temporaries at the end of expression statements. (#7513)

2026-07-16 15:12:39 +00:00

subst.cpp

Rename FacetTypeInfo to DeclaredFacetType (#7528)

2026-07-20 19:15:09 +00:00

subst.h

Add SubstResult::SubstOperandsSkipType to not subst the type_id (#7452)

2026-07-07 13:23:47 +00:00

thunk.cpp

Transform pattern default values to SemIR (#7649)

2026-09-01 16:12:34 +00:00

thunk.h

Add support for exporting Carbon functions as constructors. (#7560)

2026-07-24 18:43:12 +00:00

type_completion.cpp

Reconcile function default values between decl and def (#7665)

2026-09-08 20:41:58 +00:00

type_completion.h

Avoid symbolic witnesses for .Self in an impl decl (#7564)

2026-07-29 16:25:23 +00:00

type_structure.cpp

Correctly handle ImplWitnessAccess in impl lookup (#7181)

2026-05-11 14:17:18 +00:00

type_structure.h

Search all facets in the impl lookup query for witnesses (#7178)

2026-05-07 22:33:47 +00:00

type.cpp

Gracefully handle member access on a runtime type value (#7744)

2026-09-09 23:05:48 +00:00

type.h

Rename FacetTypeInfo to DeclaredFacetType (#7528)

2026-07-20 19:15:09 +00:00

unused.cpp

Clean up some of the TODOs in unused.carbon (#6794)

2026-02-26 18:57:15 +00:00

unused.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00