mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-18 11:50:37 +00:00
A lot of this is more boring "remove unused header", plus some other minor cleanups. I think the most significant changes were: - yaml_test_helpers.cpp is doing a switch on an unsigned int, comparing to enum values. - [bugprone-switch-missing-default-case](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/switch-missing-default-case.html) is unhappy with EnumBase, but correctly identified yaml_test_helpers.cpp, so I'm opting to address it rather than disabling it even though it needs NOLINT in several locations as a result, in addition to what I think are some low-value `default` cases. I'd be fine going the other way with this too and disabling it globally (I could see it being noisier in the explorer). - MarkInitializerFor swaps the argument names between the .h and .cpp. I think the .cpp had the order as intended. - There's a new-ish [performance-enum-size](https://clang.llvm.org/extra/clang-tidy/checks/performance/enum-size.html) which I'm basically treating as "add int8_t to enums". My main motivation here is to just clean up as many of these as I can so that I stop seeing them in vscode.
33 lines
1.2 KiB
C++
33 lines
1.2 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/lexer/lex_helpers.h"
|
|
|
|
namespace Carbon {
|
|
|
|
auto CanLexInteger(DiagnosticEmitter<const char*>& emitter,
|
|
llvm::StringRef text) -> bool {
|
|
// llvm::getAsInteger is used for parsing, but it's quadratic and visibly slow
|
|
// on large integer values. This limit exists to avoid hitting those limits.
|
|
// Per https://github.com/carbon-language/carbon-lang/issues/980, it may be
|
|
// feasible to optimize integer parsing in order to address performance if
|
|
// this limit becomes an issue.
|
|
//
|
|
// 2^128 would be 39 decimal digits or 128 binary. In either case, this limit
|
|
// is far above the threshold for normal integers.
|
|
constexpr size_t DigitLimit = 1000;
|
|
if (text.size() > DigitLimit) {
|
|
CARBON_DIAGNOSTIC(
|
|
TooManyDigits, Error,
|
|
"Found a sequence of {0} digits, which is greater than the "
|
|
"limit of {1}.",
|
|
size_t, size_t);
|
|
emitter.Emit(text.begin(), TooManyDigits, text.size(), DigitLimit);
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon
|