mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-19 10:40:29 +00:00
This takes the mechanism currently used for autoupdate and expands it to the regular tests (deliberately trying to unify logic for test/autoupdate/dump to deliver consistent behavior). I'm seeing about a 85% reduction in test time, though results will vary based on test system. This does some small edits to test output to make it fit better with the new flow. Note I'm stopping printing of the "here's how to run" on every test by default, since it's autoupdated into file content by default. However, it's still there for test failures. --------- Co-authored-by: Geoff Romer <gromer@google.com>
118 lines
4.1 KiB
C++
118 lines
4.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "absl/flags/flag.h"
|
|
#include "common/raw_string_ostream.h"
|
|
#include "explorer/main.h"
|
|
#include "re2/re2.h"
|
|
#include "testing/file_test/file_test_base.h"
|
|
|
|
ABSL_FLAG(bool, trace, false,
|
|
"Set to true to run tests with tracing enabled, even if they don't "
|
|
"otherwise specify it. This does not result in checking trace output "
|
|
"contents; it essentially only verifies there's not a crash bug.");
|
|
|
|
namespace Carbon::Testing {
|
|
namespace {
|
|
|
|
class ExplorerFileTest : public FileTestBase {
|
|
public:
|
|
explicit ExplorerFileTest(llvm::StringRef /*exe_path*/,
|
|
llvm::StringRef test_name)
|
|
: FileTestBase(test_name),
|
|
prelude_line_re_(R"(prelude.carbon:(\d+))"),
|
|
timing_re_(R"((Time elapsed in \w+: )\d+(ms))") {
|
|
CARBON_CHECK(prelude_line_re_.ok(), "{0}", prelude_line_re_.error());
|
|
CARBON_CHECK(timing_re_.ok(), "{0}", timing_re_.error());
|
|
}
|
|
|
|
auto Run(const llvm::SmallVector<llvm::StringRef>& test_args,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::InMemoryFileSystem>& fs,
|
|
FILE* /*input_stream*/, llvm::raw_pwrite_stream& output_stream,
|
|
llvm::raw_pwrite_stream& error_stream)
|
|
-> ErrorOr<RunResult> override {
|
|
// Add the prelude.
|
|
llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> prelude =
|
|
llvm::MemoryBuffer::getFile("explorer/data/prelude.carbon");
|
|
if (prelude.getError()) {
|
|
return ErrorBuilder() << prelude.getError().message();
|
|
}
|
|
// TODO: This path is long with a prefix / because of the path expectations
|
|
// in tests. Change those to allow a shorter path (e.g., `prelude.carbon`)
|
|
// here.
|
|
static constexpr llvm::StringLiteral PreludePath =
|
|
"/explorer/data/prelude.carbon";
|
|
if (!fs->addFile(PreludePath, /*ModificationTime=*/0,
|
|
std::move(*prelude))) {
|
|
return ErrorBuilder() << "Duplicate prelude.carbon";
|
|
}
|
|
|
|
llvm::SmallVector<const char*> args = {"explorer"};
|
|
for (auto arg : test_args) {
|
|
args.push_back(arg.data());
|
|
}
|
|
|
|
int exit_code =
|
|
ExplorerMain(args.size(), args.data(), /*install_path=*/"", PreludePath,
|
|
output_stream, error_stream,
|
|
check_trace_output() ? output_stream : trace_stream_, *fs);
|
|
|
|
// Skip trace test check as they use stdout stream instead of
|
|
// trace_stream_ostream
|
|
if (absl::GetFlag(FLAGS_trace) && trace_stream_.TakeStr().empty()) {
|
|
return Error("Tracing should always do something");
|
|
}
|
|
|
|
return {{.success = exit_code == EXIT_SUCCESS}};
|
|
}
|
|
|
|
auto GetDefaultArgs() -> llvm::SmallVector<std::string> override {
|
|
llvm::SmallVector<std::string> args;
|
|
if (absl::GetFlag(FLAGS_trace)) {
|
|
args.push_back("--trace_file=-");
|
|
args.push_back("--trace_phase=all");
|
|
}
|
|
args.push_back("%s");
|
|
return args;
|
|
}
|
|
|
|
auto GetLineNumberReplacements(llvm::ArrayRef<llvm::StringRef> filenames)
|
|
-> llvm::SmallVector<LineNumberReplacement> override {
|
|
if (check_trace_output()) {
|
|
return {};
|
|
}
|
|
return FileTestBase::GetLineNumberReplacements(filenames);
|
|
}
|
|
|
|
auto DoExtraCheckReplacements(std::string& check_line) -> void override {
|
|
// Ignore the resulting column of EndOfFile because it's often the end of
|
|
// the CHECK comment.
|
|
RE2::GlobalReplace(&check_line, prelude_line_re_,
|
|
R"(prelude.carbon:{{\\d+}})");
|
|
if (check_trace_output()) {
|
|
// Replace timings in trace output.
|
|
RE2::GlobalReplace(&check_line, timing_re_, R"(\1{{\\d+}}\2)");
|
|
}
|
|
}
|
|
|
|
// Cannot execute in parallel.
|
|
auto AllowParallelRun() const -> bool override { return false; }
|
|
|
|
private:
|
|
// Trace output is directly checked for a few tests.
|
|
auto check_trace_output() -> bool {
|
|
return test_name().find("/trace/") != std::string::npos;
|
|
}
|
|
|
|
RawStringOstream trace_stream_;
|
|
RE2 prelude_line_re_;
|
|
RE2 timing_re_;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
CARBON_FILE_TEST_FACTORY(ExplorerFileTest)
|
|
|
|
} // namespace Carbon::Testing
|