carbon-lang

5,322 Commits 3 Branches 806 Tags

5 Commits

Include renames

Author	SHA1	Message	Date
Jon Ross-Perkins	c5761d2d16	Improve parsing large integers (#6908 ) Though I started this thinking about performance of parse of large decimal integers, I extended it to generally improve performance of integer values (TBH I hadn't expected such a difference for binary/hex, but I'll take it). Note I think tests change because I'm making subtle changes to bit widths. The changes themselves appear harmless to me, but happy to make changes if it'd help. Bumping up the number of digits by 10x because it's not really a performance issue anymore (eh, maybe somebody will want to specify a 256-byte value in binary). But, at a certain point it still seems like a mistake if somebody has that many digits in a row. Fixes #980 Highlighting benchmark differences: ```diff - BM_ComputeValue_IntDecimalN/1 37.1 ns 37.1 ns 18887116 + BM_ComputeValue_IntDecimalN/1 21.9 ns 21.9 ns 31902433 - BM_ComputeValue_IntDecimalN/10000 1251228680 ns 1250457559 ns 1 + BM_ComputeValue_IntDecimalN/10000 458818 ns 458626 ns 1523 - BM_ComputeValue_IntBinaryN/1 29.0 ns 29.0 ns 24058533 + BM_ComputeValue_IntBinaryN/1 22.2 ns 22.1 ns 31566949 - BM_ComputeValue_IntBinaryN/10000 1390557 ns 1389782 ns 506 + BM_ComputeValue_IntBinaryN/10000 16402 ns 16396 ns 42744 - BM_ComputeValue_IntHexN/1 34.0 ns 34.0 ns 20562432 + BM_ComputeValue_IntHexN/1 22.4 ns 22.4 ns 31238055 - BM_ComputeValue_IntHexN/10000 5387942 ns 5385262 ns 130 + BM_ComputeValue_IntHexN/10000 39249 ns 39233 ns 17859 ``` Benchmark before: ``` ---------------------------------------------------------------------------- Benchmark Time CPU Iterations ---------------------------------------------------------------------------- BM_Lex_Float 10.6 ns 10.6 ns 66138191 BM_Lex_Int 15.5 ns 15.4 ns 45149703 BM_Lex_IntDecimalN/1 3.11 ns 3.11 ns 225524908 BM_Lex_IntDecimalN/10 11.8 ns 11.8 ns 56719805 BM_Lex_IntDecimalN/100 102 ns 102 ns 6867468 BM_Lex_IntDecimalN/1000 943 ns 942 ns 745313 BM_Lex_IntDecimalN/10000 9465 ns 9461 ns 73970 BM_ComputeValue_Float 61.6 ns 61.6 ns 11377463 BM_ComputeValue_Int 106 ns 106 ns 6587381 BM_ComputeValue_IntDecimalN/1 37.1 ns 37.1 ns 18887116 BM_ComputeValue_IntDecimalN/10 87.7 ns 87.7 ns `7960837` BM_ComputeValue_IntDecimalN/100 7963 ns 7956 ns 88858 BM_ComputeValue_IntDecimalN/1000 1212577 ns 1211906 ns 578 BM_ComputeValue_IntDecimalN/10000 1251228680 ns 1250457559 ns 1 BM_ComputeValue_IntBinaryN/1 29.0 ns 29.0 ns 24058533 BM_ComputeValue_IntBinaryN/10 69.4 ns 69.4 ns 10108642 BM_ComputeValue_IntBinaryN/100 963 ns 962 ns 726982 BM_ComputeValue_IntBinaryN/1000 21562 ns 21551 ns 32506 BM_ComputeValue_IntBinaryN/10000 1390557 ns 1389782 ns 506 BM_ComputeValue_IntHexN/1 34.0 ns 34.0 ns 20562432 BM_ComputeValue_IntHexN/10 70.4 ns 70.4 ns 9953165 BM_ComputeValue_IntHexN/100 1474 ns 1473 ns 472776 BM_ComputeValue_IntHexN/1000 61818 ns 61762 ns 11363 BM_ComputeValue_IntHexN/10000 5387942 ns 5385262 ns 130 ``` Benchmark after: ``` ---------------------------------------------------------------------------- Benchmark Time CPU Iterations ---------------------------------------------------------------------------- BM_Lex_Float 10.9 ns 10.9 ns 63993114 BM_Lex_Int 15.1 ns 15.1 ns 46869766 BM_Lex_IntDecimalN/1 3.16 ns 3.16 ns 220923300 BM_Lex_IntDecimalN/10 12.2 ns 12.2 ns 57731654 BM_Lex_IntDecimalN/100 102 ns 102 ns 6875516 BM_Lex_IntDecimalN/1000 942 ns 942 ns 742359 BM_Lex_IntDecimalN/10000 9353 ns 9350 ns 75096 BM_ComputeValue_Float 44.9 ns 44.9 ns 15619691 BM_ComputeValue_Int 48.9 ns 48.9 ns 14361507 BM_ComputeValue_IntDecimalN/1 21.9 ns 21.9 ns 31902433 BM_ComputeValue_IntDecimalN/10 30.3 ns 30.3 ns 23134117 BM_ComputeValue_IntDecimalN/100 224 ns 223 ns 3092567 BM_ComputeValue_IntDecimalN/1000 5834 ns 5830 ns 117469 BM_ComputeValue_IntDecimalN/10000 458818 ns 458626 ns 1523 BM_ComputeValue_IntBinaryN/1 22.2 ns 22.1 ns 31566949 BM_ComputeValue_IntBinaryN/10 32.9 ns 32.9 ns 21306927 BM_ComputeValue_IntBinaryN/100 198 ns 198 ns 3545277 BM_ComputeValue_IntBinaryN/1000 1671 ns 1669 ns 419656 BM_ComputeValue_IntBinaryN/10000 16402 ns 16396 ns 42744 BM_ComputeValue_IntHexN/1 22.4 ns 22.4 ns 31238055 BM_ComputeValue_IntHexN/10 47.8 ns 47.7 ns 14694407 BM_ComputeValue_IntHexN/100 436 ns 436 ns 1609794 BM_ComputeValue_IntHexN/1000 3966 ns 3962 ns 177109 BM_ComputeValue_IntHexN/10000 39249 ns 39233 ns 17859 ``` Assisted-by: Google Antigravity with Gemini	2026-03-16 20:00:51 +00:00
Jon Ross-Perkins	acbe6530c3	Move diagnostics into a namespace (#5173 ) What this really does is avoids shadowing names, so that we can comfortable have things like `Check::DiagnosticEmitter` or `Check::DiagnosticLoc` without shadowing being a concern. Note, down this path I'm also thinking about: - Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly just to DiagnosticConsumer/DiagnosticEmitter (so `Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`). - Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`. - But not for `Check::DiagnosticBuilder`, because `Check::Builder` would be ambiguous. - Renaming diagnostics/diagnostic_* to drop "diagnostic". [Discussion about SemIRLoc -> DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698) reminded me of this (in particular the older [Check::DiagnosticBuilder discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)), but I'd only do that rename if there's matching consensus about a path forward where we keep SemIRLoc, and in a way that it's only ever used for diagnostics (the divergence from which is at the root of current LocId discussion). I'm trying to keep that separate from a namespace addition for clarity.	2025-03-26 19:12:10 +00:00
Jon Ross-PerkinsandRichard Smith	e7aebbe581	Update basic diagnostic capitalization/punctuation (#4328 ) This is a primarily automated change: - Search & replace for capitalization - `(CARBON_DIAGNOSTIC\((?:\n\s+)?\w+,(?:\n\s+)?\s\w+,(?:\n\s+)?\s")([A-Z])` - `$1\L$2` - Search & replace for period - `(CARBON_DIAGNOSTIC\((?:\n\s+)?\w+,(?:\n\s+)?\s\w+,(?:\n\s+)?\s"(?:[^)]\|\n)+)\.("[,)])` - `$1$2` - Limited search & replace for `ERROR: ` -> `error: ` in streamed things - Leaving a TODO for command_line because there's more cleanup that can be done there - Modify diagnostic_consumer.cpp - ERROR -> error - WARNING -> warning --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk>	2024-09-19 21:32:53 +00:00
Jon Ross-Perkins	0db63ff17a	Abbreviate Integer and FloatingPoint (#3435 ) I was suggesting this because `FloatingPoint` is pretty long. `int` and `float` should be familiar abbreviations. `unsigned` should be familiar to developers too, but `UnsignedInt` still feels usefully clearer for the additional chars.	2023-11-29 23:29:48 +00:00
Jon Ross-PerkinsandChandler Carruth	ec182fb00d	Rename lexer dir to lex (#3179 ) Continuing with #3070. Just a dir and file rename (only prefix change is lexer_file_test). Everything in the lex dir should be marked as a move. Note, I think this closes #3070. There may still be further cleanup later, but the organizational changes suggested there are being completed. --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com>	2023-09-01 02:39:04 +00:00