mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 21:50:14 +01:00
Jon Ross-Perkins
acbe6530c3
What this really does is avoids shadowing names, so that we can comfortable have things like `Check::DiagnosticEmitter` or `Check::DiagnosticLoc` without shadowing being a concern. Note, down this path I'm also thinking about: - Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly just to DiagnosticConsumer/DiagnosticEmitter (so `Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`). - Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`. - But not for `Check::DiagnosticBuilder`, because `Check::Builder` would be ambiguous. - Renaming diagnostics/diagnostic_* to drop "diagnostic". [Discussion about SemIRLoc -> DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698) reminded me of this (in particular the older [Check::DiagnosticBuilder discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)), but I'd only do that rename if there's matching consensus about a path forward where we keep SemIRLoc, and in a way that it's only ever used for diagnostics (the divergence from which is at the root of current LocId discussion). I'm trying to keep that separate from a namespace addition for clarity.
33 lines
1.2 KiB
C++
33 lines
1.2 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/lex/helpers.h"
|
|
|
|
namespace Carbon::Lex {
|
|
|
|
auto CanLexInt(Diagnostics::Emitter<const char*>& emitter, llvm::StringRef text)
|
|
-> bool {
|
|
// llvm::getAsInteger is used for parsing, but it's quadratic and visibly slow
|
|
// on large integer values. This limit exists to avoid hitting those limits.
|
|
// Per https://github.com/carbon-language/carbon-lang/issues/980, it may be
|
|
// feasible to optimize integer parsing in order to address performance if
|
|
// this limit becomes an issue.
|
|
//
|
|
// 2^128 would be 39 decimal digits or 128 binary. In either case, this limit
|
|
// is far above the threshold for normal ints.
|
|
constexpr size_t DigitLimit = 1000;
|
|
if (text.size() > DigitLimit) {
|
|
CARBON_DIAGNOSTIC(
|
|
TooManyDigits, Error,
|
|
"found a sequence of {0} digits, which is greater than the "
|
|
"limit of {1}",
|
|
size_t, size_t);
|
|
emitter.Emit(text.begin(), TooManyDigits, text.size(), DigitLimit);
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon::Lex
|