4 Commits

Include renames

Author	SHA1	Message	Date
Boaz Brickner	7de86a0b10	Move and deduplicate testing access when a Carbon class extends a C++ record to access.carbon (#5897) ... Followup of #5858. Part of #5859.	2025-08-01 13:44:08 +00:00
Richard Smith	25681901bd	Improve mapping of Clang diagnostics into Carbon diagnostics (#5894) ... Instead of taking the complete text of the Clang diagnostic and using it as the message portion of a Carbon diagnostic, generate the individual pieces separately and pass them into the Carbon diagnostic infrastructure. * Clang's context lines are generated by running a custom "diagnostic renderer" and tracking which lines it wants to print as context for a given source location. When mapping from a C++ source location back to a Carbon location, the Carbon `Loc` structure is now fully populated, including filling in the context line and the column number. * Clang's snippet is generated by running a custom diagnostic renderer that is a cut-down version of the full text diagnostic renderer that only prints a snippet. This is then attached to the Carbon diagnostic manually as an override for the snippet we'd usually create. We no longer repeat the file location twice on each diagnostic, and no longer produce a bogus "in import" line for all locations coming from clang that point arbitrarily to the first C++ import in the Carbon file. The `[diagnostic kind]` marker is now displayed at the end of the diagnostic message, not on a line of its own after the snippet.	2025-08-01 01:24:31 +00:00
Richard Smith	a6f5143f22	Fix diagnostic for access of protected/private base member. (#5874) ... When importing the member, import the access level for the lookup result, not the declared access of the member declaration.	2025-07-30 17:17:09 +00:00
Boaz Brickner	30f0ddab71	Add support for importing access from C++ to Carbon (#5858) ... Better access control with inheritance should come with better inheritance support (actually importing inheritance). C++ Interop Demo: ```c++ // hello_world.h class HelloWorld { public: static auto Pub() -> void; protected: static auto Pro() -> void; private: static auto Pri() -> void; }; ``` ```c++ // hello_world.cpp #include "hello_world.h" #include <cstdio> auto HelloWorld::Pub() -> void { printf("Public!\n"); } auto HelloWorld::Pro() -> void { printf("Protected!\n"); } auto HelloWorld::Pri() -> void { printf("Private!\n"); } ``` ```carbon // main.carbon library "Main"; import Cpp library "hello_world.h"; fn Run() -> i32 { Cpp.HelloWorld.Pub(); Cpp.HelloWorld.Pro(); Cpp.HelloWorld.Pri(); return 0; } ``` ```shell $ clang -c hello_world.cpp $ bazel-bin/toolchain/carbon compile main.carbon main.carbon:9:3: error: cannot access protected member `Pro` of type `Cpp.HelloWorld` Cpp.HelloWorld.Pro(); ^~~~~~~~~~~~~~~~~~ main.carbon: note: declared here main.carbon:10:3: error: cannot access private member `Pri` of type `Cpp.HelloWorld` Cpp.HelloWorld.Pri(); ^~~~~~~~~~~~~~~~~~ main.carbon: note: declared here ``` Before this change (no access checks): ```shell $ bazel-bin/toolchain/carbon compile main.carbon $ bazel-bin/toolchain/carbon link hello_world.o main.o --output=demo $ ./demo Public! Protected! Private! ``` Part of #5859.	2025-07-29 08:25:15 +00:00