Use llvm:: for specializations instead of 'namespace llvm' (#3682)

We already do this with things like llvm::DenseMapInfo, I don't know why
I was doing this with format_provider. But this should be more
consistent, and slightly better for not entering another library's
namespace.
This commit is contained in:
Jon Ross-Perkins
2024-02-01 22:58:04 +00:00
committed by GitHub
parent 03bf22e55e
commit ee467900ed
3 changed files with 3 additions and 15 deletions
+1 -5
View File
@@ -12,12 +12,10 @@
#include "toolchain/lex/character_set.h"
#include "toolchain/lex/helpers.h"
namespace llvm {
// We use formatv primarily for diagnostics. In these cases, it's expected that
// the spelling in source code should be used.
template <>
struct format_provider<Carbon::Lex::NumericLiteral::Radix> {
struct llvm::format_provider<Carbon::Lex::NumericLiteral::Radix> {
using Radix = Carbon::Lex::NumericLiteral::Radix;
static void format(const Radix& radix, raw_ostream& out,
StringRef /*style*/) {
@@ -35,8 +33,6 @@ struct format_provider<Carbon::Lex::NumericLiteral::Radix> {
}
};
} // namespace llvm
namespace Carbon::Lex {
auto NumericLiteral::Lex(llvm::StringRef source_text)
+1 -5
View File
@@ -133,12 +133,10 @@ constexpr llvm::ArrayRef<TokenKind> TokenKind::KeywordTokens =
} // namespace Carbon::Lex
namespace llvm {
// We use formatv primarily for diagnostics. In these cases, it's expected that
// the spelling in source code should be used.
template <>
struct format_provider<Carbon::Lex::TokenKind> {
struct llvm::format_provider<Carbon::Lex::TokenKind> {
static void format(const Carbon::Lex::TokenKind& kind, raw_ostream& out,
StringRef /*style*/) {
auto spelling = kind.fixed_spelling();
@@ -151,6 +149,4 @@ struct format_provider<Carbon::Lex::TokenKind> {
}
};
} // namespace llvm
#endif // CARBON_TOOLCHAIN_LEX_TOKEN_KIND_H_
+1 -5
View File
@@ -25,11 +25,9 @@ enum class RelativeLocation : int8_t {
} // namespace Carbon::Parse
namespace llvm {
// Adapts RelativeLocation for use with formatv.
template <>
struct format_provider<Carbon::Parse::RelativeLocation> {
struct llvm::format_provider<Carbon::Parse::RelativeLocation> {
using RelativeLocation = Carbon::Parse::RelativeLocation;
static void format(const RelativeLocation& loc, raw_ostream& out,
StringRef /*style*/) {
@@ -47,8 +45,6 @@ struct format_provider<Carbon::Parse::RelativeLocation> {
}
};
} // namespace llvm
namespace Carbon::Parse {
Context::Context(Tree& tree, Lex::TokenizedBuffer& tokens,