carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix diagnostic messages that don't end in a period. (#3127)

Browse Source
This commit is contained in:
Richard Smith
2023-08-21 23:59:18 +00:00
committed by GitHub
parent d3ac21195c
commit d74b8f0497
10 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/semantics_context.cpp
+3 -2
View File
@@ -44,7 +44,8 @@ SemanticsContext::SemanticsContext(const TokenizedBuffer& tokens,
auto SemanticsContext::TODO(ParseTree::Node parse_node, std::string label)
-> bool {
CARBON_DIAGNOSTIC(SemanticsTodo, Error, "Semantics TODO: {0}", std::string);
CARBON_DIAGNOSTIC(SemanticsTodo, Error, "Semantics TODO: `{0}`.",
std::string);
emitter_->Emit(parse_node, SemanticsTodo, std::move(label));
return false;
}
@@ -91,7 +92,7 @@ auto SemanticsContext::DiagnoseDuplicateName(ParseTree::Node parse_node,
auto SemanticsContext::DiagnoseNameNotFound(ParseTree::Node parse_node,
SemanticsStringId name_id) -> void {
CARBON_DIAGNOSTIC(NameNotFound, Error, "Name `{0}` not found",
CARBON_DIAGNOSTIC(NameNotFound, Error, "Name `{0}` not found.",
llvm::StringRef);
emitter_->Emit(parse_node, NameNotFound, semantics_ir_->GetString(name_id));
}
toolchain/semantics/testdata/array/fail_undefined_bound.carbon
Vendored
+1 -1
View File
@@ -4,7 +4,7 @@
//
// AUTOUPDATE
// CHECK:STDERR: fail_undefined_bound.carbon:[[@LINE+3]]:14: Semantics TODO: HandleArrayExpressionWithoutBounds
// CHECK:STDERR: fail_undefined_bound.carbon:[[@LINE+3]]:14: Semantics TODO: `HandleArrayExpressionWithoutBounds`.
// CHECK:STDERR: var a: [i32; ];
// CHECK:STDERR: ^
var a: [i32; ];
toolchain/semantics/testdata/basics/fail_name_lookup.carbon
Vendored
+1 -1
View File
@@ -5,7 +5,7 @@
// AUTOUPDATE
fn Main() {
// CHECK:STDERR: fail_name_lookup.carbon:[[@LINE+3]]:3: Name `x` not found
// CHECK:STDERR: fail_name_lookup.carbon:[[@LINE+3]]:3: Name `x` not found.
// CHECK:STDERR: x;
// CHECK:STDERR: ^
x;
toolchain/semantics/testdata/if/fail_scope.carbon
Vendored
+1 -1
View File
@@ -9,7 +9,7 @@ fn VarScope(b: bool) -> i32 {
var n: i32 = 2;
return n;
}
// CHECK:STDERR: fail_scope.carbon:[[@LINE+3]]:10: Name `n` not found
// CHECK:STDERR: fail_scope.carbon:[[@LINE+3]]:10: Name `n` not found.
// CHECK:STDERR: return n;
// CHECK:STDERR: ^
return n;
toolchain/semantics/testdata/index/fail_name_not_found.carbon
Vendored
+1 -1
View File
@@ -5,7 +5,7 @@
// AUTOUPDATE
fn Main() {
// CHECK:STDERR: fail_name_not_found.carbon:[[@LINE+3]]:16: Name `a` not found
// CHECK:STDERR: fail_name_not_found.carbon:[[@LINE+3]]:16: Name `a` not found.
// CHECK:STDERR: var b: i32 = a[0];
// CHECK:STDERR: ^
var b: i32 = a[0];
toolchain/semantics/testdata/index/fail_negative_indexing.carbon
Vendored
+1 -1
View File
@@ -5,7 +5,7 @@
// AUTOUPDATE
var a: (i32, i32) = (12, 6);
// CHECK:STDERR: fail_negative_indexing.carbon:[[@LINE+3]]:16: Semantics TODO: Handle -
// CHECK:STDERR: fail_negative_indexing.carbon:[[@LINE+3]]:16: Semantics TODO: `Handle -`.
// CHECK:STDERR: var b: i32 = a[-10];
// CHECK:STDERR: ^
var b: i32 = a[-10];
toolchain/semantics/testdata/namespace/fail_unresolved_scope.carbon
Vendored
+1 -1
View File
@@ -4,7 +4,7 @@
//
// AUTOUPDATE
// CHECK:STDERR: fail_unresolved_scope.carbon:[[@LINE+3]]:4: Name `Foo` not found
// CHECK:STDERR: fail_unresolved_scope.carbon:[[@LINE+3]]:4: Name `Foo` not found.
// CHECK:STDERR: fn Foo.Baz() {
// CHECK:STDERR: ^
fn Foo.Baz() {
toolchain/semantics/testdata/struct/fail_access_into_invalid.carbon
Vendored
+1 -1
View File
@@ -5,7 +5,7 @@
// AUTOUPDATE
// CHECK:STDERR: fail_access_into_invalid.carbon:[[@LINE+3]]:10: Name `a` not found
// CHECK:STDERR: fail_access_into_invalid.carbon:[[@LINE+3]]:10: Name `a` not found.
// CHECK:STDERR: fn F() { a.b; }
// CHECK:STDERR: ^
fn F() { a.b; }
toolchain/semantics/testdata/var/fail_init_with_self.carbon
Vendored
+1 -1
View File
@@ -5,7 +5,7 @@
// AUTOUPDATE
fn Main() {
// CHECK:STDERR: fail_init_with_self.carbon:[[@LINE+3]]:16: Name `x` not found
// CHECK:STDERR: fail_init_with_self.carbon:[[@LINE+3]]:16: Name `x` not found.
// CHECK:STDERR: var x: i32 = x;
// CHECK:STDERR: ^
var x: i32 = x;
toolchain/semantics/testdata/var/fail_lookup_outside_scope.carbon
Vendored
+1 -1
View File
@@ -8,7 +8,7 @@ fn Main() {
var x: i32;
}
// CHECK:STDERR: fail_lookup_outside_scope.carbon:[[@LINE+3]]:14: Name `x` not found
// CHECK:STDERR: fail_lookup_outside_scope.carbon:[[@LINE+3]]:14: Name `x` not found.
// CHECK:STDERR: var y: i32 = x;
// CHECK:STDERR: ^
var y: i32 = x;