carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 08:51:04 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Flip the dump-sem-ir-ranges default in file_test (#5587)

Browse Source 
This doesn't remove no-longer-needed flags; I'll do that in a separate
PR after this is merged.

---------

Co-authored-by: Dana Jansens <danakj@orodu.net>
This commit is contained in:
Jon Ross-Perkins
2025-06-03 17:37:51 +00:00
committed by GitHub
co-authored by Dana Jansens
parent 1899a6b285
commit d0a48504d8
4 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/testdata/basics/no_prelude/dump_sem_ir_ranges.carbon
Vendored
+4 -1
View File
@@ -2,7 +2,10 @@
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// The default behavior should be `--dump-sem-ir-ranges=if-present`.
// The default behavior should be `--dump-sem-ir-ranges=if-present`, although
// tests set it to `only`. This explicitly tests the default of the toolchain,
// not of file_test.
// ARGS: compile --phase=check --no-prelude-import --dump-sem-ir %s
//
// AUTOUPDATE
// TIP: To test this file alone, run:
toolchain/check/testdata/basics/no_prelude/dump_sem_ir_ranges_only.carbon
Vendored
+2 -1
View File
@@ -2,7 +2,8 @@
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// EXTRA-ARGS: --dump-sem-ir-ranges=only
// This tests `--dump-sem-ir-range=only` behavior, which is set implicitly by
// file_test.
//
// AUTOUPDATE
// TIP: To test this file alone, run:
toolchain/check/testdata/packages/implicit_imports_prelude.carbon
Vendored
+3
View File
@@ -4,6 +4,9 @@
//
// This is just checking an implicit import behavior with the prelude present.
//
// TODO: Add ranges and switch to "--dump-sem-ir-ranges=only".
// EXTRA-ARGS: --dump-sem-ir-ranges=if-present
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/packages/implicit_imports_prelude.carbon
toolchain/testing/file_test.cpp
+1 -1
View File
@@ -192,7 +192,7 @@ auto ToolchainFileTest::GetDefaultArgs() const
} else if (component_ == "parse") {
args.push_back("--dump-parse-tree");
} else if (component_ == "check") {
args.push_back("--dump-sem-ir");
args.insert(args.end(), {"--dump-sem-ir", "--dump-sem-ir-ranges=only"});
} else if (component_ == "lower") {
args.insert(args.end(), {"--dump-llvm-ir", "--target=x86_64-linux-gnu"});
} else {