carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 19:50:14 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Avoid extra work when thunk_required is already true in IsCppThunkRequired() (#6150)

Browse Source 
Also set `thunk_required` in a more consistent way, to avoid bugs like
the one fixed in #6152.

Part #6148.
This commit is contained in:
Boaz Brickner
2025-10-02 19:11:31 +00:00
committed by GitHub
parent 0c761a9a78
commit ce6bf91a83
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/cpp/thunk.cpp
+4 -5
View File
@@ -110,6 +110,7 @@ auto IsCppThunkRequired(Context& context, const SemIR::Function& function)
for (auto* param : decl->parameters()) {
if (param->getType()->isReferenceType()) {
thunk_required = true;
break;
}
}
}
@@ -129,12 +130,10 @@ auto IsCppThunkRequired(Context& context, const SemIR::Function& function)
if (param_id == SemIR::ErrorInst::InstId) {
return false;
}
if (!thunk_required &&
thunk_required =
thunk_required ||
IsThunkRequiredForType(
context,
context.insts().GetAs<SemIR::AnyParam>(param_id).type_id)) {
thunk_required = true;
}
context, context.insts().GetAs<SemIR::AnyParam>(param_id).type_id);
}
return thunk_required;