carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 10:54:49 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Switch benchmarks to match unit test namespacing. (#3268)

Browse Source 
Specifically, rather than nesting them in `Carbon::Testing`, nest them
in `Carbon::Foo` for whatever component they're benchmarking. All our
current benchmarks are lexer benchmarks so its `Carbon::Lex`.

This makes even more sense for benchmarks than unittests I think.
This commit is contained in:
Chandler Carruth
2023-10-05 17:44:31 +00:00
committed by GitHub
parent 7dfd7ca3b4
commit b8802035ed
3 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lex/numeric_literal_benchmark.cpp
+2 -4
View File
@@ -8,11 +8,9 @@
#include "toolchain/diagnostics/null_diagnostics.h"
#include "toolchain/lex/numeric_literal.h"
namespace Carbon::Testing {
namespace Carbon::Lex {
namespace {
using Lex::NumericLiteral;
static void BM_Lex_Float(benchmark::State& state) {
for (auto _ : state) {
CARBON_CHECK(NumericLiteral::Lex("0.000001"));
@@ -49,4 +47,4 @@ BENCHMARK(BM_ComputeValue_Float);
BENCHMARK(BM_ComputeValue_Integer);
} // namespace
} // namespace Carbon::Testing
} // namespace Carbon::Lex
toolchain/lex/string_literal_benchmark.cpp
+2 -4
View File
@@ -7,11 +7,9 @@
#include "toolchain/diagnostics/null_diagnostics.h"
#include "toolchain/lex/string_literal.h"
namespace Carbon::Testing {
namespace Carbon::Lex {
namespace {
using Lex::StringLiteral;
static void BM_ValidString(benchmark::State& state, std::string_view introducer,
std::string_view terminator) {
std::string x(introducer);
@@ -117,4 +115,4 @@ BENCHMARK(BM_SimpleStringValue_MultilineDoubleQuote);
BENCHMARK(BM_SimpleStringValue_Raw);
} // namespace
} // namespace Carbon::Testing
} // namespace Carbon::Lex
toolchain/lex/tokenized_buffer_benchmark.cpp
+2 -5
View File
@@ -15,12 +15,9 @@
#include "toolchain/lex/token_kind.h"
#include "toolchain/lex/tokenized_buffer.h"
namespace Carbon::Testing {
namespace Carbon::Lex {
namespace {
using Lex::TokenizedBuffer;
using Lex::TokenKind;
// A large value for measurement stability without making benchmarking too slow.
// Needs to be a multiple of 100 so we can easily divide it up into percentages,
// and 1% itself needs to not be too tiny. This makes 100,000 a great balance.
@@ -383,4 +380,4 @@ BENCHMARK(BM_ValidMix)
->Args({75, 10});
} // namespace
} // namespace Carbon::Testing
} // namespace Carbon::Lex