carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 21:30:12 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix a compilation error with a recent Clang (#5170)

Browse Source 
This fixes a `copy constructor must pass its first argument by
reference` compilation error when compiled with a recent enough Clang
(after
https://github.com/llvm/llvm-project/commit/fe0d3e3764961b62f43f1b129f30aaec5f30bc16,
targeted for LLVM 21 release).

```
carbon/lang/common/set.h:81:59: error: copy constructor must pass its first argument by reference
   81 |   SetView(SetView<std::remove_const_t<KeyT>, KeyContextT> other_view)
      |                                                           ^
```
This commit is contained in:
Alexander Kornienko
2025-03-24 15:45:45 +00:00
committed by GitHub
parent ce2ff0a35d
commit b3c7a7e988
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/set.h
+2 -1
View File
@@ -6,6 +6,7 @@
#define CARBON_COMMON_SET_H_
#include <concepts>
#include <type_traits>
#include "common/check.h"
#include "common/hashtable_key_context.h"
@@ -78,7 +79,7 @@ class SetView : RawHashtable::ViewImpl<InputKeyT, void, InputKeyContextT> {
// Enable implicit conversions that add `const`-ness to the key type.
// NOLINTNEXTLINE(google-explicit-constructor)
SetView(SetView<std::remove_const_t<KeyT>, KeyContextT> other_view)
SetView(const SetView<std::remove_const_t<KeyT>, KeyContextT>& other_view)
requires(!std::same_as<KeyT, std::remove_const_t<KeyT>>)
: ImplT(other_view) {}