carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 13:01:04 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Simplify logic a little. (#7153)

Browse Source 
Also preserve the error state rather than overriding it, though this
doesn't seem to make a difference in practice.

Assisted-by: Gemini via Antigravity
This commit is contained in:
Richard Smith
2026-05-01 18:41:33 +00:00
committed by GitHub
parent 364aa4d1ea
commit aebd7f9d7f
1 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/call.cpp
+6 -15
View File
@@ -248,21 +248,12 @@ auto PerformCallToFunction(Context& context, SemIR::LocId loc_id,
context, loc_id, callee.return_pattern_id, *callee_specific_id);
if (arg_type_id == SemIR::ErrorInst::TypeId) {
return_type_id = SemIR::ErrorInst::TypeId;
}
switch (SemIR::InitRepr::ForType(context.sem_ir(), arg_type_id).kind) {
case SemIR::InitRepr::InPlace:
case SemIR::InitRepr::Dependent:
// Tentatively use storage for a temporary as the return argument.
// This will be replaced if necessary when we perform initialization.
return_arg_id = AddInst<SemIR::TemporaryStorage>(
context, loc_id, {.type_id = arg_type_id});
break;
case SemIR::InitRepr::None:
case SemIR::InitRepr::ByCopy:
case SemIR::InitRepr::Incomplete:
case SemIR::InitRepr::Abstract:
return_arg_id = SemIR::InstId::None;
break;
} else if (SemIR::InitRepr::ForType(context.sem_ir(), arg_type_id)
.MightBeInPlace()) {
// Tentatively use storage for a temporary as the return argument.
// This will be replaced if necessary when we perform initialization.
return_arg_id = AddInst<SemIR::TemporaryStorage>(
context, loc_id, {.type_id = arg_type_id});
}
}
// Convert the arguments to match the parameters.