carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 21:40:12 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix a fuzzer-found crash. (#2930)

Browse Source 
The crash occurred because of an alias target of a mixin. While
eventually, we should probably have some ability to alias mixins, this
isn't yet setup in the explorer and doesn't seem like a current
priority.

We got here because the mixin type checking made it far enough to not
reject this within the type checker, but the next step wasn't prepared
for this to come out of the type checker. The simplest fix seems to be
to reflect that it *can* escape the type checker, but still isn't (yet)
a valid alias target.

Test case added.
This commit is contained in:
Chandler Carruth
2023-06-20 12:32:58 -07:00
committed by GitHub
parent 1b50bd156c
commit abecb25185
2 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/interpreter/type_checker.cpp
+3 -3
View File
@@ -6168,7 +6168,6 @@ static auto IsValidTypeForAliasTarget(Nonnull<const Value*> type) -> bool {
case Value::Kind::StructValue:
case Value::Kind::NominalClassValue:
case Value::Kind::MixinPseudoType:
case Value::Kind::TypeOfMixinPseudoType:
case Value::Kind::AlternativeValue:
case Value::Kind::TupleValue:
case Value::Kind::ImplWitness:
@@ -6182,11 +6181,11 @@ static auto IsValidTypeForAliasTarget(Nonnull<const Value*> type) -> bool {
case Value::Kind::AlternativeConstructorValue:
case Value::Kind::StringValue:
case Value::Kind::UninitializedValue:
CARBON_FATAL() << "type of alias target is not a type";
CARBON_FATAL() << "type of alias target is not a type: " << *type;
case Value::Kind::AutoType:
case Value::Kind::VariableType:
CARBON_FATAL() << "pattern type in alias target";
CARBON_FATAL() << "pattern type in alias target: " << *type;
case Value::Kind::IntType:
case Value::Kind::BoolType:
@@ -6198,6 +6197,7 @@ static auto IsValidTypeForAliasTarget(Nonnull<const Value*> type) -> bool {
case Value::Kind::ChoiceType:
case Value::Kind::StringType:
case Value::Kind::AssociatedConstant:
case Value::Kind::TypeOfMixinPseudoType:
return false;
case Value::Kind::FunctionType:
explorer/testdata/mixin/fail_mix_as_alias_target.carbon
Vendored
+16
View File
@@ -0,0 +1,16 @@
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// AUTOUPDATE
package ExplorerTest api;
__mixin Operations {}
// CHECK:STDERR: COMPILATION ERROR: fail_mix_as_alias_target.carbon:[[@LINE+1]]: invalid target for alias declaration
alias OperationsAlias = Operations;
fn Main() -> i32 {
return 0;
}