carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 06:54:44 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix short option error (#4796)

Browse Source 
"unsigned char" prints as an integer, not a char

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
This commit is contained in:
Jon Ross-Perkins
2025-01-14 00:44:41 +00:00
committed by GitHub
co-authored by Richard Smith
parent 2faff26f92
commit a3e66d6116
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/command_line.cpp
+2 -1
View File
@@ -1039,7 +1039,8 @@ auto Parser::ParseShortOptionSeq(llvm::StringRef unparsed_arg)
auto* arg_entry =
(c < short_option_table_.size()) ? short_option_table_[c] : nullptr;
if (!arg_entry) {
return Error(llvm::formatv("unknown short option `{0}`", c));
return Error(
llvm::formatv("unknown short option `-{0}`", static_cast<char>(c)));
}
// Mark this argument as parsed.
arg_entry->setInt(true);
common/command_line_test.cpp
+4
View File
@@ -188,6 +188,10 @@ TEST(ArgParserTest, ShortArgs) {
EXPECT_THAT(integer_option, Eq(123));
TestRawOstream os;
EXPECT_THAT(parse({"-v"}, os), IsError(StrEq("unknown short option `-v`")));
EXPECT_THAT(parse({"-xvx"}, os), IsError(StrEq("unknown short option `-v`")));
EXPECT_THAT(
parse({"-xzf"}, os),
IsError(StrEq("option `-z` (short for `--option2`) requires a value to "