carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 08:44:41 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

[SVE] Fix warnings in SelectInst::areInvalidOperands

Browse Source 
We should be comparing the element counts rather than the
numbers of elements.

Differential Revision: https://reviews.llvm.org/D80634
This commit is contained in:
David Sherwood
2020-05-29 07:50:47 +01:00
parent b147b88c84
commit 9c0ef044be
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
llvm/lib/IR/Instructions.cpp
+1 -1
View File
@@ -81,7 +81,7 @@ const char *SelectInst::areInvalidOperands(Value *Op0, Value *Op1, Value *Op2) {
VectorType *ET = dyn_cast<VectorType>(Op1->getType());
if (!ET)
return "selected values for vector select must be vectors";
if (ET->getNumElements() != VT->getNumElements())
if (ET->getElementCount() != VT->getElementCount())
return "vector select requires selected vectors to have "
"the same vector length as select condition";
} else if (Op0->getType() != Type::getInt1Ty(Op0->getContext())) {
llvm/test/CodeGen/AArch64/sve-bad-select.ll
+10
View File
@@ -0,0 +1,10 @@
; RUN: not llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s 2>&1 | FileCheck %s
define <vscale x 16 x i8> @badsel1_nxv16i8(<16 x i1> %p,
<vscale x 16 x i8> %dst,
<vscale x 16 x i8> %a) {
%sel = select <16 x i1> %p, <vscale x 16 x i8> %a, <vscale x 16 x i8> %dst
ret <vscale x 16 x i8> %sel
}
; CHECK: error: vector select requires selected vectors to have the same vector length as select condition