carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 18:30:30 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Disable bugprone-easily-swappable-parameters (#941)

Browse Source 
This warning is looking low value; for example:

```
/usr/local/google/home/jperkins/dev/carbon-lang/executable_semantics/interpreter/value.h:199:21: warning: 2 adjacent parameters of 'NominalClassValue' of similar type ('Nonnull<const Carbon::Value *>') are easily swapped by mistake [bugprone-easily-swappable-parameters]
  NominalClassValue(Nonnull<const Value*> type, Nonnull<const Value*> inits)
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/google/home/jperkins/dev/carbon-lang/executable_semantics/interpreter/value.h:199:43: note: the first parameter in the range is 'type'
  NominalClassValue(Nonnull<const Value*> type, Nonnull<const Value*> inits)
                                          ^~~~
/usr/local/google/home/jperkins/dev/carbon-lang/executable_semantics/interpreter/value.h:199:71: note: the last parameter in the range is 'inits'
  NominalClassValue(Nonnull<const Value*> type, Nonnull<const Value*> inits)
                                                                      ^~~~~
```
This commit is contained in:
Jon Meow
2021-11-03 08:03:09 -07:00
committed by GitHub
parent 5f67029479
commit 82a870cfcd
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.clang-tidy
+9 -8
View File
@@ -8,14 +8,15 @@
# - performance-unnecessary-value-param is disabled because it duplicate
# modernize-pass-by-value.
Checks:
-*, bugprone-*, -bugprone-narrowing-conversions, google-*,
-google-readability-todo, misc-definitions-in-headers, misc-misplaced-const,
misc-redundant-expression, misc-static-assert,
misc-unconventional-assign-operator, misc-uniqueptr-reset-release,
misc-unused-*, modernize-*, -modernize-avoid-c-arrays,
-modernize-use-default-member-init, -modernize-use-emplace,
-modernize-use-nodiscard, performance-*, -performance-unnecessary-value-param,
readability-braces-around-statements, readability-identifier-naming
-*, bugprone-*, -bugprone-easily-swappable-parameters,
-bugprone-narrowing-conversions, google-*, -google-readability-todo,
misc-definitions-in-headers, misc-misplaced-const, misc-redundant-expression,
misc-static-assert, misc-unconventional-assign-operator,
misc-uniqueptr-reset-release, misc-unused-*, modernize-*,
-modernize-avoid-c-arrays, -modernize-use-default-member-init,
-modernize-use-emplace, -modernize-use-nodiscard, performance-*,
-performance-unnecessary-value-param, readability-braces-around-statements,
readability-identifier-naming
WarningsAsErrors: true
CheckOptions:
- { key: readability-identifier-naming.ClassCase, value: CamelCase }