carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 21:00:13 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Mention the RFC project column in docs (#688)

Browse Source 
Nothing is automating "ready for review" unfortunately, but the lack of RFC mention seems like a clear miss.
This commit is contained in:
Jon Meow
2021-07-29 10:57:21 -07:00
committed by GitHub
parent a930717202
commit 61abc44aef
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/project/evolution.md
+14 -3
View File
@@ -65,8 +65,11 @@ language are well explained, justified, and reviewed by the community.
[the template](/proposals/template.md).
- Proposal PRs start out in draft mode. When proposal PRs are ready, click on
["Ready for review"](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review)
in GitHub.
["Ready for review"](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review),
and change the
[Proposals project column](https://github.com/carbon-language/carbon-lang/projects/1)
to "RFC". The project column should be available as a dropdown under
"Projects" on the PR.
- This will result in a Carbon lead being assigned to review the PR.
@@ -129,12 +132,20 @@ issues for longer discussion:
- When ready, click on
["Ready for review"](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review)
in GitHub.
in GitHub, and change the
[Proposals project column](https://github.com/carbon-language/carbon-lang/projects/1)
to "RFC". The project column should be available as a dropdown under
"Projects" on the PR.
- This will result in the PR being assigned to an individual for review.
- This will also send the proposal as a broad RFC to the community.
- While setting the "RFC" project column will also add the "RFC" label,
the reverse is not true. Unfortunately, this is currently a limit of
GitHub automation. Similarly, Adding the "RFC" project column currently
does not set "Ready for review".
- Address comments where you can and they make sense.
- If you don't see an obvious way to address comments, that's OK.