carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 19:10:14 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix the hardening mode defines, also use debug (#5666)

Browse Source 
This is based on #5664 because it's fixing an issue which `DEBUG` would
catch. That's also why I'm switching to `DEBUG` from `EXTENSIVE`; I
think we should be okay with the performance cost in `file_test`, which
is probably our main concern.

Note digging into this also got me to notice that the flags weren't
actually enabled; this is fixing the define names.

---------

Co-authored-by: Dana Jansens <danakj@orodu.net>
This commit is contained in:
Jon Ross-Perkins
2025-06-13 21:18:17 +00:00
committed by GitHub
co-authored by Dana Jansens
parent 3b7dc79796
commit 5196d1eb27
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bazel/cc_toolchains/clang_cc_toolchain_config.bzl
+4 -4
View File
@@ -653,13 +653,13 @@ def _impl(ctx):
)],
)
# Clang HARDENED_MODE has 4 possible values:
# https://releases.llvm.org/18.1.0/projects/libcxx/docs/Hardening.html#hardening-modes
# Clang HARDENING_MODE has 4 possible values:
# https://libcxx.llvm.org/Hardening.html#notes-for-users
libcpp_debug_flags = [
"-D_LIBCPP_ENABLE_HARDENED_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE",
"-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG",
]
libcpp_release_flags = [
"-D_LIBCPP_ENABLE_HARDENED_MODE=_LIBCPP_HARDENING_MODE_FAST",
"-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST",
]
linux_flags_feature = feature(