carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 19:50:14 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Replace convert_checked with convert in some ImplicitAs impls (#6704)

Browse Source 
`convert_checked` is for conversions that are checked at compile time.
Since these conversions do not require a constant value they should use
`checked` instead.

(Split out from
https://github.com/carbon-language/carbon-lang/pull/6673, explanation of
convert/convert_checked derived from the [Jan 20, 2026 meeting
notes](https://docs.google.com/document/d/1YlxEOJ0r-o19o19TCJbFl4Ln1U88yn_Vj23y1Hr5vTk/edit?tab=t.tjeylv584s7j#heading=h.ih31dlc0ma58).)
This commit is contained in:
Nicholas Bishop
2026-02-06 21:50:59 +00:00
committed by GitHub
parent 70614da67e
commit 1382a8645a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/prelude/types/cpp/int.carbon
+2 -2
View File
@@ -93,7 +93,7 @@ final impl CppCompat.ULong32 as ImplicitAs(IntLiteral()) {
// TODO: ImplicitAs from UInt(N) to ULong32 if N < 32.
impl u32 as ImplicitAs(CppCompat.ULong32) {
fn Convert[self: Self]() -> CppCompat.ULong32 = "int.convert_checked";
fn Convert[self: Self]() -> CppCompat.ULong32 = "int.convert";
}
// TODO: ImplicitAs from ULong32 to UInt(N) if N > 32.
@@ -142,7 +142,7 @@ final impl CppCompat.ULongLong64 as ImplicitAs(IntLiteral()) {
// TODO: ImplicitAs from UInt(N) to ULongLong64 if N < 64.
impl u64 as ImplicitAs(CppCompat.ULongLong64) {
fn Convert[self: Self]() -> CppCompat.ULongLong64 = "int.convert_checked";
fn Convert[self: Self]() -> CppCompat.ULongLong64 = "int.convert";
}
// TODO: ImplicitAs from ULongLong64 to UInt(N) if N > 64.