mirror of
https://github.com/calibrain/shelfmark.git
synced 2026-10-05 18:51:05 +01:00
CaliBrain
ff06a1a581
Review follow-ups to #1255, all in the code that PR touched. Drop the dead user_id from the Prowlarr retry path. ProwlarrSource.search never reads plan.languages, and _refresh_release builds a synthetic book with no titles_by_language, so the title variants came out identical with and without it. It also should not language-filter: it re-finds one exact release by its guid. Pin the tab move in tests. BOOK_LANGUAGE moved from the General tab to Search Mode with no migration, which only works because both tabs persist into the same settings.json. Nothing asserted that, so splitting the files later would silently reset every install to ["en"]. Covers the stored value, a fresh install, and ENV precedence. Stop the UI inventing a default language. An empty BOOK_LANGUAGE is a deliberate "no default filter" that the backend preserves, but the two frontend call sites replaced it with the first supported language, so the filter said English where the server filtered nothing. resolveDefaultLanguageCodes now falls back only when the value is absent. Keep the normalized value for every validated search key. validate_user_settings gated the write-back on a hand-maintained subset of the keys the search validator recognises, so METADATA_PROVIDER_COMBINED, SHOW_COMBINED_SELECTOR and FORCE_COMBINED_SEARCH were validated and then stored raw -- a padded provider name was accepted and persisted with its padding. Reuse the validator's own key set instead. Skip blank language entries rather than rejecting them, so "" and "en," mean the same as [] and ["en"] instead of erroring on an unnamed language. Extract resolveListOverride for the list-override detection that was copy-pasted between the two user-settings sections, and mention languages in the Search Preferences section description.
77 lines
2.9 KiB
Python
77 lines
2.9 KiB
Python
"""Tests for search mode settings definitions."""
|
|
|
|
import json
|
|
|
|
import pytest
|
|
|
|
from shelfmark.config.settings import search_mode_settings
|
|
|
|
|
|
def _search_mode_field(key: str):
|
|
fields = {field.key: field for field in search_mode_settings() if hasattr(field, "key")}
|
|
return fields[key]
|
|
|
|
|
|
def test_search_mode_settings_include_release_source_links_toggle():
|
|
fields = {field.key: field for field in search_mode_settings() if hasattr(field, "key")}
|
|
|
|
field = fields["SHOW_RELEASE_SOURCE_LINKS"]
|
|
|
|
assert field.label == "Show Release Source Links"
|
|
assert field.default is True
|
|
assert field.user_overridable is False
|
|
|
|
|
|
def test_book_language_is_user_overridable():
|
|
fields = {field.key: field for field in search_mode_settings() if hasattr(field, "key")}
|
|
|
|
field = fields["BOOK_LANGUAGE"]
|
|
|
|
assert field.label == "Default Book Languages"
|
|
assert field.default == ["en"]
|
|
assert field.user_overridable is True
|
|
|
|
|
|
def test_book_language_stored_under_the_general_tab_still_resolves(tmp_path):
|
|
"""BOOK_LANGUAGE moved from the General tab to Search Mode with no migration.
|
|
|
|
That is only safe because both tabs persist into the same settings.json, so an
|
|
install that stored the value while the field lived on General keeps it. If the
|
|
two tabs ever get separate files, every existing install silently falls back to
|
|
the ["en"] default instead.
|
|
"""
|
|
from shelfmark.core.settings_registry import _get_config_file_path, get_setting_value
|
|
|
|
(tmp_path / "settings.json").write_text(json.dumps({"BOOK_LANGUAGE": ["de", "fr"]}))
|
|
|
|
with pytest.MonkeyPatch.context() as monkeypatch:
|
|
monkeypatch.delenv("BOOK_LANGUAGE", raising=False)
|
|
monkeypatch.setattr("shelfmark.config.env.CONFIG_DIR", tmp_path)
|
|
|
|
assert _get_config_file_path("search_mode") == _get_config_file_path("general")
|
|
assert get_setting_value(_search_mode_field("BOOK_LANGUAGE"), "search_mode") == ["de", "fr"]
|
|
|
|
|
|
def test_book_language_uses_its_default_on_a_fresh_install(tmp_path):
|
|
from shelfmark.core.settings_registry import get_setting_value
|
|
|
|
with pytest.MonkeyPatch.context() as monkeypatch:
|
|
monkeypatch.delenv("BOOK_LANGUAGE", raising=False)
|
|
monkeypatch.setattr("shelfmark.config.env.CONFIG_DIR", tmp_path)
|
|
|
|
assert get_setting_value(_search_mode_field("BOOK_LANGUAGE"), "search_mode") == ["en"]
|
|
|
|
|
|
def test_book_language_env_var_beats_the_stored_value(tmp_path):
|
|
from shelfmark.core.settings_registry import get_setting_value, is_value_from_env
|
|
|
|
(tmp_path / "settings.json").write_text(json.dumps({"BOOK_LANGUAGE": ["de", "fr"]}))
|
|
field = _search_mode_field("BOOK_LANGUAGE")
|
|
|
|
with pytest.MonkeyPatch.context() as monkeypatch:
|
|
monkeypatch.setenv("BOOK_LANGUAGE", "es,it")
|
|
monkeypatch.setattr("shelfmark.config.env.CONFIG_DIR", tmp_path)
|
|
|
|
assert is_value_from_env(field) is True
|
|
assert get_setting_value(field, "search_mode") == ["es", "it"]
|