mirror of
https://github.com/calibrain/shelfmark.git
synced 2026-11-16 05:28:13 +00:00
ci(jules): review the whole PR diff, not just the latest push (#1529)
jules-pr-reviewer v0.0.2 reviewed only before...head on synchronize. After "Update branch" merged main into fork PRs, that range was main's commits, so of their own changes. v0.0.3 of the calibrain fork always reviews the PR's full diff. Also correct the fork workflow comment: jules-forks has no required reviewers by design, so runs don't wait for approval.
This commit is contained in:
1 parent
c43da4537d
commit
c5af6b9ae6
2 files changed
+6
-6
No files matched your search
@@ -4,9 +4,9 @@ name: Jules PR Review (forks)
|
||||
# That is safe only while nothing here checks out or runs the PR's code: the
|
||||
# action reads the diff through the API. Upstream jules-pr-reviewer refuses
|
||||
# this event, hence the calibrain fork.
|
||||
# Each run waits for a maintainer to approve it on the jules-forks environment
|
||||
# (Settings → Environments → required reviewers), so every fork push is looked
|
||||
# at before Jules reads it, and strangers can't spend the Jules session quota.
|
||||
# The jules-forks environment has no required reviewers on purpose, so fork
|
||||
# pushes are reviewed straight away; adding reviewers there (Settings →
|
||||
# Environments) would make each run wait for a maintainer's approval.
|
||||
on:
|
||||
pull_request_target:
|
||||
types: [opened, synchronize, reopened, ready_for_review]
|
||||
@@ -19,7 +19,7 @@ concurrency:
|
||||
|
||||
jobs:
|
||||
review:
|
||||
# Drafts are skipped here rather than by the action, so they don't ask for approval
|
||||
# Drafts are skipped here rather than by the action, so they never start a job
|
||||
if: github.event.pull_request.head.repo.full_name != github.repository && !github.event.pull_request.draft
|
||||
runs-on: ubuntu-latest
|
||||
environment:
|
||||
@@ -30,7 +30,7 @@ jobs:
|
||||
contents: read
|
||||
checks: write
|
||||
steps:
|
||||
- uses: calibrain/jules-pr-reviewer@9061503ac181f0da714bcfa9f16939dd6148f688 # v0.0.2
|
||||
- uses: calibrain/jules-pr-reviewer@v0.0.3
|
||||
with:
|
||||
jules_api_key: ${{ secrets.JULES_API_KEY }}
|
||||
github_token: ${{ secrets.GITHUB_TOKEN }}
|
||||
|
||||
@@ -21,7 +21,7 @@ jobs:
|
||||
contents: read
|
||||
checks: write
|
||||
steps:
|
||||
- uses: calibrain/jules-pr-reviewer@9061503ac181f0da714bcfa9f16939dd6148f688 # v0.0.2
|
||||
- uses: calibrain/jules-pr-reviewer@v0.0.3
|
||||
with:
|
||||
jules_api_key: ${{ secrets.JULES_API_KEY }}
|
||||
github_token: ${{ secrets.GITHUB_TOKEN }}
|
||||
Reference in new issue
Block a user