From 86943f5a777e196493a0f3c33fd977aab71abc31 Mon Sep 17 00:00:00 2001 From: splitsec2 <35583321+splitsec2@users.noreply.github.com> Date: Wed, 21 Oct 2026 00:30:34 -0600 Subject: [PATCH] chore: drop three unused imports that fail Python Quality (#1514) Python Quality is failing on new PRs because of three unused imports on main (it did on #1513): `ipaddress` in `core/image_cache.py`, `threading` in `core/notifications.py` and `email.utils.parseaddr` in `download/orchestrator.py`. The code that used them changed in the last round of merges and the imports stayed behind. This is `ruff check --fix --select F401` on those three files and nothing else. Ruff, basedpyright and tests/core plus tests/download pass. --- shelfmark/core/image_cache.py | 1 - shelfmark/core/notifications.py | 1 - shelfmark/download/orchestrator.py | 1 - 3 files changed, 3 deletions(-) diff --git a/shelfmark/core/image_cache.py b/shelfmark/core/image_cache.py index 21ea7317..77af1a66 100644 --- a/shelfmark/core/image_cache.py +++ b/shelfmark/core/image_cache.py @@ -1,7 +1,6 @@ """Disk-based image cache with LRU eviction.""" import hashlib -import ipaddress import json import threading import time diff --git a/shelfmark/core/notifications.py b/shelfmark/core/notifications.py index f7f7a6f8..88d6e525 100644 --- a/shelfmark/core/notifications.py +++ b/shelfmark/core/notifications.py @@ -5,7 +5,6 @@ from __future__ import annotations import ipaddress import logging import socket -import threading from concurrent.futures import ThreadPoolExecutor from contextlib import contextmanager, suppress from contextvars import ContextVar diff --git a/shelfmark/download/orchestrator.py b/shelfmark/download/orchestrator.py index 48fc69b6..c0964f89 100644 --- a/shelfmark/download/orchestrator.py +++ b/shelfmark/download/orchestrator.py @@ -9,7 +9,6 @@ import random import threading import time from concurrent.futures import Future, ThreadPoolExecutor -from email.utils import parseaddr from functools import partial from pathlib import Path from threading import Event, Lock