mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-11-16 12:58:04 +00:00
Fix for changing the upstream Host from $host to $forward_host
($http_host) forwards the raw client Host header, including the port and any absolute-form URI mismatch, to every upstream and into the asset cache key
This commit is contained in:
1 parent
99678969b3
commit
fff2b0d097
3 files changed
+16
-6
No files matched your search
@@ -178,7 +178,10 @@ def check_image(image):
|
||||
for authority in authorities:
|
||||
for prefix in ("/", "/custom/"):
|
||||
for method in ("GET", "POST"):
|
||||
origin = f"{scheme}://{authority}"
|
||||
# nginx forwards its normalised (lowercased) $host, as browsers send
|
||||
# in Host and Origin anyway
|
||||
forwarded = authority.lower()
|
||||
origin = f"{scheme}://{forwarded}"
|
||||
referer = origin + "/settings"
|
||||
path = prefix + "apply?one=1&two=2"
|
||||
payload = "rule=example" if method == "POST" else None
|
||||
@@ -190,7 +193,7 @@ def check_image(image):
|
||||
raise AssertionError((authority, path, method, str(error))) from error
|
||||
assert status == 200 and headers.get("Content-Type") == "application/json", (
|
||||
authority, path, method, status, body)
|
||||
assert json.loads(body) == {"host": authority, "origin": origin,
|
||||
assert json.loads(body) == {"host": forwarded, "origin": origin,
|
||||
"referer": referer, "method": method, "path": path,
|
||||
"body": payload or ""}, body
|
||||
checked += 1
|
||||
|
||||
Reference in new issue
Block a user