From 0a96dcad34f3aae9b11df7d53a25fc620551ac5c Mon Sep 17 00:00:00 2001 From: Max G Date: Sat, 11 Jul 2020 13:58:44 +0300 Subject: [PATCH] Use 'with' to not leave a resource open --- updateHostsFile.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/updateHostsFile.py b/updateHostsFile.py index 8eaff1717..a73da4f25 100644 --- a/updateHostsFile.py +++ b/updateHostsFile.py @@ -1483,9 +1483,9 @@ def get_file_by_url(url): """ try: - f = urlopen(url) - soup = BeautifulSoup(f.read(), "lxml").get_text() - return "\n".join(list(map(domain_to_idna, soup.split("\n")))) + with urlopen(url) as f: + soup = BeautifulSoup(f.read(), "lxml").get_text() + return "\n".join(list(map(domain_to_idna, soup.split("\n")))) except Exception: print("Problem getting file: ", url)