mirror of
https://github.com/ThePhaseless/Byparr.git
synced 2026-11-19 21:46:33 +00:00
Root cause of remaining cache misses: the base stage declared
ARG VERSION, and the build job passed VERSION=${{ github.sha }}.
Since VERSION changes every commit, every base/app layer cache key
changed with it — so layers rebuilt every run regardless of scope.
Additionally the test job passed no build-args while the build job
passed GITHUB_BUILD=true + VERSION, so test's cached base/app layers
had different keys from build's — cross-job reuse never hit either.
Fix:
- Dockerfile: move ARG VERSION / ENV VERSION from base to the final
runtime stage (FROM app). VERSION is only read at runtime by
src.consts via Pydantic settings; base/app layers don't use it.
base/app now cache without per-commit VERSION variation.
- workflow: pass --build-arg GITHUB_BUILD=true in the test step so
test and build share identical base/app cache keys (cross-job reuse).
VERSION is intentionally NOT passed to the test job: the test stage
(FROM app AS test) doesn't read VERSION, and omitting it keeps the
base/app cache keys identical between test and build.
66 lines
2.0 KiB
Docker
66 lines
2.0 KiB
Docker
# Ubuntu is required by playwright.
|
|
# Pin to 24.04 LTS: ubuntu:latest floats to 26.04, which Playwright 1.58
|
|
# cannot install firefox deps for (no libgtk-3 -> camoufox fails to launch).
|
|
FROM ubuntu:24.04 AS base
|
|
|
|
ARG GITHUB_BUILD=false
|
|
|
|
ENV GITHUB_BUILD=${GITHUB_BUILD}\
|
|
PYTHONUNBUFFERED=1 \
|
|
# prevents python creating .pyc files
|
|
PYTHONDONTWRITEBYTECODE=1 \
|
|
UV_LINK_MODE=copy \
|
|
PORT=8191 \
|
|
XDG_CACHE_HOME=/cache \
|
|
HOME=/tmp
|
|
|
|
RUN apt-get update &&\
|
|
apt-get install -y --no-install-recommends curl ca-certificates git tini &&\
|
|
apt-get clean &&\
|
|
rm -rf /var/lib/apt/lists/*
|
|
COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/
|
|
|
|
FROM base AS devcontainer
|
|
RUN apt-get update &&\
|
|
apt-get install -y --no-install-recommends git &&\
|
|
uvx playwright install-deps firefox &&\
|
|
uvx --from git+https://github.com/feder-cr/invisible_playwright.git python -m invisible_playwright fetch &&\
|
|
apt-get clean &&\
|
|
rm -rf /var/lib/apt/lists/*
|
|
ENTRYPOINT [ "sleep", "infinity" ]
|
|
|
|
FROM base AS app
|
|
WORKDIR /app
|
|
|
|
COPY pyproject.toml uv.lock ./
|
|
RUN mkdir -p /cache &&\
|
|
uv sync &&\
|
|
uv run python -m invisible_playwright fetch &&\
|
|
apt-get update &&\
|
|
uv run playwright install-deps firefox &&\
|
|
uv cache clean &&\
|
|
apt-get clean &&\
|
|
rm -rf /var/lib/apt/lists/*
|
|
|
|
COPY . .
|
|
|
|
# Make app and cache world-readable; cache must be writable for runtime browser/profile data
|
|
RUN chmod -R o+rX /app /cache &&\
|
|
chmod -R o+w /cache
|
|
|
|
FROM app AS test
|
|
RUN \
|
|
uv sync --group test &&\
|
|
uv run pytest --retries 3
|
|
|
|
FROM app
|
|
# VERSION is a runtime-only env var (read by src.consts via Pydantic settings).
|
|
# Declared here, not in base, so base/app layer cache keys don't depend on the
|
|
# per-commit SHA — that would bust the cache every run.
|
|
ARG VERSION
|
|
ENV VERSION=${VERSION}
|
|
USER 1000
|
|
EXPOSE $PORT
|
|
HEALTHCHECK --interval=15m --timeout=30s --start-period=5s --retries=3 CMD curl "http://127.0.0.1:${PORT}/health"
|
|
ENTRYPOINT ["tini", "--", "/app/.venv/bin/python", "main.py"]
|