Files
Byparr/tests
ThePhaselessandClaude Opus 5 5130400571 fix: stop an unreachable Cloudflare widget from burning the whole timeout
The bypass tests were failing on CI with 408s after 78 minutes. Neither the
runner's speed nor this branch's TLS change was responsible.

On the sites that fail, Cloudflare serves its interactive checkbox challenge.
playwright-captcha locates the widget iframe inside the shadow root and then
calls ElementHandle.content_frame(), which this Firefox build refuses:

  Protocol error (Page.describeNode): Permission denied to access property
  "docShell" on cross-origin object

Its fallback -- matching page.frames by URL -- cannot help either, because the
challenge frame exposes an empty URL to the parent. Every attempt therefore
ends in CaptchaDetectionError: Cloudflare iframes not found.

MAX_ATTEMPTS was sys.maxsize, so that repeated until the request budget ran
out: 432 docShell errors and 1326 retry iterations in a single request on the
runner, and with max_timeout raised to 360 and --retries 3, a 1h18m job.

Three changes:

- max_attempts defaults to 5. An unreachable widget stays unreachable, so the
  retries were not buying anything; the caller now hears about it in seconds.
- _solve_challenge translates the solver's own give-up exceptions into the 408
  read_item already reports for timeouts. Without this, bounding max_attempts
  would have turned the hang into an unhandled 500.
- The solver framework goes back to PLAYWRIGHT. PATCHRIGHT skips the
  unlockShadowRoot init script and injects over CDP instead, which Firefox has
  no session for ("CDP session is only available in Chromium"). Cloudflare
  builds its widget in a closed shadow root, so on this branch the challenge
  iframe was invisible even to page.locator: 1 -> 0 against the same sites on
  the same runner.

test_bypass drops the max_timeout=360 override and skips again on 408.
Whether Cloudflare shows the interactive challenge depends on the visitor, so
the runner's luck should not decide whether a regression of ours is reported.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-15 11:09:30 +02:00
..
2024-07-24 20:42:23 +00:00
2026-08-15 00:15:50 +02:00