mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:40:11 +01:00
Jon Ross-Perkins
acbe6530c3
What this really does is avoids shadowing names, so that we can comfortable have things like `Check::DiagnosticEmitter` or `Check::DiagnosticLoc` without shadowing being a concern. Note, down this path I'm also thinking about: - Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly just to DiagnosticConsumer/DiagnosticEmitter (so `Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`). - Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`. - But not for `Check::DiagnosticBuilder`, because `Check::Builder` would be ambiguous. - Renaming diagnostics/diagnostic_* to drop "diagnostic". [Discussion about SemIRLoc -> DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698) reminded me of this (in particular the older [Check::DiagnosticBuilder discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)), but I'd only do that rename if there's matching consensus about a path forward where we keep SemIRLoc, and in a way that it's only ever used for diagnostics (the divergence from which is at the root of current LocId discussion). I'm trying to keep that separate from a namespace addition for clarity.
44 lines
1.3 KiB
C++
44 lines
1.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_DIAGNOSTICS_NULL_DIAGNOSTICS_H_
|
|
#define CARBON_TOOLCHAIN_DIAGNOSTICS_NULL_DIAGNOSTICS_H_
|
|
|
|
#include "toolchain/diagnostics/diagnostic_emitter.h"
|
|
|
|
namespace Carbon::Diagnostics {
|
|
|
|
// Returns a singleton consumer that doesn't print its diagnostics.
|
|
inline auto NullConsumer() -> Consumer& {
|
|
struct SingletonConsumer : Consumer {
|
|
auto HandleDiagnostic(Diagnostic /*d*/) -> void override {}
|
|
};
|
|
static auto* consumer = new SingletonConsumer;
|
|
return *consumer;
|
|
}
|
|
|
|
// Returns a singleton emitter that doesn't print its diagnostics.
|
|
template <typename LocT>
|
|
inline auto NullEmitter() -> Emitter<LocT>& {
|
|
class SingletonEmitter : public Emitter<LocT> {
|
|
public:
|
|
using Emitter<LocT>::Emitter;
|
|
|
|
protected:
|
|
// Converts a filename directly to the diagnostic location.
|
|
auto ConvertLoc(LocT /*loc*/,
|
|
Emitter<LocT>::ContextFnT /*context_fn*/) const
|
|
-> ConvertedLoc override {
|
|
return {.loc = {}, .last_byte_offset = -1};
|
|
}
|
|
};
|
|
|
|
static auto* emitter = new SingletonEmitter(&NullConsumer());
|
|
return *emitter;
|
|
}
|
|
|
|
} // namespace Carbon::Diagnostics
|
|
|
|
#endif // CARBON_TOOLCHAIN_DIAGNOSTICS_NULL_DIAGNOSTICS_H_
|