Jon Ross-Perkins fe29224016 Refactor LocId to merge in SemIRLoc (#5284) ...

The main goal of this is to collapse the LocId and SemIRLoc types into a
single type, eliminating the need for APIs to decide which to use. This
originated from discussion about UnwrapSemIRLoc in #5169. Although that
was removed in #5202, it's probably still a good direction for LocId.

This changes the packing of LocId to allow adding InstId, making it
tri-modal: ImportIRInstId, InstId, or NodeId. This has a side-effect of
reducing the available space for ImportIRInstId, although not by much
due to the pre-existing `ImplicitBit` behavior. If needed, we could also
probably play with packing a bit more since `ImplicitBit` really only
applies to `NodeId`, but I was trying to keep the logic a little
simpler. Note `TokenOnlyBit` can still apply to `ImportIRInstId`.

This leaves in place a typedef for SemIRLoc -- I intend to clean that up
separately.

Some Discord discussion is
[here](https://discord.com/channels/655572317891461132/655578254970716160/1353755830058745959).

2025-04-11 13:35:58 +00:00

..

fuzzer_corpus

Change array syntax from [T; N] to array(T, N) (#4981)

2025-02-20 22:42:47 +00:00

testdata

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

action.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

action.h

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

BUILD

Switch tree-sitter from explorer to toolchain testdata (#5292)

2025-04-10 23:45:19 +00:00

call.cpp

Emit function definitions in check, for all specifics seen. (#5090)

2025-04-02 21:51:25 +00:00

call.h

Use As and ImplicitAs interfaces for conversions. (#4209)

2024-09-05 23:39:58 +00:00

check_fuzzer.cpp

Switch Driver back to parameters for construction (#4849)

2025-01-27 23:48:44 +00:00

check_unit.cpp

Refactor LocId to merge in SemIRLoc (#5284)

2025-04-11 13:35:58 +00:00

check_unit.h

Emit function definitions in check, for all specifics seen. (#5090)

2025-04-02 21:51:25 +00:00

check.cpp

Use DiagnosticEmitter for phase-specific types (#5188)

2025-03-27 00:41:30 +00:00

check.h

Use DiagnosticEmitter for phase-specific types (#5188)

2025-03-27 00:41:30 +00:00

class.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

class.h

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

context.cpp

Use DiagnosticEmitter for phase-specific types (#5188)

2025-03-27 00:41:30 +00:00

context.h

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

control_flow.cpp

Support destruction of storage (#5171)

2025-03-28 00:29:17 +00:00

control_flow.h

Support destruction of storage (#5171)

2025-03-28 00:29:17 +00:00

convert.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

convert.h

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

decl_introducer_state.h

Add more empty stack verification (#5020)

2025-03-01 07:56:04 +00:00

decl_name_stack.cpp

Replace uses of "defined" with "complete" (#5196)

2025-03-27 18:14:26 +00:00

decl_name_stack.h

Rewrite symbolic constants in generic redeclarations (#5154)

2025-03-21 22:26:08 +00:00

deduce.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

deduce.h

Avoid UAF in impl lookup when deduce imports an impl from Core (#5126)

2025-03-14 00:44:51 +00:00

deferred_definition_worklist.cpp

Split deferred node traversal out from check.cpp (#4559)

2024-11-20 20:58:58 +00:00

deferred_definition_worklist.h

Split deferred node traversal out from check.cpp (#4559)

2024-11-20 20:58:58 +00:00

diagnostic_emitter.cpp

Refactor LocId to merge in SemIRLoc (#5284)

2025-04-11 13:35:58 +00:00

diagnostic_emitter.h

Refactor LocId to merge in SemIRLoc (#5284)

2025-04-11 13:35:58 +00:00

diagnostic_helpers.h

Refactor LocId to merge in SemIRLoc (#5284)

2025-04-11 13:35:58 +00:00

dump.cpp

Refactor LocId to merge in SemIRLoc (#5284)

2025-04-11 13:35:58 +00:00

eval_inst.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

eval_inst.h

Add an EvalOrAddInst function. (#5258)

2025-04-08 21:04:30 +00:00

eval.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

eval.h

Add an EvalOrAddInst function. (#5258)

2025-04-08 21:04:30 +00:00

facet_type.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

facet_type.h

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

full_pattern_stack.h

Clean up handling of Call params (#5061)

2025-03-04 21:01:59 +00:00

function.cpp

Add error for virtual member function without self (#5005)

2025-02-27 17:01:29 +00:00

function.h

Add error for virtual member function without self (#5005)

2025-02-27 17:01:29 +00:00

generic_region_stack.cpp

Create an array stack type for a shared use-case (#4100)

2024-07-03 16:58:47 +00:00

generic_region_stack.h

Add more empty stack verification (#5020)

2025-03-01 07:56:04 +00:00

generic.cpp

Change RebuildGenericConstantInEvalBlockCallbacks.context_ from reference to pointer (#5205)

2025-03-28 15:14:02 +00:00

generic.h

Replace GetInstForSpecific with direct support for rendering a SpecificId in diagnostics. (#5192)

2025-03-26 22:53:32 +00:00

global_init.cpp

[Refactor] Move call_params_id from EntityBase to FunctionFields. (#5146)

2025-03-18 23:49:24 +00:00

global_init.h

Split global init out from InstBlockStack. (#4101)

2024-07-03 17:49:47 +00:00

handle_alias.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_array.cpp

Preserve type sugar in ArrayType, ConstType, and PointerType. (#5235)

2025-04-03 21:14:03 +00:00

handle_binding_pattern.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

handle_call_expr.cpp

Include the call arguments in the location of a call. (#4602)

2024-12-02 18:51:44 +00:00

handle_choice.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

handle_class.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

handle_codeblock.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_export.cpp

Fix crash when exporting a poisoned name (#5074)

2025-03-05 21:55:30 +00:00

handle_expr_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_file.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_function.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

handle_if_expr.cpp

Refactor region_stack logic out of Context (#4927)

2025-02-12 00:21:07 +00:00

handle_if_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_impl.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

handle_import_and_package.cpp

Implement #4864: Core is a keyword (#4909)

2025-02-11 21:33:57 +00:00

handle_index.cpp

Preserve type sugar in ArrayType, ConstType, and PointerType. (#5235)

2025-04-03 21:14:03 +00:00

handle_interface.cpp

Use Get*Type in a couple spots (#5257)

2025-04-07 22:41:27 +00:00

handle_let_and_var.cpp

Support destruction of storage (#5171)

2025-03-28 00:29:17 +00:00

handle_literal.cpp

Move diagnostics into a namespace (#5173)

2025-03-26 19:12:10 +00:00

handle_loop_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_match.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_modifier.cpp

Remove obsolete '...' hints on node kind macros (#4958)

2025-02-15 01:36:46 +00:00

handle_name.cpp

Replace GetTypeInSpecific with GetTypeOfInstInSpecific. (#5232)

2025-04-02 22:52:11 +00:00

handle_named_constraint.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_namespace.cpp

Reduce explicit SemIR::LocIdAndInst construction (#5153)

2025-03-21 21:45:53 +00:00

handle_noop.cpp

Abort checking when encountering an invalid parse node (#4700)

2024-12-18 00:19:12 +00:00

handle_operator.cpp

Preserve type sugar in ArrayType, ConstType, and PointerType. (#5235)

2025-04-03 21:14:03 +00:00

handle_paren_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_pattern_list.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

handle_return_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_struct.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

handle_tuple_literal.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

handle_where.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

handle.h

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

impl_lookup.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

impl_lookup.h

Look for final impl when accessing associated constant in facet (#5269)

2025-04-10 13:48:49 +00:00

impl.cpp

Look for final impl when accessing associated constant in facet (#5269)

2025-04-10 13:48:49 +00:00

impl.h

Look for final impl when accessing associated constant in facet (#5269)

2025-04-10 13:48:49 +00:00

import_cpp.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

import_cpp.h

Add support for importing a trivial global C++ function (#5033)

2025-03-03 10:38:19 +00:00

import_ref.cpp

Refactor LocId to merge in SemIRLoc (#5284)

2025-04-11 13:35:58 +00:00

import_ref.h

When diagnosing a duplicated name, add the name to the diagnosis (#4902)

2025-02-19 07:19:23 +00:00

import.cpp

Refactor LocId to merge in SemIRLoc (#5284)

2025-04-11 13:35:58 +00:00

import.h

Add support for importing C++ namespaces (#5103)

2025-03-15 20:41:48 +00:00

inst_block_stack.cpp

Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)

2025-03-21 23:09:37 +00:00

inst_block_stack.h

Invalid comment cleanup (#4836)

2025-01-23 02:21:48 +00:00

inst.cpp

Add an EvalOrAddInst function. (#5258)

2025-04-08 21:04:30 +00:00

inst.h

Add an EvalOrAddInst function. (#5258)

2025-04-08 21:04:30 +00:00

interface.cpp

Provide an InstId when evaluating a constant in cases where one is needed (#5202)

2025-04-08 00:40:21 +00:00

interface.h

Renumber inner parameters when checking an impl function against an interface function. (#5113)

2025-03-12 13:54:49 +00:00

keyword_modifier_set.h

Treat associated constants as entities parameterized by Self (#4837)

2025-01-25 02:13:52 +00:00

lexical_lookup.h

Refactor value store code to use separate files. (#4477)

2024-11-04 04:00:17 +00:00

literal.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

literal.h

Factor out machinery for forming int type literals. (#4616)

2024-12-03 18:46:27 +00:00

member_access.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

member_access.h

Store an InterfaceId and a SpecificId in AssociatedEntityType. (#5252)

2025-04-05 16:08:09 +00:00

merge.cpp

Replace GetTypeInSpecific with GetTypeOfInstInSpecific. (#5232)

2025-04-02 22:52:11 +00:00

merge.h

Add error for virtual member function without self (#5005)

2025-02-27 17:01:29 +00:00

modifiers.cpp

Use DiagnosticEmitter for phase-specific types (#5188)

2025-03-27 00:41:30 +00:00

modifiers.h

Refactor modifier formatting to remove string passing. (#4418)

2024-10-17 22:47:40 +00:00

name_component.cpp

Fix parse support for 'fn F[];' (#5135)

2025-03-18 00:31:17 +00:00

name_component.h

Id::Invalid -> Id::None (#4834)

2025-01-22 23:15:00 +00:00

name_lookup.cpp

Implement ...where .Self impls... (#5238)

2025-04-07 20:45:45 +00:00

name_lookup.h

When diagnosing a duplicated name, add the name to the diagnosis (#4902)

2025-02-19 07:19:23 +00:00

node_id_traversal.cpp

Change NodeIdTraversal.context_ from reference to pointer (#5210)

2025-03-28 16:24:17 +00:00

node_id_traversal.h

Change NodeIdTraversal.context_ from reference to pointer (#5210)

2025-03-28 16:24:17 +00:00

node_stack.cpp

Avoid redundantly specifying Id::Kind. (#4911)

2025-02-07 22:35:18 +00:00

node_stack.h

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

operator.cpp

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

operator.h

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

param_and_arg_refs_stack.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

pattern_match.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

pattern_match.h

Invalid comment cleanup (#4836)

2025-01-23 02:21:48 +00:00

pending_block.h

Change PendingBlock.context_ from reference to pointer (#5209)

2025-03-28 16:24:11 +00:00

pointer_dereference.cpp

Preserve type sugar in ArrayType, ConstType, and PointerType. (#5235)

2025-04-03 21:14:03 +00:00

pointer_dereference.h

Handle arrow operator (#3768)

2024-03-18 17:40:00 +00:00

region_stack.h

Add more empty stack verification (#5020)

2025-03-01 07:56:04 +00:00

return.cpp

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

return.h

Model var as a pattern operator (#4720)

2025-01-17 17:51:34 +00:00

scope_index.h

Move None to IdBase (#5030)

2025-03-01 08:00:17 +00:00

scope_stack.cpp

Fix clang-tidy: use a ranges version of this algorithm [modernize-use-ranges,-warnings-as-errors] (#5268)

2025-04-08 15:37:52 +00:00

scope_stack.h

Support destruction of storage (#5171)

2025-03-28 00:29:17 +00:00

subpattern.cpp

Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)

2025-03-21 23:09:37 +00:00

subpattern.h

Support tuple patterns outside parameter lists (#4923)

2025-02-20 03:17:45 +00:00

subst.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

subst.h

Rebuild the type of a bind_symbolic_name when building an eval block (#5174)

2025-03-25 22:53:25 +00:00

type_completion.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

type_completion.h

Forward impl declarations of incomplete facet types (#5219)

2025-04-02 01:46:27 +00:00

type_structure.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

type_structure.h

Include all symbolic parts in structure comparison (#5247)

2025-04-08 19:02:55 +00:00

type.cpp

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00

type.h

Introduce TypeInstId (#5288)

2025-04-10 22:59:02 +00:00