josh11bandJosh L fb3721df9a Impl lookup allowed for incomplete facet types (#5132) ...

New planned direction is to not require completeness. Updated comments
to reflect that some care will be needed once named constraints are
supported. Long term plan is [discussed in
#5089](https://github.com/carbon-language/carbon-lang/pull/5089#discussion_r1985908453):

> We have some options. In our last conversation, it sounded like it
would be beneficial for named constraints to have their own witnesses,
with entries in declaration order. This would allow accesses to the
named constraint while it was being defined. So there would be something
of a hierarchy in a facet type witness, with a named constraint taking a
single slot in a facet type witness, independent of its definition.

Co-authored-by: Josh L <josh11b@users.noreply.github.com>

2025-03-15 02:21:49 +00:00

..

fuzzer_corpus

Change array syntax from [T; N] to array(T, N) (#4981)

2025-02-20 22:42:47 +00:00

testdata

Impl lookup allowed for incomplete facet types (#5132)

2025-03-15 02:21:49 +00:00

BUILD

Add support for importing a trivial global C++ function (#5033)

2025-03-03 10:38:19 +00:00

call.cpp

Reverse nesting of BoundMethod and SpecificFunction. (#5079)

2025-03-08 01:34:06 +00:00

call.h

Use As and ImplicitAs interfaces for conversions. (#4209)

2024-09-05 23:39:58 +00:00

check_fuzzer.cpp

Switch Driver back to parameters for construction (#4849)

2025-01-27 23:48:44 +00:00

check_unit.cpp

Change NodeIdOneOf and similar to use "requires" and explicit UnsafeMake (#5084)

2025-03-12 00:33:54 +00:00

check_unit.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

check.cpp

Generate Cpp namespace when import Cpp is used (#4873)

2025-02-12 01:44:37 +00:00

check.h

Add support for importing a trivial global C++ function (#5033)

2025-03-03 10:38:19 +00:00

context.cpp

Add more empty stack verification (#5020)

2025-03-01 07:56:04 +00:00

context.h

Support conversion from facet value to facet value (#5085)

2025-03-14 23:58:36 +00:00

control_flow.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

control_flow.h

Move control flow block functions to their own file. (#4921)

2025-02-11 21:38:09 +00:00

convert.cpp

Support conversion from facet value to facet value (#5085)

2025-03-14 23:58:36 +00:00

convert.h

Avoid diagnosing conversion errors inside deduction of impl arguments (#4976)

2025-02-19 21:46:46 +00:00

decl_introducer_state.h

Add more empty stack verification (#5020)

2025-03-01 07:56:04 +00:00

decl_name_stack.cpp

Refactor BuildFunctionDecl (#5098)

2025-03-11 22:53:13 +00:00

decl_name_stack.h

Use the NameComponent's name_id when making an entity base (#5125)

2025-03-14 15:27:24 +00:00

deduce.cpp

Avoid UAF in impl lookup when deduce imports an impl from Core (#5126)

2025-03-14 00:44:51 +00:00

deduce.h

Avoid UAF in impl lookup when deduce imports an impl from Core (#5126)

2025-03-14 00:44:51 +00:00

deferred_definition_worklist.cpp

Split deferred node traversal out from check.cpp (#4559)

2024-11-20 20:58:58 +00:00

deferred_definition_worklist.h

Split deferred node traversal out from check.cpp (#4559)

2024-11-20 20:58:58 +00:00

diagnostic_helpers.h

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

dump.cpp

First iteration of completing and resolving facet types (#4920)

2025-02-19 22:10:11 +00:00

eval_inst.cpp

Return a set of ImplWitnesses from impl lookup (#5075)

2025-03-10 16:00:35 +00:00

eval_inst.h

Move the EvalConstantInst overloads out of eval.cpp into their own file. (#5040)

2025-02-28 00:50:43 +00:00

eval.cpp

Renumber inner parameters when checking an impl function against an interface function. (#5113)

2025-03-12 13:54:49 +00:00

eval.h

Produce a note indicating where the specific was used from if monomorphization fails. (#4662)

2024-12-11 22:34:10 +00:00

facet_type.cpp

Add TypeId::is_symbolic and is_concrete. (#5024)

2025-02-27 00:21:01 +00:00

facet_type.h

First iteration of completing and resolving facet types (#4920)

2025-02-19 22:10:11 +00:00

full_pattern_stack.h

Clean up handling of Call params (#5061)

2025-03-04 21:01:59 +00:00

function.cpp

Add error for virtual member function without self (#5005)

2025-02-27 17:01:29 +00:00

function.h

Add error for virtual member function without self (#5005)

2025-02-27 17:01:29 +00:00

generic_region_stack.cpp

Create an array stack type for a shared use-case (#4100)

2024-07-03 16:58:47 +00:00

generic_region_stack.h

Add more empty stack verification (#5020)

2025-03-01 07:56:04 +00:00

generic.cpp

Completing a type no longer ignores facet types (#5004)

2025-02-22 21:40:43 +00:00

generic.h

Completing a type no longer ignores facet types (#5004)

2025-02-22 21:40:43 +00:00

global_init.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

global_init.h

Split global init out from InstBlockStack. (#4101)

2024-07-03 17:49:47 +00:00

handle_alias.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_array.cpp

Change array syntax from [T; N] to array(T, N) (#4981)

2025-02-20 22:42:47 +00:00

handle_binding_pattern.cpp

Add support for var patterns (#5069)

2025-03-06 19:06:51 +00:00

handle_call_expr.cpp

Include the call arguments in the location of a call. (#4602)

2024-12-02 18:51:44 +00:00

handle_choice.cpp

Make choice work for alternatives without parameters (#4815)

2025-02-19 16:37:36 +00:00

handle_class.cpp

Fix crash discovered by fuzzer. (#5100)

2025-03-12 21:35:31 +00:00

handle_codeblock.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_export.cpp

Fix crash when exporting a poisoned name (#5074)

2025-03-05 21:55:30 +00:00

handle_expr_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_file.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_function.cpp

Add declaration checking for fn destroy (#5127)

2025-03-14 22:54:12 +00:00

handle_if_expr.cpp

Refactor region_stack logic out of Context (#4927)

2025-02-12 00:21:07 +00:00

handle_if_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_impl.cpp

Clean up handling of Call params (#5061)

2025-03-04 21:01:59 +00:00

handle_import_and_package.cpp

Implement #4864: Core is a keyword (#4909)

2025-02-11 21:33:57 +00:00

handle_index.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_interface.cpp

Associated constants can be used in member function signatures (#5089)

2025-03-12 00:33:46 +00:00

handle_let_and_var.cpp

Add support for var patterns (#5069)

2025-03-06 19:06:51 +00:00

handle_literal.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_loop_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_match.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_modifier.cpp

Remove obsolete '...' hints on node kind macros (#4958)

2025-02-15 01:36:46 +00:00

handle_name.cpp

Add declaration checking for fn destroy (#5127)

2025-03-14 22:54:12 +00:00

handle_named_constraint.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_namespace.cpp

When diagnosing a duplicated name, add the name to the diagnosis (#4902)

2025-02-19 07:19:23 +00:00

handle_noop.cpp

Abort checking when encountering an invalid parse node (#4700)

2024-12-18 00:19:12 +00:00

handle_operator.cpp

Add parsing for partial types (#5009)

2025-02-25 02:07:10 +00:00

handle_paren_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_pattern_list.cpp

Support tuple patterns outside parameter lists (#4923)

2025-02-20 03:17:45 +00:00

handle_return_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_struct.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_tuple_literal.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_where.cpp

Add TypeId::is_symbolic and is_concrete. (#5024)

2025-02-27 00:21:01 +00:00

handle.h

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

impl_lookup.cpp

Impl lookup allowed for incomplete facet types (#5132)

2025-03-15 02:21:49 +00:00

impl_lookup.h

Support conversion from facet value to facet value (#5085)

2025-03-14 23:58:36 +00:00

impl.cpp

Renumber inner parameters when checking an impl function against an interface function. (#5113)

2025-03-12 13:54:49 +00:00

impl.h

First iteration of completing and resolving facet types (#4920)

2025-02-19 22:10:11 +00:00

import_cpp.cpp

Support mangling imported C++ functions using Clang's MangleContext (#5062)

2025-03-06 09:51:01 +00:00

import_cpp.h

Add support for importing a trivial global C++ function (#5033)

2025-03-03 10:38:19 +00:00

import_ref.cpp

Associated constants can be used in member function signatures (#5089)

2025-03-12 00:33:46 +00:00

import_ref.h

When diagnosing a duplicated name, add the name to the diagnosis (#4902)

2025-02-19 07:19:23 +00:00

import.cpp

Change NodeIdOneOf and similar to use "requires" and explicit UnsafeMake (#5084)

2025-03-12 00:33:54 +00:00

import.h

Generate Cpp namespace when import Cpp is used (#4873)

2025-02-12 01:44:37 +00:00

inst_block_stack.cpp

Id::Invalid -> Id::None (#4834)

2025-01-22 23:15:00 +00:00

inst_block_stack.h

Invalid comment cleanup (#4836)

2025-01-23 02:21:48 +00:00

inst.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

inst.h

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

interface.cpp

Renumber inner parameters when checking an impl function against an interface function. (#5113)

2025-03-12 13:54:49 +00:00

interface.h

Renumber inner parameters when checking an impl function against an interface function. (#5113)

2025-03-12 13:54:49 +00:00

keyword_modifier_set.h

Treat associated constants as entities parameterized by Self (#4837)

2025-01-25 02:13:52 +00:00

lexical_lookup.h

Refactor value store code to use separate files. (#4477)

2024-11-04 04:00:17 +00:00

literal.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

literal.h

Factor out machinery for forming int type literals. (#4616)

2024-12-03 18:46:27 +00:00

member_access.cpp

Associated constants can be used in member function signatures (#5089)

2025-03-12 00:33:46 +00:00

member_access.h

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

merge.cpp

Clean up handling of Call params (#5061)

2025-03-04 21:01:59 +00:00

merge.h

Add error for virtual member function without self (#5005)

2025-02-27 17:01:29 +00:00

modifiers.cpp

Id::Invalid -> Id::None (#4834)

2025-01-22 23:15:00 +00:00

modifiers.h

Refactor modifier formatting to remove string passing. (#4418)

2024-10-17 22:47:40 +00:00

name_component.cpp

Add parsing for 'fn destroy' (#5045)

2025-03-03 17:37:10 +00:00

name_component.h

Id::Invalid -> Id::None (#4834)

2025-01-22 23:15:00 +00:00

name_lookup.cpp

Associated constants can be used in member function signatures (#5089)

2025-03-12 00:33:46 +00:00

name_lookup.h

When diagnosing a duplicated name, add the name to the diagnosis (#4902)

2025-02-19 07:19:23 +00:00

node_id_traversal.cpp

Id::Invalid -> Id::None (#4834)

2025-01-22 23:15:00 +00:00

node_id_traversal.h

Id::Invalid -> Id::None (#4834)

2025-01-22 23:15:00 +00:00

node_stack.cpp

Avoid redundantly specifying Id::Kind. (#4911)

2025-02-07 22:35:18 +00:00

node_stack.h

Fix use of keyword names in qualifiers with params (#5130)

2025-03-14 20:16:01 +00:00

operator.cpp

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

operator.h

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

param_and_arg_refs_stack.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

pattern_match.cpp

Add support for var patterns (#5069)

2025-03-06 19:06:51 +00:00

pattern_match.h

Invalid comment cleanup (#4836)

2025-01-23 02:21:48 +00:00

pending_block.h

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

pointer_dereference.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

pointer_dereference.h

Handle arrow operator (#3768)

2024-03-18 17:40:00 +00:00

region_stack.h

Add more empty stack verification (#5020)

2025-03-01 07:56:04 +00:00

return.cpp

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

return.h

Model var as a pattern operator (#4720)

2025-01-17 17:51:34 +00:00

scope_index.h

Move None to IdBase (#5030)

2025-03-01 08:00:17 +00:00

scope_stack.cpp

Clean up handling of Call params (#5061)

2025-03-04 21:01:59 +00:00

scope_stack.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

sem_ir_loc_diagnostic_emitter.cpp

Combine DiagnosticConverter into DiagnosticEmitter (#4878)

2025-02-06 20:27:57 +00:00

sem_ir_loc_diagnostic_emitter.h

Combine DiagnosticConverter into DiagnosticEmitter (#4878)

2025-02-06 20:27:57 +00:00

subpattern.cpp

Support tuple patterns outside parameter lists (#4923)

2025-02-20 03:17:45 +00:00

subpattern.h

Support tuple patterns outside parameter lists (#4923)

2025-02-20 03:17:45 +00:00

subst.cpp

First iteration of completing and resolving facet types (#4920)

2025-02-19 22:10:11 +00:00

subst.h

Basic support for implementing and using a parameterized interface. (#4203)

2024-08-09 01:05:03 +00:00

type_completion.cpp

Associated constants can be used in member function signatures (#5089)

2025-03-12 00:33:46 +00:00

type_completion.h

Associated constants can be used in member function signatures (#5089)

2025-03-12 00:33:46 +00:00

type.cpp

Move the EvalConstantInst overloads out of eval.cpp into their own file. (#5040)

2025-02-28 00:50:43 +00:00

type.h

Move the EvalConstantInst overloads out of eval.cpp into their own file. (#5040)

2025-02-28 00:50:43 +00:00