mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-03 22:02:51 +01:00
This adds just enough debug info for i32/int parameters and return
values, with a path forward for adding DWARF type metadata for other
types.
As it happens, return type information is carried separately from
parameter information:
* Return type information is carried in the `type` of the `DISubprogram`
(as a `DISubroutineType` - which does carry parameter type information
as well, but that's unused when the DWARF is emitted by LLVM)
* Parameter information is carried by `DILocalVariable`s with a non-zero
`arg` value (representing the order of function parameters)
In the absence of locations for the parameters (future work), nothing
would usually keep the `DILocalVariable` live/reachable when emitting
DWARF - so for cases where this can happen (for clang, this happens in
optimized builds where all references to the parameter variable might be
optimized away) the variables can be "retained" in a list on the
`DISubprogram` - achieved by passing `AlwaysPreserve` parameter to
`createParameterVariable` (adds them to a list, then that list gets
attached to the `DISubprogram` when it's finalized later)
For now, any unsupported types are emitted as `void*` (except void
return, which is implemented as void) as a placeholder.
Given this example:
```
import Core library "io";
class MyClass {
}
fn Unsupported(v: MyClass) {
}
fn Ret() -> i32 {
return 42;
}
fn Arg(x: i32) {
Core.Print(x);
}
fn Run() {
}
```
this is the resulting DWARF:
```
DW_TAG_compile_unit
DW_AT_name ("test.carbon")
DW_TAG_subprogram
DW_AT_name ("Unsupported")
DW_TAG_formal_parameter
DW_AT_type (0x00000066 "void *")
DW_TAG_subprogram
DW_AT_name ("Ret")
DW_AT_type (0x00000062 "int")
DW_TAG_subprogram
DW_AT_name ("Arg")
DW_TAG_formal_parameter
DW_AT_type (0x00000062 "int")
DW_TAG_subprogram
DW_AT_name ("Run")
DW_TAG_base_type
DW_AT_name ("int")
DW_TAG_pointer_type
```
And the debugger:
```
(gdb) p Ret()
$1 = 42
(gdb) p Arg(4)
4
$2 = void
```
I'm not sure if there's a way this logic should be merged with the logic
for making the `llvm::Function` type (which the `DISubroutineType`
building code was inspired by/copied from) - since they're done at
different times/places, I don't think there's an easy way to do it in
one pass, but maybe the code can be shared (even if it's run twice) in
some generic `SemIR::Function` type walker.
---------
Co-authored-by: Dana Jansens <danakj@orodu.net>
112 lines
6.1 KiB
Plaintext
112 lines
6.1 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/full.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/lower/testdata/function/generic/call_recursive_reorder.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/lower/testdata/function/generic/call_recursive_reorder.carbon
|
|
|
|
// Builds on `call_recursive_basic.carbon`.
|
|
|
|
fn F[T:! type, U:! type](x: T, y: U, count: i32) -> i32 {
|
|
if (count > 2) {
|
|
return count;
|
|
}
|
|
return F(y, x, count + 1);
|
|
}
|
|
|
|
fn M() {
|
|
var ptr_i32 : i32*;
|
|
var ptr_f64 : f64*;
|
|
var ptr_bool : bool*;
|
|
|
|
F(ptr_i32, ptr_bool, 0);
|
|
F(ptr_f64, ptr_bool, 0);
|
|
}
|
|
|
|
// CHECK:STDOUT: ; ModuleID = 'call_recursive_reorder.carbon'
|
|
// CHECK:STDOUT: source_filename = "call_recursive_reorder.carbon"
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: nounwind
|
|
// CHECK:STDOUT: define void @_CM.Main() #0 !dbg !4 {
|
|
// CHECK:STDOUT: entry:
|
|
// CHECK:STDOUT: %ptr_i32.var = alloca ptr, align 8, !dbg !7
|
|
// CHECK:STDOUT: %ptr_f64.var = alloca ptr, align 8, !dbg !8
|
|
// CHECK:STDOUT: %ptr_bool.var = alloca ptr, align 8, !dbg !9
|
|
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %ptr_i32.var), !dbg !7
|
|
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %ptr_f64.var), !dbg !8
|
|
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %ptr_bool.var), !dbg !9
|
|
// CHECK:STDOUT: %.loc27_5 = load ptr, ptr %ptr_i32.var, align 8, !dbg !10
|
|
// CHECK:STDOUT: %.loc27_14 = load ptr, ptr %ptr_bool.var, align 8, !dbg !11
|
|
// CHECK:STDOUT: %F.call.loc27 = call i32 @_CF.Main.2fe87eb83f5a4614(ptr %.loc27_5, ptr %.loc27_14, i32 0), !dbg !12
|
|
// CHECK:STDOUT: %.loc28_5 = load ptr, ptr %ptr_f64.var, align 8, !dbg !13
|
|
// CHECK:STDOUT: %.loc28_14 = load ptr, ptr %ptr_bool.var, align 8, !dbg !14
|
|
// CHECK:STDOUT: %F.call.loc28 = call i32 @_CF.Main.2fe87eb83f5a4614(ptr %.loc28_5, ptr %.loc28_14, i32 0), !dbg !15
|
|
// CHECK:STDOUT: ret void, !dbg !16
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: nocallback nofree nosync nounwind willreturn memory(argmem: readwrite)
|
|
// CHECK:STDOUT: declare void @llvm.lifetime.start.p0(ptr captures(none)) #1
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: nounwind
|
|
// CHECK:STDOUT: define linkonce_odr i32 @_CF.Main.2fe87eb83f5a4614(ptr %x, ptr %y, i32 %count) #0 !dbg !17 {
|
|
// CHECK:STDOUT: entry:
|
|
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Greater.call = icmp sgt i32 %count, 2, !dbg !26
|
|
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Greater.call, label %if.then, label %if.else, !dbg !27
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: if.then: ; preds = %entry
|
|
// CHECK:STDOUT: ret i32 %count, !dbg !28
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: if.else: ; preds = %entry
|
|
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %count, 1, !dbg !29
|
|
// CHECK:STDOUT: %F.call = call i32 @_CF.Main.2fe87eb83f5a4614(ptr %y, ptr %x, i32 %Int.as.AddWith.impl.Op.call), !dbg !30
|
|
// CHECK:STDOUT: ret i32 %F.call, !dbg !31
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; uselistorder directives
|
|
// CHECK:STDOUT: uselistorder ptr @llvm.lifetime.start.p0, { 2, 1, 0 }
|
|
// CHECK:STDOUT: uselistorder ptr @_CF.Main.2fe87eb83f5a4614, { 0, 2, 1 }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: attributes #0 = { nounwind }
|
|
// CHECK:STDOUT: attributes #1 = { nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !llvm.module.flags = !{!0, !1}
|
|
// CHECK:STDOUT: !llvm.dbg.cu = !{!2}
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !0 = !{i32 7, !"Dwarf Version", i32 5}
|
|
// CHECK:STDOUT: !1 = !{i32 2, !"Debug Info Version", i32 3}
|
|
// CHECK:STDOUT: !2 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !3, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
|
|
// CHECK:STDOUT: !3 = !DIFile(filename: "call_recursive_reorder.carbon", directory: "")
|
|
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "M", linkageName: "_CM.Main", scope: null, file: !3, line: 22, type: !5, spFlags: DISPFlagDefinition, unit: !2)
|
|
// CHECK:STDOUT: !5 = !DISubroutineType(types: !6)
|
|
// CHECK:STDOUT: !6 = !{null}
|
|
// CHECK:STDOUT: !7 = !DILocation(line: 23, column: 3, scope: !4)
|
|
// CHECK:STDOUT: !8 = !DILocation(line: 24, column: 3, scope: !4)
|
|
// CHECK:STDOUT: !9 = !DILocation(line: 25, column: 3, scope: !4)
|
|
// CHECK:STDOUT: !10 = !DILocation(line: 27, column: 5, scope: !4)
|
|
// CHECK:STDOUT: !11 = !DILocation(line: 27, column: 14, scope: !4)
|
|
// CHECK:STDOUT: !12 = !DILocation(line: 27, column: 3, scope: !4)
|
|
// CHECK:STDOUT: !13 = !DILocation(line: 28, column: 5, scope: !4)
|
|
// CHECK:STDOUT: !14 = !DILocation(line: 28, column: 14, scope: !4)
|
|
// CHECK:STDOUT: !15 = !DILocation(line: 28, column: 3, scope: !4)
|
|
// CHECK:STDOUT: !16 = !DILocation(line: 22, column: 1, scope: !4)
|
|
// CHECK:STDOUT: !17 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main.2fe87eb83f5a4614", scope: null, file: !3, line: 15, type: !18, spFlags: DISPFlagDefinition, unit: !2, retainedNodes: !22)
|
|
// CHECK:STDOUT: !18 = !DISubroutineType(types: !19)
|
|
// CHECK:STDOUT: !19 = !{!20, !21, !21, !20}
|
|
// CHECK:STDOUT: !20 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
|
|
// CHECK:STDOUT: !21 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: null, size: 8)
|
|
// CHECK:STDOUT: !22 = !{!23, !24, !25}
|
|
// CHECK:STDOUT: !23 = !DILocalVariable(arg: 1, scope: !17, type: !21)
|
|
// CHECK:STDOUT: !24 = !DILocalVariable(arg: 2, scope: !17, type: !21)
|
|
// CHECK:STDOUT: !25 = !DILocalVariable(arg: 3, scope: !17, type: !20)
|
|
// CHECK:STDOUT: !26 = !DILocation(line: 16, column: 7, scope: !17)
|
|
// CHECK:STDOUT: !27 = !DILocation(line: 16, column: 6, scope: !17)
|
|
// CHECK:STDOUT: !28 = !DILocation(line: 17, column: 5, scope: !17)
|
|
// CHECK:STDOUT: !29 = !DILocation(line: 19, column: 18, scope: !17)
|
|
// CHECK:STDOUT: !30 = !DILocation(line: 19, column: 10, scope: !17)
|
|
// CHECK:STDOUT: !31 = !DILocation(line: 19, column: 3, scope: !17)
|